Skip to content

Commit 8ef8bba

Browse files
authored
chore(ramps-controller): fix changelog formatting (#7530)
## Explanation The CHANGELOG.md for `@metamask/ramps-controller` had several formatting issues that were causing CI to fail: - Entries in an "Uncategorized" section that needed proper categorization - Some entries referenced the wrong PR (#7316 instead of #7502) - Missing PR links on some entries - Non-consumer facing dev entries (dev-watch.js, link-ramp-controller.js scripts) that should not be in the changelog Additionally, the changes from #7502 rename public APIs (`OnRampService` → `RampsService`, action types, etc.) which are breaking changes. Per semver, this requires a major version bump from 1.0.0 to 2.0.0 rather than a patch release. This PR fixes the changelog formatting and updates the version to 2.0.0 to properly reflect the breaking nature of the API changes. ## References - Related to #7502 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs) - [] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Cleans up @metamask/ramps-controller CHANGELOG: removes dev-only entries, marks breaking API renames, and fixes PR references and entries. > > - **Changelog (packages/ramps-controller/CHANGELOG.md)**: > - Mark breaking changes in `Unreleased` for renaming `OnRampService` → `RampsService`, `OnRampEnvironment` → `RampsEnvironment`, and action type namespace updates, with links to `#7502`. > - Remove non-consumer dev entries from `Added` section. > - Correct and link PR references; update `Fixed` entry for `RampsService#getGeolocation` to include `#7502`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d05ac8a. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 4616964 commit 8ef8bba

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

packages/ramps-controller/CHANGELOG.md

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10-
### Added
11-
12-
- Add `dev-watch.js` and `link-ramp-controller.js` scripts to auto-build and copy `dist/` into `metamask-mobile/node_modules/@metamask/ramps-controller`
13-
- Add `"dev": "node dev-watch.js"` script to `package.json`
14-
1510
### Changed
1611

17-
- Rename `OnRampService` to `RampsService` and `OnRampEnvironment` to `RampsEnvironment` ([#7316](https://github.com/MetaMask/core/pull/7316))
18-
- Rename action types from `OnRampService:*` to `RampsService:*` (e.g., `OnRampService:getGeolocation``RampsService:getGeolocation`)
19-
- Update imports, messenger types/namespaces, and exports in `src/index.ts`, controller/service files, and tests
12+
- **BREAKING:** Rename `OnRampService` to `RampsService` and `OnRampEnvironment` to `RampsEnvironment` ([#7502](https://github.com/MetaMask/core/pull/7502))
13+
- **BREAKING:** Rename action types from `OnRampService:*` to `RampsService:*` (e.g., `OnRampService:getGeolocation``RampsService:getGeolocation`) ([#7502](https://github.com/MetaMask/core/pull/7502))
2014

2115
### Fixed
2216

23-
- Fix `RampsService#getGeolocation` to read response text within the policy execution and return parsed text
17+
- Fix `RampsService#getGeolocation` to read response text within the policy execution and return parsed text ([#7502](https://github.com/MetaMask/core/pull/7502))
2418

2519
## [1.0.0]
2620

0 commit comments

Comments
 (0)