chore: Remove network-controller dependency for chain-agnostic-permission (#7561)

## Explanation

Remove `network-controller` dependency for `chain-agnostic-permission`
as it brings in a massive amount of dependencies and is only used for a
single type union that contains `string` anyway.

The additional dependencies becomes hard to manage when using
`chain-agnostic-permission` outside a MetaMask client (e.g. in Snaps).

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Removes the `@metamask/network-controller` dependency and eliminates
its type usage.
> 
> - Drops `@metamask/network-controller` from `package.json` and
`yarn.lock`
> - Updates `caip25Permission.ts` to remove the import and change
`findNetworkClientIdByChainId` return type from `NetworkClientId` to
`string`
> - Notes the change in `CHANGELOG.md`
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
36a8356. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: FrederikBolding

packages/chain-agnostic-permission/CHANGELOG.md

@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- Remove `@metamask/network-controller` dependency ([#7561](https://github.com/MetaMask/core/pull/7561))
 - Upgrade `@metamask/utils` from `^11.8.1` to `^11.9.0` ([#7511](https://github.com/MetaMask/core/pull/7511))
 - Bump `@metamask/network-controller` from `^27.0.0` to `^27.1.0` ([#7534](https://github.com/MetaMask/core/pull/7534))
 - Bump `@metamask/controller-utils` from `^11.16.0` to `^11.17.0` ([#7534](https://github.com/MetaMask/core/pull/7534))

packages/chain-agnostic-permission/package.json

@@ -50,7 +50,6 @@
   "dependencies": {
     "@metamask/api-specs": "^0.14.0",
     "@metamask/controller-utils": "^11.17.0",
-    "@metamask/network-controller": "^27.1.0",
     "@metamask/permission-controller": "^12.2.0",
     "@metamask/rpc-errors": "^7.0.2",
     "@metamask/utils": "^11.9.0",

packages/chain-agnostic-permission/src/caip25Permission.ts

@@ -1,4 +1,3 @@
-import type { NetworkClientId } from '@metamask/network-controller';
 import type {
   PermissionSpecificationBuilder,
   EndowmentGetterParams,
@@ -85,7 +84,7 @@ export const createCaip25Caveat = (value: Caip25CaveatValue) => {
 };
 
 type Caip25EndowmentCaveatSpecificationBuilderOptions = {
-  findNetworkClientIdByChainId: (chainId: Hex) => NetworkClientId;
+  findNetworkClientIdByChainId: (chainId: Hex) => string;
   listAccounts: () => { type: string; address: Hex }[];
   isNonEvmScopeSupported: (scope: CaipChainId) => boolean;
   getNonEvmAccountAddresses: (scope: CaipChainId) => string[];

yarn.lock

@@ -2888,7 +2888,6 @@ __metadata:
     "@metamask/auto-changelog": "npm:^3.4.4"
     "@metamask/controller-utils": "npm:^11.17.0"
     "@metamask/keyring-internal-api": "npm:^9.0.0"
-    "@metamask/network-controller": "npm:^27.1.0"
     "@metamask/permission-controller": "npm:^12.2.0"
     "@metamask/rpc-errors": "npm:^7.0.2"
     "@metamask/utils": "npm:^11.9.0"