chore: test cov

Author: georgeweiler

packages/ramps-controller/src/RampsController.test.ts

@@ -249,19 +249,21 @@ describe('RampsController', () => {
       });
     });
 
-    it('stores error state when request fails with non-Error value', async () => {
+    it('stores fallback error message when error has no message', async () => {
       await withController(async ({ controller }) => {
         const fetcher = async (): Promise<string> => {
-          throw 'String error';
+          const error = new Error();
+          Object.defineProperty(error, 'message', { value: undefined });
+          throw error;
         };
 
         await expect(
-          controller.executeRequest('error-key-string', fetcher),
-        ).rejects.toBe('String error');
+          controller.executeRequest('error-key-no-message', fetcher),
+        ).rejects.toThrow();
 
-        const requestState = controller.state.requests['error-key-string'];
+        const requestState = controller.state.requests['error-key-no-message'];
         expect(requestState?.status).toBe(RequestStatus.ERROR);
-        expect(requestState?.error).toBe('String error');
+        expect(requestState?.error).toBe('Unknown error');
       });
     });
 

packages/ramps-controller/src/RampsController.ts

@@ -264,11 +264,11 @@ export class RampsController extends BaseController<
           throw error;
         }
 
-        const errorMessage =
-          error instanceof Error ? error.message : String(error);
+        const errorMessage = (error as Error)?.message;
+
         this.#updateRequestState(
           cacheKey,
-          createErrorState(errorMessage, lastFetchedAt),
+          createErrorState(errorMessage ?? 'Unknown error', lastFetchedAt),
         );
         throw error;
       } finally {