fix: Fix get1559CompatibilityWithNetworkClientId (#7532)

## Explanation

This function assumed that metadata for a given network client would be
`undefined` if an EIP-1559 compatibility check was needed. This used to
be the case prior to `@metamask/[email protected]`, but as of
that version we began regularly updating metadata without checking for
EIP-1559 compatibility.

The function `get1559CompatibilityWithNetworkClientI` now checks for
whether EIP-1559 compatibility metadata is present, not just whether
metadata is defined at all.

## References

Fixes #7533

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Updates EIP-1559 compatibility check to refetch network metadata when
the `EIPS[1559]` value is missing and adds tests plus changelog entry.
> 
> - **NetworkController**:
> - Update `get1559CompatibilityWithNetworkClientId` to call
`lookupNetwork` when `networksMetadata[networkClientId].EIPS[1559]` is
`undefined`, not only when metadata is absent, then return `EIPS[1559]`.
> - **Tests**
(`packages/network-controller/tests/NetworkController.test.ts`):
> - Adjust existing test description and add test to verify metadata is
updated when EIP-1559 compatibility is missing.
> - **Changelog** (`packages/network-controller/CHANGELOG.md`):
>   - Add Fix entry describing the updated EIP-1559 metadata behavior.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
396375e. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: Gudahtt

packages/network-controller/CHANGELOG.md

@@ -17,6 +17,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Bump `@metamask/eth-json-rpc-middleware` from `^22.0.0` to `^22.0.1` ([#7330](https://github.com/MetaMask/core/pull/7330))
 
+### Fixed
+
+- Ensure `get1559CompatibilityWithNetworkClientId` updates network metadata with EIP-1559 compatibility data missing ([#7532](https://github.com/MetaMask/core/pull/7532))
+
 ## [27.0.0]
 
 ### Added

packages/network-controller/src/NetworkController.ts

@@ -2132,7 +2132,7 @@ export class NetworkController extends BaseController<
     networkClientId: NetworkClientId,
   ): Promise<boolean> {
     let metadata = this.state.networksMetadata[networkClientId];
-    if (metadata === undefined) {
+    if (metadata?.EIPS[1559] === undefined) {
       await this.lookupNetwork(networkClientId);
       metadata = this.state.networksMetadata[networkClientId];
     }

packages/network-controller/tests/NetworkController.test.ts

@@ -3590,7 +3590,7 @@ describe('NetworkController', () => {
           },
         );
       });
-      it('calls provider of the networkClientId and returns true', async () => {
+      it('updates network metadata if undefined', async () => {
         await withController(
           {
             infuraProjectId: 'some-infura-project-id',
@@ -3624,6 +3624,48 @@ describe('NetworkController', () => {
           },
         );
       });
+      it('updates network metadata if EIP-1559 compatibility is missing', async () => {
+        await withController(
+          {
+            infuraProjectId: 'some-infura-project-id',
+            state: {
+              networksMetadata: {
+                'linea-mainnet': {
+                  EIPS: {},
+                  status: NetworkStatus.Unknown,
+                },
+              },
+            },
+          },
+          async ({ controller }) => {
+            await setFakeProvider(controller, {
+              stubs: [
+                {
+                  request: {
+                    method: 'eth_getBlockByNumber',
+                    params: ['latest', false],
+                  },
+                  response: {
+                    result: POST_1559_BLOCK,
+                  },
+                },
+                {
+                  request: {
+                    method: 'eth_getBlockByNumber',
+                    params: ['latest', false],
+                  },
+                  response: {
+                    result: POST_1559_BLOCK,
+                  },
+                },
+              ],
+            });
+            const isEIP1559Compatible =
+              await controller.getEIP1559Compatibility('linea-mainnet');
+            expect(isEIP1559Compatible).toBe(true);
+          },
+        );
+      });
     });
 
     describe('if a provider has been set but networksMetadata[selectedNetworkClientId].EIPS in state already has a "1559" property', () => {