feat: optimized earn controller refresh strategy to update specific data based on type of event received

Author: Matt561

packages/earn-controller/src/EarnController.test.ts

@@ -507,9 +507,19 @@ describe('EarnController', () => {
       address: '0x1234',
     });
 
-    it('updates staking data when network changes', () => {
+    it('updates vault data when network changes', () => {
       const { controller, messenger } = setupController();
-      jest.spyOn(controller, 'refreshPooledStakingData').mockResolvedValue();
+
+      jest
+        .spyOn(controller, 'refreshPooledStakingVaultMetadata')
+        .mockResolvedValue();
+      jest
+        .spyOn(controller, 'refreshPooledStakingVaultDailyApys')
+        .mockResolvedValue();
+      jest
+        .spyOn(controller, 'refreshPooledStakingVaultApyAverages')
+        .mockResolvedValue();
+
       messenger.publish(
         'NetworkController:stateChange',
         {
@@ -519,17 +529,28 @@ describe('EarnController', () => {
         [],
       );
 
-      expect(controller.refreshPooledStakingData).toHaveBeenCalled();
+      expect(
+        controller.refreshPooledStakingVaultMetadata,
+      ).toHaveBeenCalledTimes(1);
+      expect(
+        controller.refreshPooledStakingVaultDailyApys,
+      ).toHaveBeenCalledTimes(1);
+      expect(
+        controller.refreshPooledStakingVaultApyAverages,
+      ).toHaveBeenCalledTimes(1);
     });
 
-    it('updates staking data when selected account changes', () => {
+    it('updates staking eligibility when selected account changes', () => {
       const { controller, messenger } = setupController();
-      jest.spyOn(controller, 'refreshPooledStakingData').mockResolvedValue();
+
+      jest.spyOn(controller, 'refreshStakingEligibility').mockResolvedValue();
+
       messenger.publish(
         'AccountsController:selectedAccountChange',
         firstAccount,
       );
-      expect(controller.refreshPooledStakingData).toHaveBeenCalled();
+
+      expect(controller.refreshStakingEligibility).toHaveBeenCalledTimes(1);
     });
   });
 });

packages/earn-controller/src/EarnController.ts

@@ -235,7 +235,9 @@ export class EarnController extends BaseController<
           this.#selectedNetworkClientId
         ) {
           this.#initializeSDK(networkControllerState.selectedNetworkClientId);
-          this.refreshPooledStakingData().catch(console.error);
+          this.refreshPooledStakingVaultMetadata().catch(console.error);
+          this.refreshPooledStakingVaultDailyApys().catch(console.error);
+          this.refreshPooledStakingVaultApyAverages().catch(console.error);
         }
         this.#selectedNetworkClientId =
           networkControllerState.selectedNetworkClientId;
@@ -246,7 +248,7 @@ export class EarnController extends BaseController<
     this.messagingSystem.subscribe(
       'AccountsController:selectedAccountChange',
       () => {
-        this.refreshPooledStakingData().catch(console.error);
+        this.refreshStakingEligibility().catch(console.error);
       },
     );
   }
@@ -360,13 +362,13 @@ export class EarnController extends BaseController<
   }
 
   /**
-   * Refreshes vault metadata for the current chain.
+   * Refreshes pooled staking vault metadata for the current chain.
    * Updates the vault metadata in the controller state including APY, capacity,
    * fee percentage, total assets, and vault address.
    *
    * @returns A promise that resolves when the vault metadata has been updated
    */
-  async refreshVaultMetadata(): Promise<void> {
+  async refreshPooledStakingVaultMetadata(): Promise<void> {
     const chainId = this.#getCurrentChainId();
     const vaultMetadata = await this.#stakingApiService.getVaultData(chainId);
 
@@ -434,7 +436,7 @@ export class EarnController extends BaseController<
       this.refreshStakingEligibility().catch((error) => {
         errors.push(error);
       }),
-      this.refreshVaultMetadata().catch((error) => {
+      this.refreshPooledStakingVaultMetadata().catch((error) => {
         errors.push(error);
       }),
       this.refreshPooledStakingVaultDailyApys().catch((error) => {