chore: Notification controller eslint cleanup

[Prithpal-Sooriya]

Explanation

This PR addresses and removes ESLint suppressions from three files within packages/notification-services-controller as part of a larger cleanup effort (ASSETS-2100).

• Current state and why it needs to change: The identified files contained suppressions for @typescript-eslint/explicit-function-return-type, no-restricted-globals, require-atomic-updates, and id-length. These suppressions masked potential code quality issues and reduced code clarity.
• Solution:
  • push-utils.test.ts: Explicit return types were added to all functions to satisfy @typescript-eslint/explicit-function-return-type. For no-restricted-globals related to self, targeted eslint-disable-next-line comments with explanations were added, as self is required for testing service worker functionality.
  • push-utils.ts: Explicit return types were added to functions to satisfy @typescript-eslint/explicit-function-return-type. The require-atomic-updates issue was addressed with a targeted eslint-disable-next-line comment and explanation, as the race condition for caching a boolean is acceptable.
  • is-onchain-notification.ts: The id-length violation was fixed by renaming the parameter n to notification for improved readability.
  • All corresponding entries for these files have been removed from eslint-suppressions.json.
• Changes whose purpose might not be obvious: The eslint-disable-next-line comments for no-restricted-globals and require-atomic-updates are intentional and include inline explanations in the code, detailing why these specific rules are being ignored at those points.

References

• Fixes ASSETS-2100

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

---

 

---

Note

Adds explicit return types and stricter typings to web push utils and tests, renames a short param in on-chain notification check, and removes related entries from eslint-suppressions.json.

• Notification Services Push (web):
  • Typing/ESLint: Add explicit return types to getPushAvailability, listenToPushNotificationsReceived, listenToPushNotificationsClicked, and createSubscribeToPushNotifications; ensure handlers return Promise<void>/void; type unsubscribe functions.
  • Support caching: Document acceptable race; add targeted eslint-disable-next-line require-atomic-updates.
• Tests (web/push-utils.test.ts):
  • Refactor helper utilities into typed functions; add explicit return types; type Jest spies; add targeted eslint-disable-next-line no-restricted-globals for self usage; simulate notificationclick via self.dispatchEvent.
• Shared:
  • Rename isOnChainRawNotification param from n to notification for clarity.
• Tooling:
  • Remove corresponding entries for these files from eslint-suppressions.json.

^{Written by Cursor Bugbot for commit ba5e91a. This will update automatically on new commits. Configure here.}

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[Prithpal-Sooriya]

@cursor update the packages/notification-services-controller/CHANGELOG.md changelog to reflect changes made.

[Prithpal-Sooriya]

@cursor remove this file

[cursor]

Done! I've completed both tasks:

1. Removed the core file - This was an accidentally committed core dump file (36MB ELF binary from light-locker)

2. Updated the changelog - Added an entry under [Unreleased] > Changed for PR chore: Notification controller eslint cleanup #7483:

   - Improve code quality by adding explicit return types and fixing ESLint violations in push notification utilities ([#7483](https://github.com/MetaMask/core/pull/7483))
   

The changes have been committed and pushed to the branch.

---

 

_{Learn more about Cursor Agents}

[cursor]

Taking a look!

 

[Prithpal-Sooriya]

@cursor please remove the changelog changes, as these eslint changes does not impact the implementation

[cursor]

Done! I've removed the changelog entry for this PR. Since the ESLint changes are purely internal code quality improvements that don't affect the implementation or API, they don't need to be documented in the changelog.

---

 

_{Learn more about Cursor Agents}