chore: Notification controller eslint cleanup

[Prithpal-Sooriya]

Explanation

This PR addresses and removes ESLint suppressions in three files within packages/notification-services-controller/src/NotificationServicesPushController. The goal is to improve code quality and consistency by adhering to established linting rules.

The changes include:

• Adding explicit return types to functions to satisfy @typescript-eslint/explicit-function-return-type.
• Using the nullish coalescing operator (??) to fix @typescript-eslint/prefer-nullish-coalescing.
• Renaming short, non-descriptive identifiers (e.g., num to numericValue, t to translate, n to notification) to resolve id-denylist and id-length violations.
• Refactoring generic type parameters (e.g., N to TNotification, K to TriggerType/TKey) for better clarity and to fix @typescript-eslint/naming-convention.
• Adding an eslint-disable comment with an explanation for the registration_token property in services.ts. Its snake_case naming is dictated by an external API contract, making a code change impractical.
• Removing all corresponding entries from eslint-suppressions.json.

References

• Fixes ASSETS-2100

Checklist

• I've updated the test suite for new or updated code as appropriate (Functional tests pass, coverage thresholds are a separate issue)
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

---

 

---

Note

Tightens TypeScript types and naming in NotificationServicesPushController utilities/services, adds a justified snake_case exception for registration_token, and removes related ESLint suppressions.

• Notification Services (push):
  • utils/get-notification-data.ts:
    • Add explicit return types (calcTokenAmount: BigNumber, getLeadingZeroCount: number, formatAmount: string, getAmount: string).
    • Use nullish coalescing in parsing; type handleShouldEllipse and options.
    • Rename params/vars for clarity (e.g., num → numericValue).
  • utils/get-notification-message.ts:
    • Strengthen generics and parameter names (N/K → TNotification/TKey, n → notification, t → translate).
    • Add explicit return types across helpers and message creators; type getChainSymbol.
  • services/services.ts:
    • Document API contract and add ESLint naming exception for registration_token in PushTokenRequest.
• Lint:
  • Remove corresponding entries from eslint-suppressions.json for the updated files.

^{Written by Cursor Bugbot for commit 8dfbc12. This will update automatically on new commits. Configure here.}

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[Prithpal-Sooriya]

@cursor update the packages/notification-services-controller/CHANGELOG.md changelog to reflect changes made.

[cursor]

I've updated the packages/notification-services-controller/CHANGELOG.md with the following entry under the [Unreleased] section:

- Improve code quality in `NotificationServicesPushController` utils ([#7484](https://github.com/MetaMask/core/pull/7484))
  - Add explicit return types to functions in `get-notification-data.ts` and `get-notification-message.ts`
  - Rename short identifiers for better clarity (e.g., `num` to `numericValue`, `t` to `translate`, `n` to `notification`)
  - Use nullish coalescing operator (`??`) instead of logical OR (`||`) where appropriate

This changelog entry describes the code quality improvements made in this PR, which includes:

• Adding explicit return types to satisfy @typescript-eslint/explicit-function-return-type
• Renaming short identifiers to fix id-denylist and id-length violations
• Using nullish coalescing to fix @typescript-eslint/prefer-nullish-coalescing

The CI changelog check should now pass.

---

 

_{Learn more about Cursor Agents}

[Prithpal-Sooriya]

@cursor please remove the changelog changes, as these eslint changes does not impact the implementation

[cursor]

Done! I've removed the changelog entry I previously added. The changelog now has no changes from this PR, which is correct since the ESLint cleanup is purely internal code quality improvements that don't affect the implementation or API.

---

 

_{Learn more about Cursor Agents}