chore: Notification services eslint cleanup

[Prithpal-Sooriya]

Explanation

This PR addresses and resolves several ESLint rule violations across three files within packages/notification-services-controller, allowing for the removal of their corresponding suppressions from eslint-suppressions.json.

• Current state and why change?
  ESLint suppressions were present in eslint-suppressions.json for rules such as @typescript-eslint/explicit-function-return-type, @typescript-eslint/naming-convention, @typescript-eslint/prefer-nullish-coalescing, and id-length. These suppressions indicated areas where the code did not conform to established linting standards. The goal is to improve code quality and maintainability by fixing these violations and removing the suppressions.

• What is the solution your changes offer and how does it work?

  • feature-announcements.ts:
    • Explicit return types were added to getFeatureAnnouncementUrl and findIncludedItem.
    • prefer-nullish-coalescing was applied by replacing || with ??.
    • id-length violations were resolved by renaming short, non-descriptive variables (r, i, n) to more explicit names (response, entry/asset, item/rawNotification).
    • @typescript-eslint/naming-convention suppressions were added with explanations for Entry and Asset properties within the ContentfulResult type, as their casing is dictated by the external Contentful API response structure.
  • notification-config-cache.ts:
    • The private field #TTL was renamed to #ttl to conform to camelCase naming conventions for private class members.
  • perp-notifications.test.ts:
    • An explicit return type was added to the arrangeMocks test helper function.
  • All corresponding entries for these files were removed from eslint-suppressions.json.

• Are there any changes whose purpose might not be obvious?
  The eslint-disable-next-line @typescript-eslint/naming-convention comments in feature-announcements.ts for Entry and Asset properties are intentional. These properties directly reflect the structure of responses from the Contentful API, and renaming them would break compatibility or require complex mapping.

References

• Fixes ASSETS-2100

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

---

 

---

Note

Fixes ESLint violations in feature announcements, notification config cache, and perps test, and removes their suppressions.

• Notification Services Controller:
  • services/feature-announcements.ts:
    • Add explicit return types to getFeatureAnnouncementUrl and findIncludedItem.
    • Replace || with ?? and improve variable names (response, entry/asset, item, rawNotification).
    • Add targeted @typescript-eslint/naming-convention disables for includes.Entry and includes.Asset to match Contentful schema.
    • Minor refactors: safer optional access, typed mappings, and consistent createdAt source.
  • services/notification-config-cache.ts:
    • Rename private field #TTL to #ttl and update references.
  • services/perp-notifications.test.ts:
    • Add explicit return type to arrangeMocks helper.
• ESLint suppressions:
  • Remove entries for feature-announcements.ts, notification-config-cache.ts, and perp-notifications.test.ts from eslint-suppressions.json.

^{Written by Cursor Bugbot for commit e6f1d91. This will update automatically on new commits. Configure here.}

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[Prithpal-Sooriya]

@cursor update the packages/notification-services-controller/CHANGELOG.md changelog to reflect changes made.

[Prithpal-Sooriya]

@cursor remove this file

[cursor]

Done! I've completed both tasks:

1. Removed the core file - This was an accidentally committed core dump file (36MB) that was removed from the repository.

2. Updated the changelog - Added an entry under the [Unreleased] section in packages/notification-services-controller/CHANGELOG.md documenting the ESLint cleanup changes:

   • Added explicit return types to functions
   • Applied nullish coalescing operator (??) where appropriate
   • Renamed short variable names for better readability
   • Renamed private field #TTL to #ttl to follow camelCase convention

The amended commit has been force-pushed to the branch.

---

 

_{Learn more about Cursor Agents}

[cursor]

Taking a look!

 

[cursor]

Bug: Inconsistent empty string handling between domain and token

The change from || to ?? on line 58 creates an inconsistency with the truthiness check on line 53. If previewToken is an empty string, line 53's previewToken ? PREVIEW_DOMAIN : DEFAULT_DOMAIN evaluates to DEFAULT_DOMAIN (treating empty string as falsy), but line 58's previewToken ?? env.accessToken returns the empty string instead of falling back to env.accessToken. This could result in API calls to the production domain with an empty access token, causing authentication failures.

Additional Locations (1)

• packages/notification-services-controller/src/NotificationServicesController/services/feature-announcements.ts#L52-L53

 

[Prithpal-Sooriya]

@cursor please remove the changelog changes, as these eslint changes does not impact the implementation

[cursor]

Done! I've removed the changelog entry for the ESLint cleanup changes. The changelog now no longer includes the entry about refactoring internal code, since these changes don't impact the implementation or external API.

---

 

_{Learn more about Cursor Agents}

[Prithpal-Sooriya]

@cursor fix merge conflicts & cleanup eslint-suppressions.json

[cursor]

Done! I've fixed the merge conflicts and cleaned up eslint-suppressions.json. Here's what was done:

1. Rebased onto main - The branch was rebased onto the latest origin/main to incorporate all recent changes.

2. Resolved merge conflict in eslint-suppressions.json - The conflict occurred because main had updated entries around the notification-services-controller section. I resolved it by:

   • Keeping the new entries from main (like process-notifications.ts, api-notifications.ts, feature-announcements.test.ts, etc.)
   • Removing the entries for the 3 files that were cleaned up (feature-announcements.ts, notification-config-cache.ts, perp-notifications.test.ts)

3. Verified ESLint passes - Confirmed that ESLint runs without errors on all 3 cleaned up files.

4. Force-pushed the rebased branch - The updated branch has been pushed to the remote.

---

 

_{Learn more about Cursor Agents}