Skip to content

Conversation

@asalsys
Copy link
Contributor

@asalsys asalsys commented Dec 15, 2025

Explanation

Current State and Problem

A duplicate type definition was present in the codebase, causing potential confusion and maintenance issues. The same type was being exported from multiple locations, which could lead to inconsistencies and makes the codebase harder to maintain.

Solution

Removed the duplicate type definition, keeping a single source of truth for the type. This simplifies the codebase and ensures type consistency across the package.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Removes the duplicate RemoteFeatureFlagControllerState type from remote-feature-flag-controller-types.ts.

  • Types:
    • Remove duplicate RemoteFeatureFlagControllerState from packages/remote-feature-flag-controller/src/remote-feature-flag-controller-types.ts to avoid redundancy.

Written by Cursor Bugbot for commit 3521c2c. This will update automatically on new commits. Configure here.

@asalsys asalsys requested review from a team as code owners December 15, 2025 16:01
@asalsys asalsys self-assigned this Dec 15, 2025
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asalsys asalsys added this pull request to the merge queue Dec 15, 2025
Merged via the queue into main with commit 4a396db Dec 15, 2025
285 checks passed
@asalsys asalsys deleted the fix/remove-duplicate-type branch December 15, 2025 16:39
@asalsys asalsys mentioned this pull request Dec 15, 2025
4 tasks
@asalsys
Copy link
Contributor Author

asalsys commented Dec 15, 2025

@metamaskbot publish-previews

@asalsys asalsys mentioned this pull request Dec 16, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants