Skip to content

Conversation

@georgeweiler
Copy link
Contributor

@georgeweiler georgeweiler commented Dec 17, 2025

Explanation

Some small ramps-controller and ramps-service updates are needed for compatibility with mobile app's expectations in the initial controller integration PR: MetaMask/metamask-mobile#24044.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Bumps monorepo to 730.0.0 and releases @metamask/ramps-controller 1.0.1 with onRamp→ramps renames, dev scripts, and a geolocation fix.

  • Releases:
    • Bump root package.json to 730.0.0.
    • Publish @metamask/[email protected]:
      • Rename onRamp* to ramps* across controller/service and action types.
      • Add dev scripts for auto-building/copying to mobile.
      • Fix RampsService#getGeolocation response parsing.
      • Update changelog links and entries.

Written by Cursor Bugbot for commit 2082004. This will update automatically on new commits. Configure here.

@georgeweiler georgeweiler requested review from a team as code owners December 17, 2025 15:45
@wachunei
Copy link
Member

I approved although I'm not familiar with the correct output of the changelog action, I'll leave it up to Core team to review.


## [1.0.1]

### Uncategorized
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog. Any entries in this section must be categorized or removed manually.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was no-changelog used on #7502 🤔 There were clearly change entries added. It looks like the CI check was failing because the entries were not correctly formatted (they should all end with the PR link). One of them even references a different PR!

Many of them seem to be related to dev changes as well, which should not be listed here.

Also these appear to be breaking changes, but they're released as a patch 🤔

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog needs updating

@Gudahtt
Copy link
Member

Gudahtt commented Dec 17, 2025

Closing to revisit later after consulting with ramps team

@Gudahtt Gudahtt closed this Dec 17, 2025
@Gudahtt Gudahtt deleted the release/730.0.0 branch December 17, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants