-
-
Notifications
You must be signed in to change notification settings - Fork 261
Update Release 730.0.0 #7527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Release 730.0.0 #7527
Conversation
|
I approved although I'm not familiar with the correct output of the changelog action, I'll leave it up to Core team to review. |
|
|
||
| ## [1.0.1] | ||
|
|
||
| ### Uncategorized |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the changelog. Any entries in this section must be categorized or removed manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instructions here: https://github.com/MetaMask/core/blob/main/docs/contributing.md#option-a-interactive-mode-recommended
See the changelog update step in particular
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was no-changelog used on #7502 🤔 There were clearly change entries added. It looks like the CI check was failing because the entries were not correctly formatted (they should all end with the PR link). One of them even references a different PR!
Many of them seem to be related to dev changes as well, which should not be listed here.
Also these appear to be breaking changes, but they're released as a patch 🤔
Gudahtt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog needs updating
|
Closing to revisit later after consulting with ramps team |
Explanation
Some small ramps-controller and ramps-service updates are needed for compatibility with mobile app's expectations in the initial controller integration PR: MetaMask/metamask-mobile#24044.
References
Checklist
Note
Bumps monorepo to 730.0.0 and releases @metamask/ramps-controller 1.0.1 with onRamp→ramps renames, dev scripts, and a geolocation fix.
package.jsonto730.0.0.@metamask/[email protected]:onRamp*toramps*across controller/service and action types.RampsService#getGeolocationresponse parsing.Written by Cursor Bugbot for commit 2082004. This will update automatically on new commits. Configure here.