Skip to content

Conversation

@MarioAslau
Copy link
Contributor

@MarioAslau MarioAslau commented Dec 19, 2025

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Publishes remote-feature-flag-controller 4.0.0 with breaking threshold flag changes and bumps Bridge/Transaction/Transaction Pay controllers to use it; monorepo version to 734.0.0.

  • Remote Feature Flags (packages/remote-feature-flag-controller)
    • Release 4.0.0 with breaking changes to threshold-based flag processing:
      • Persist threshold values; skip crypto for non-threshold arrays; batch cache updates; auto‑remove stale cache entries
      • Update exported types (thresholdCache), drop @noble/hashes, bump @metamask/utils to ^11.9.0
  • Consumers bumped to @metamask/remote-feature-flag-controller@^4.0.0
    • packages/bridge-controller/package.json
    • packages/transaction-controller/package.json
    • packages/transaction-pay-controller/package.json
  • Changelogs updated
    • Reflect RFFC 4.0.0 and dependency bumps across Bridge/Transaction/Transaction Pay
  • Repo metadata
    • Bump root package.json version to 734.0.0

Written by Cursor Bugbot for commit 61fca94. This will update automatically on new commits. Configure here.

@MarioAslau MarioAslau self-assigned this Dec 19, 2025
@MarioAslau MarioAslau requested review from a team as code owners December 19, 2025 21:59
@MarioAslau
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MarioAslau MarioAslau added this pull request to the merge queue Dec 19, 2025
Merged via the queue into main with commit 5c39f7c Dec 19, 2025
286 checks passed
@MarioAslau MarioAslau deleted the release/734.0.0 branch December 19, 2025 22:22
github-merge-queue bot pushed a commit to MetaMask/metamask-mobile that referenced this pull request Dec 20, 2025
…4211)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Bumping version of remote-feature-flag-controller to support independent
A/B tests introduced in:
- PR: MetaMask/core#7511
- Core release: MetaMask/core#7546

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Bumps `@metamask/remote-feature-flag-controller` to 4.0.0 and
refreshes lockfile, updating related `@metamask/utils` and
`@metamask/controller-utils` versions.
> 
> - **Dependencies**:
> - Upgrade `@metamask/remote-feature-flag-controller` from `^3.1.0` to
`^4.0.0` in `package.json`.
> - Update `yarn.lock` resolutions accordingly, including
`@metamask/utils` to `11.9.0` and `@metamask/controller-utils` to
`11.17.0`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
8a5dc27. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants