Apply PR feedback

Author: cryptodev-2s

src/release-specification.ts

@@ -184,12 +184,8 @@ export function findMissingUnreleasedDependents(
     (possibleDependentName) => {
       const possibleDependent =
         project.workspacePackages[possibleDependentName];
-      const { dependencies, peerDependencies } =
-        possibleDependent.validatedManifest;
-      return (
-        hasProperty(dependencies, packageName) ||
-        hasProperty(peerDependencies, packageName)
-      );
+      const { peerDependencies } = possibleDependent.validatedManifest;
+      return hasProperty(peerDependencies, packageName);
     },
   );
 

src/ui/App.tsx

@@ -294,7 +294,12 @@ function App() {
           <h2 className="text-2xl font-bold mb-4">
             Release Branch Successfully Created!
           </h2>
-          <p className="mb-6">You can now close this window.</p>
+          <p className="mb-6">
+            You are now on a new branch that represents the new release. You are
+            free to close this window and make whatever other changes you would
+            like to the branch. When you're ready, push it up and make a new
+            pull request.
+          </p>
         </div>
       </div>
     );
@@ -304,6 +309,27 @@ function App() {
     <div className="container mx-auto px-4 py-8">
       <h1 className="text-3xl font-bold mb-6">Create New Core Release</h1>
 
+      <div className="mb-6 p-4 bg-gray-50 rounded border border-gray-200">
+        <h2 className="text-xl font-semibold mb-2">How to use this tool</h2>
+        <p className="mb-2">
+          Listed below are the packages in this monorepo which have unreleased
+          changes. You do not need to release all packages; you may release a
+          subset. To add a new package, you first need to decide how to bump its
+          version. Look over the changelog or commit history to understand the
+          nature of the changes that have been made to the package. Then you can
+          select a version from the dropdown next to the package. If there are
+          breaking changes, select "Major"; if there are new features, select
+          "Minor"; and if there are only non-functional backward-compatible
+          changes, select "Patch".
+        </p>
+        <p>
+          Some packages are linked via dependencies, and because of this you may
+          be asked to include other packages in the release you were not
+          anticipating. We've done our best to explain why, but feel free to
+          reach out to the Wallet Framework team if you have any questions.
+        </p>
+      </div>
+
       <div className="mb-4 p-4 bg-gray-100 rounded">
         {showCheckboxes && selectedPackages.size > 0 ? (
           <>

src/ui/DependencyErrorSection.tsx

@@ -2,12 +2,14 @@ type DependencyErrorSectionProps = {
   title: string;
   items: string[];
   setSelections: React.Dispatch<React.SetStateAction<Record<string, string>>>;
+  description: string;
 };
 
 export function DependencyErrorSection({
   title,
   items,
   setSelections,
+  description,
 }: DependencyErrorSectionProps) {
   return (
     <div className="text-red-800">
@@ -31,10 +33,7 @@ export function DependencyErrorSection({
           Skip All
         </button>
       </div>
-      <p className="text-sm mb-2">
-        Please either include these packages in your release selections, or
-        choose "Skip" if you are absolutely sure they are safe to omit:
-      </p>
+      <p className="text-sm mb-2">{description}</p>
       <ul className="list-disc ml-4">
         {items.map((dep) => (
           <li key={dep} className="flex justify-between items-center mb-2">

src/ui/ErrorMessage.tsx

@@ -8,9 +8,7 @@ export function ErrorMessage({ errors }: ErrorMessageProps) {
   return (
     <div className="mt-4 p-4 bg-red-50 border border-red-200 rounded-lg">
       <h3 className="text-red-700 font-semibold mb-2">
-        {
-          'Your release spec could not be processed due to the following issues:'
-        }
+        {'Your release could not be created due to the following issues:'}
       </h3>
       <ul className="list-disc pl-5">
         {errors.map((error, index) => (

src/ui/PackageItem.tsx

@@ -121,6 +121,9 @@ export function PackageItem({
                 title="Missing Dependencies"
                 items={packageDependencyErrors[pkg.name].missingDependencies}
                 setSelections={setSelections}
+                description={`The following packages are dependencies or peer dependencies of ${pkg.name}. Because they may have introduced new changes that ${pkg.name} is now using, you need to verify whether to include them in the release.
+
+To do this, look at the change history for each package and compare it with the change history for ${pkg.name}. If ${pkg.name} uses any new changes from a package, then you need to include it by bumping its version. If you have confirmed that the changes to a package do not affect ${pkg.name}, you may omit it from the release by choosing "Skip" instead.`}
               />
             )}
             {packageDependencyErrors[pkg.name].missingDependentNames.length >
@@ -132,6 +135,7 @@ export function PackageItem({
                     packageDependencyErrors[pkg.name].missingDependentNames
                   }
                   setSelections={setSelections}
+                  description={`Because ${pkg.name} is being released with a new major version, to prevent peer dependency warnings in consuming projects, all of the following packages which list as a peer dependency need to be included in the release. Please choose new versions for these packages. If for some reason you feel it is safe to omit a package you may choose "Skip".`}
                 />
               </div>
             )}

src/ui/favicon.svg

@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Create New Core Release</title>
-    <link rel="icon" href="./metamask-fox.svg" />
+    <link rel="icon" href="./favicon.svg" />
   </head>
   <body>
     <div id="root"></div>

src/ui/index.html

@@ -1,5 +1 @@
 @import 'tailwindcss';
-
-@tailwind base;
-@tailwind components;
-@tailwind utilities;