-
-
Notifications
You must be signed in to change notification settings - Fork 114
Open
Description
Some improvements can be made to the serializing and deserializing of data:
this.hdkcan/should be serialised and deserialised- Only the
publicKeyandchainCodeneeds to serialised/deserialised - Setting
this.hdKeycan be refactored via asetHdKeymethod
- Only the
this.pageandthis.unlockedAccountshould be included in data serializationthis.hdPathcan be changed via deserialization without triggering thethis.setHdPathmethodimplementFullBIP44is incorrectly serialised- Should be
implementFullBIP44: this.implementFullBIP44instead ofimplemntFullBIP44: false
- Should be
- Some "resetting" of data can be refactored (i.e., see
forgetDevice,setHdPathand theconstructor) - Some refactoring for filtering
this.accountscan be done this.bridgeUrlcan be changed via deserialisation without updating theiframeURL- This should either be only settable via
init, or should triggeriframedeletion and recreation (less desireable)
- This should either be only settable via
Metadata
Metadata
Assignees
Labels
No labels