Skip to content

devDeps: upgrade test & lint suite #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
legobeat wants to merge 9 commits into
base: main
Choose a base branch
from
Open

devDeps: upgrade test & lint suite #70

legobeat wants to merge 9 commits into from

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented May 14, 2023

This upgrades test and lint packages, bringing in configuration in direction of https://github.com/MetaMask/metamask-module-template/.

Migrating to jest and fixing jsdoc comments left as separate changes. Otherwise updated linting rules have been applied.

@socket-security
Copy link

socket-security bot commented May 14, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@legobeat

This comment was marked as resolved.

Sign in to view
@legobeat
Copy link
Contributor Author

legobeat commented May 15, 2023 •
edited
Loading 

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

Let's see if they pick up typicode/please-upgrade-node#36

@legobeat

This comment was marked as resolved.

Sign in to view
@legobeat
Copy link
Contributor Author

legobeat commented May 15, 2023 •
edited
Loading 

@SocketSecurity ignore @vue/[email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore @ungap/[email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore @types/[email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

Many of these look to be eternal until they're removed from entrypoint packages (cf https://github.com/inspect-js/is-typed-array/pull/54#issuecomment-1547171507)

I'm as much for backwards-compat as the next person but with a network of interconnected micropackages all maintained with this approach underpinning the linting, I have a feeling this can get uncomfortable over time.

@legobeat legobeat marked this pull request as ready for review May 15, 2023 04:42
@legobeat legobeat requested a review from a team as a code owner May 15, 2023 04:42
@legobeat legobeat added the dependencies Pull requests that update a dependency file label May 15, 2023
@legobeat
Copy link
Contributor Author

legobeat commented May 15, 2023

Blocked by MetaMask/eslint-config#290

@legobeat legobeat marked this pull request as draft May 15, 2023 09:25
@legobeat

This comment was marked as resolved.

Sign in to view
@socket-security
Copy link

socket-security bot commented Nov 18, 2023 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] Transitive: environment +10 192 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 1.89 MB nicolo-ribaudo
npm/@babel/[email protected] environment +3 2.49 MB nicolo-ribaudo
npm/@eslint-community/[email protected] None 0 431 kB eslint-community-bot
npm/@jridgewell/[email protected] None 0 45.9 kB jridgewell
npm/@jridgewell/[email protected] None +1 219 kB jridgewell
npm/@metamask/[email protected] None 0 8.58 kB metamaskbot
npm/@metamask/[email protected] None 0 94.8 kB metamaskbot
npm/@metamask/[email protected] None 0 18.5 kB metamaskbot
npm/@metamask/[email protected] None 0 119 kB metamaskbot
npm/@nodelib/[email protected] filesystem 0 11.8 kB mrmlnc
npm/@nodelib/[email protected] Transitive: filesystem +5 107 kB mrmlnc
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +23 6.39 MB jameshenry
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +13 2.01 MB jameshenry
npm/[email protected] None +4 81.5 kB ljharb
npm/[email protected] None 0 11.7 kB sindresorhus
npm/[email protected] environment 0 42.4 kB qix
npm/[email protected] None +2 47.5 kB ljharb
npm/[email protected] None +2 50 kB ljharb
npm/[email protected] filesystem, unsafe Transitive: environment, eval +61 9.49 MB rumpl
npm/[email protected] None 0 19.9 kB lydell
npm/[email protected] filesystem, unsafe Transitive: environment, network +63 5.68 MB ljharb
npm/[email protected] None +8 2.53 MB gajus
npm/[email protected] None +3 1.24 MB lo1tuma
npm/[email protected] filesystem +10 1.57 MB weiran.zsd
npm/[email protected] None +2 120 kB jounqin
npm/[email protected] None 0 67.1 kB eslint-community-bot
npm/[email protected] None 0 32.3 kB eslintbot
npm/[email protected] environment, filesystem Transitive: eval, shell, unsafe +56 8.18 MB eslintbot
npm/[email protected] None +2 629 kB eslintbot
npm/[email protected] None 0 1 MB michaelficarra
npm/[email protected] Transitive: environment, filesystem +2 20.6 kB doowb
npm/[email protected] Transitive: filesystem +5 43.7 kB sindresorhus
npm/[email protected] eval +3 89.4 kB ljharb
npm/[email protected] filesystem Transitive: environment +9 109 kB isaacs
npm/[email protected] None 0 20.6 kB ljharb
npm/[email protected] None 0 51.2 kB kael
npm/[email protected] None 0 11.9 kB ljharb
npm/[email protected] None 0 28.9 kB ljharb
npm/[email protected] None +2 72.5 kB ljharb
npm/[email protected] None +1 19.8 kB phated
npm/[email protected] None +1 30 kB ljharb
npm/[email protected] None 0 17.6 kB ljharb
npm/[email protected] None 0 54.5 kB ljharb
npm/[email protected] environment, eval, filesystem Transitive: shell +33 5.55 MB juergba
npm/[email protected] None 0 97.2 kB ljharb
npm/[email protected] None 0 90 kB mrmlnc
npm/[email protected] environment, filesystem, unsafe 0 11.2 MB prettier-bot
npm/[email protected] filesystem 0 20.5 kB paulmillr
npm/[email protected] Transitive: environment, filesystem +8 73.1 kB phated
npm/[email protected] environment, filesystem +2 159 kB ljharb
npm/[email protected] None +2 58.4 kB sindresorhus
npm/[email protected] None +1 9.64 kB sindresorhus
npm/[email protected] None 0 68.8 MB typescript-bot
npm/[email protected] None +4 80.4 kB ljharb
npm/[email protected] environment, filesystem 0 120 kB oss-bot
npm/[email protected] environment, filesystem +6 379 kB oss-bot

🚮 Removed packages: npm/@metamask/[email protected], npm/@nodelib/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@legobeat
Copy link
Contributor Author

legobeat commented Nov 18, 2023

  • Rebased on main
  • Bumped depcheck to latest
  • Bumped @metamask/eslint* to latest and align peerDeps

@legobeat legobeat marked this pull request as ready for review November 18, 2023 11:03
@legobeat

This comment was marked as resolved.

Sign in to view
@legobeat

This comment was marked as resolved.

Sign in to view
@legobeat legobeat mentioned this pull request Nov 18, 2023
Draft
@legobeat legobeat requested a review from mcmire April 22, 2024 09:42
@legobeat legobeat requested a review from a team April 22, 2024 09:42
@legobeat
Copy link
Contributor Author

legobeat commented Apr 22, 2024 

@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]

new author ok

mcmire
mcmire reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay on reviewing this. Obviously we need more work to bring this project up to date with the module template but this is a good start. Good call to delay the JSDoc rules, I agree that this can be its own PR — perhaps we want to remove the dummy comments for now? Otherwise this PR looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcmire mcmire mcmire left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@legobeat @mcmire