Skip to content

Commit 1cb728a

Browse files
authored
Ensure descriptions appear correctly. (#2096)
Signed-off-by: bgravenorst <[email protected]>
1 parent 640ce32 commit 1cb728a

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

src/components/ParserOpenRPC/DetailsBox/RenderParams.tsx

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,18 @@ const getRefSchemaFromComponents = (initRef, components) => {
1212
const renderSchema = (schemaItem, schemas, name) => {
1313
if (!schemaItem) return <div>Invalid schema</div>
1414

15-
const resolveRef = ref => {
15+
const resolveRef = (ref, originalItem) => {
1616
const newSchema = getRefSchemaFromComponents(ref, schemas)
17-
return renderSchema(newSchema, schemas, name)
17+
// Preserve the original parameter's description when resolving references
18+
const resolvedSchema = {
19+
...newSchema,
20+
description: originalItem?.description || newSchema.description || newSchema.title || '',
21+
}
22+
return renderSchema(resolvedSchema, schemas, name)
1823
}
1924

20-
if (schemaItem?.schema?.$ref) return resolveRef(schemaItem.schema.$ref)
21-
if (schemaItem?.$ref) return resolveRef(schemaItem.$ref)
25+
if (schemaItem?.schema?.$ref) return resolveRef(schemaItem.schema.$ref, schemaItem)
26+
if (schemaItem?.$ref) return resolveRef(schemaItem.$ref, schemaItem)
2227

2328
const renderObject = (item, itemName) => {
2429
const requiredFields = Array.isArray(item.required) ? item.required : []

0 commit comments

Comments
 (0)