Merge "Create a smart account" page and other fixes #2208
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -48,9 +48,9 @@ const bundlerClient = createBundlerClient({ | |||
| ### 3. Create a delegator account | |||
|
|
|||
| Create an account to represent Alice, the delegator who will create a delegation. | |||
| The delegator must be a [smart account](../how-to/create-smart-account/index.md). | |||
| The delegator must be a [smart account](../concepts/smart-accounts.md). | |||
There was a problem hiding this comment.
Maybe we should say delegator must be a MetaMask smart account, as only MM account supports delegation? Or do you think it's redundant?
|
|
||
| The MetaMask Delegation Toolkit supports different [MetaMask smart account types](../../concepts/smart-accounts.md#smart-account-implementation-types), | ||
| The MetaMask Delegation Toolkit is embedded, meaning that the end user can instantly interact with a dapp without wallet authorization, confirmations, or corporate logos. |
There was a problem hiding this comment.
This is not true, and doesn't fit right. The toolkit is not embedded, the accounts are embedded. Also, embedded wallet doesn't mean that a dApp doesn't need wallet authorization. It totally depends on the dApp. Since we are a smart account layer, not a signer layer this is not the stand out feature of smart account/ or something we should mention as it can't be always true.
For instance, if someone is using Privy as a signer for MetaMask smart account, by default it'll show confirmation screens of privy for signing cause Privy by default uses iFrame for signature.
| The MetaMask Delegation Toolkit supports different [MetaMask smart account types](../../concepts/smart-accounts.md#smart-account-implementation-types), | ||
| The MetaMask Delegation Toolkit is embedded, meaning that the end user can instantly interact with a dapp without wallet authorization, confirmations, or corporate logos. | ||
| You can enable users to create a [MetaMask smart account](../concepts/smart-accounts.md) directly in your dapp. | ||
| The toolkit supports different [smart account types](../concepts/smart-accounts.md#smart-account-implementation-types), |
There was a problem hiding this comment.
I think we should say to check out below instead of sending to a different page. Both have almost same content for the types of smart account.
|
|
||
| ### Configure an account signatory | ||
| ### Create a Hybrid smart account with an account signatory |
There was a problem hiding this comment.
| ### Create a Hybrid smart account with an account signatory | |
| ### Create a Hybrid smart account with an Account signatory |
We can use Account since it's Viem class.
|
|
||
| To work with WebAuthn, install the [Ox SDK](https://oxlib.sh/). | ||
|
|
||
| To use WebAuthn, install the [Ox SDK](https://oxlib.sh/). |
There was a problem hiding this comment.
We can revert, because WebAuthn is part of Viem SDK, but 0x is required for getting address, and PublicKey from credentials.
|
|
||
| - In conjunction with [Viem Account Abstraction clients](configure.md), deploy the smart account | ||
| and [send user operations](send-user-operation.md). | ||
| - [Sign delegations](create-delegation/index.md) that can be used to grant specific rights and permissions to other accounts. |
There was a problem hiding this comment.
| - [Sign delegations](create-delegation/index.md) that can be used to grant specific rights and permissions to other accounts. | |
| - [Create delegations](create-delegation/index.md) that can be used to grant specific rights and permissions to other accounts. |
| - In conjunction with [Viem Account Abstraction clients](configure.md), deploy the smart account | ||
| and [send user operations](send-user-operation.md). | ||
| - [Sign delegations](create-delegation/index.md) that can be used to grant specific rights and permissions to other accounts. | ||
| Smart accounts that sign delegations are called *delegator accounts*. |
There was a problem hiding this comment.
| Smart accounts that sign delegations are called *delegator accounts*. | |
| Smart accounts that create delegations are called *delegator accounts*. |
Description
This PR:
Preview
https://metamask-docs-git-dtk-fixes-consensys-ddffed67.vercel.app/delegation-toolkit/development/
Checklist
Complete this checklist before merging your PR: