Skip to content

Commit 087b3c2

Browse files
agangladametamaskbotzone-live
authored
fix: cp-13.11.0 bump tron 1.11.0 and keyring-api (#38206)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Bumps the tron snap to fix computing fees for swaps https://github.com/MetaMask/snap-tron-wallet/releases <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/38206?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: #38247 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Update Tron snap and keyring API dependencies and adjust e2e state logs for Tron snap cronjob event. > > - **Dependencies**: > - Bump `@metamask/tron-wallet-snap` to `^1.12.1`. > - Bump `@metamask/keyring-api` to `^21.2.0`. > - **Tests/E2E**: > - Update `test/e2e/tests/settings/state-logs.json` to include `events.cronjob-npm:@metamask/tron-wallet-snap-0`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 276dc6e. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <[email protected]> Co-authored-by: Antonio Regadas <[email protected]>
1 parent 8b80bc2 commit 087b3c2

File tree

3 files changed

+23
-12
lines changed

3 files changed

+23
-12
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@
316316
"@metamask/kernel-shims": "^0.3.0",
317317
"@metamask/kernel-ui": "^0.3.0",
318318
"@metamask/kernel-utils": "^0.3.0",
319-
"@metamask/keyring-api": "^21.1.0",
319+
"@metamask/keyring-api": "^21.2.0",
320320
"@metamask/keyring-controller": "^24.0.0",
321321
"@metamask/keyring-internal-api": "^9.1.0",
322322
"@metamask/keyring-internal-snap-client": "^8.0.0",
@@ -369,7 +369,7 @@
369369
"@metamask/streams": "^0.4.0",
370370
"@metamask/subscription-controller": "^4.2.2",
371371
"@metamask/transaction-controller": "^61.2.0",
372-
"@metamask/tron-wallet-snap": "^1.10.0",
372+
"@metamask/tron-wallet-snap": "^1.12.1",
373373
"@metamask/user-operation-controller": "^40.0.0",
374374
"@metamask/utils": "^11.4.2",
375375
"@ngraveio/bc-ur": "^1.1.13",

test/e2e/tests/settings/state-logs.json

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -414,6 +414,17 @@
414414
"ensResolutionsByAddress": {},
415415
"estimatedGasFeeTimeBounds": {},
416416
"events": {
417+
"cronjob-npm:@metamask/tron-wallet-snap-0": {
418+
"date": "string",
419+
"id": "string",
420+
"recurring": "boolean",
421+
"request": {
422+
"method": "string"
423+
},
424+
"schedule": "string",
425+
"scheduledAt": "string",
426+
"snapId": "string"
427+
},
417428
"cronjob-npm:@metamask/bitcoin-wallet-snap-0": {
418429
"date": "string",
419430
"id": "string",

yarn.lock

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7014,15 +7014,15 @@ __metadata:
70147014
languageName: node
70157015
linkType: hard
70167016

7017-
"@metamask/keyring-api@npm:^21.0.0, @metamask/keyring-api@npm:^21.1.0":
7018-
version: 21.1.0
7019-
resolution: "@metamask/keyring-api@npm:21.1.0"
7017+
"@metamask/keyring-api@npm:^21.0.0, @metamask/keyring-api@npm:^21.1.0, @metamask/keyring-api@npm:^21.2.0":
7018+
version: 21.2.0
7019+
resolution: "@metamask/keyring-api@npm:21.2.0"
70207020
dependencies:
70217021
"@metamask/keyring-utils": "npm:^3.1.0"
70227022
"@metamask/superstruct": "npm:^3.1.0"
70237023
"@metamask/utils": "npm:^11.1.0"
70247024
bitcoin-address-validation: "npm:^2.2.3"
7025-
checksum: 10/3371a5ab0e9ba0e9b23b30b03a7d83d029e223def5485ab1aa2ec793ba18ff3738422dbe3c47f9cf82411d2ca6ca918928bf998741f0977055071b7bf3042314
7025+
checksum: 10/cc3cd9f9ef65b33aa0af2f4aa556fab7ebab78ce21a09b8e1cb6f328b456c444e0169d7aac08dd62425fb12895d68dfee0ddb6e3d8a43950a8ba1852c6b92609
70267026
languageName: node
70277027
linkType: hard
70287028

@@ -8494,10 +8494,10 @@ __metadata:
84948494
languageName: node
84958495
linkType: hard
84968496

8497-
"@metamask/tron-wallet-snap@npm:^1.10.0":
8498-
version: 1.10.0
8499-
resolution: "@metamask/tron-wallet-snap@npm:1.10.0"
8500-
checksum: 10/c9b2f9cae0a2f9dcfd43934bd4321ed029e395122b61f1f3a8c3780dd4b44ac8669139b382da8b9230123639bf7a7554206223e3127d3e3317dfb802190cda46
8497+
"@metamask/tron-wallet-snap@npm:^1.12.1":
8498+
version: 1.12.1
8499+
resolution: "@metamask/tron-wallet-snap@npm:1.12.1"
8500+
checksum: 10/6f48c8dd6f625d7bb290bf3d39978839a0f4b905c14883e43fb35538b5ffa822f9611b8977fc54e9cb83711a95a9cbce93ad6a0149c4c31cfd1272af4b7055b0
85018501
languageName: node
85028502
linkType: hard
85038503

@@ -32667,7 +32667,7 @@ __metadata:
3266732667
"@metamask/kernel-shims": "npm:^0.3.0"
3266832668
"@metamask/kernel-ui": "npm:^0.3.0"
3266932669
"@metamask/kernel-utils": "npm:^0.3.0"
32670-
"@metamask/keyring-api": "npm:^21.1.0"
32670+
"@metamask/keyring-api": "npm:^21.2.0"
3267132671
"@metamask/keyring-controller": "npm:^24.0.0"
3267232672
"@metamask/keyring-internal-api": "npm:^9.1.0"
3267332673
"@metamask/keyring-internal-snap-client": "npm:^8.0.0"
@@ -32730,7 +32730,7 @@ __metadata:
3273032730
"@metamask/test-dapp-solana": "npm:^0.3.1"
3273132731
"@metamask/test-snaps": "npm:^3.0.0"
3273232732
"@metamask/transaction-controller": "npm:^61.2.0"
32733-
"@metamask/tron-wallet-snap": "npm:^1.10.0"
32733+
"@metamask/tron-wallet-snap": "npm:^1.12.1"
3273432734
"@metamask/user-operation-controller": "npm:^40.0.0"
3273532735
"@metamask/utils": "npm:^11.4.2"
3273632736
"@ngraveio/bc-ur": "npm:^1.1.13"

0 commit comments

Comments
 (0)