Commit 4f6037d
authored
feat: enable require-pr-numbers flag for changelog generation (#38520)
## **Description**
This PR updates the changelog workflows to use the new
`@metamask/[email protected]` which always filters out direct commits
without PR numbers. This ensures all changelog entries represent
reviewed and approved changes.
**Changes:**
- Update `@metamask/auto-changelog` from `^5.1.0` to `^5.3.0`
- Update workflows to use `[email protected]` which includes the
`--requirePrNumbers` flag enabled by default
The `--requirePrNumbers` flag is now always applied by default in
github-tools, so no additional configuration is needed.
[](https://codespaces.new/MetaMask/metamask-extension/pull/38520?quickstart=1)
## **Changelog**
CHANGELOG entry: null
## **Related issues**
- ✅
[MetaMask/auto-changelog#253](MetaMask/auto-changelog#253)
- Merged
- ✅
[MetaMask/github-tools#181](MetaMask/github-tools#181)
- Merged and released as v1.1.2
## **Manual testing steps**
1. Tested on
[consensys-test/metamask-extension-test](https://github.com/consensys-test/metamask-extension-test)
with `release/1100.0.0`
2. Verified PR commits are included in changelog
3. Verified direct commits are excluded from changelog
4. See [generated
changelog](https://github.com/consensys-test/metamask-extension-test/blob/release/1100.0.0-Changelog/CHANGELOG.md)
## **Screenshots/Recordings**
### **Before**
Direct commits without PR numbers would appear in the changelog.
### **After**
Only commits with PR numbers (representing reviewed changes) appear in
the changelog.
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.1 parent 0dbf2b2 commit 4f6037d
File tree
3 files changed
+8
-8
lines changed- .github/workflows
3 files changed
+8
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
58 | 58 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
480 | 480 | | |
481 | 481 | | |
482 | 482 | | |
483 | | - | |
| 483 | + | |
484 | 484 | | |
485 | 485 | | |
486 | 486 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5878 | 5878 | | |
5879 | 5879 | | |
5880 | 5880 | | |
5881 | | - | |
5882 | | - | |
5883 | | - | |
| 5881 | + | |
| 5882 | + | |
| 5883 | + | |
5884 | 5884 | | |
5885 | 5885 | | |
5886 | 5886 | | |
| |||
5891 | 5891 | | |
5892 | 5892 | | |
5893 | 5893 | | |
5894 | | - | |
| 5894 | + | |
5895 | 5895 | | |
5896 | 5896 | | |
5897 | 5897 | | |
| |||
33332 | 33332 | | |
33333 | 33333 | | |
33334 | 33334 | | |
33335 | | - | |
| 33335 | + | |
33336 | 33336 | | |
33337 | 33337 | | |
33338 | 33338 | | |
| |||
0 commit comments