feat: cp-13.12.0 revert sidepanel (#38512)

This PR is to revert sidepanel

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/38512?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:no sidepanel

## **Related issues**

Fixes:

## **Manual testing steps**

1. Run extension, see no switch to sidepanel button in global menu
2. for new user, after onboarding it shouldn't onboard the user on
sidepanel

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

NA
### **After**

NA
## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Disables sidepanel across builds and CI, removes manifest sidepanel
config/permission, and updates e2e onboarding to run sidepanel logic
only when enabled.
> 
> - **Build/CI**:
> - Set `IS_SIDEPANEL: false` in `builds.yml` (all build types and
global env) and `.github/workflows/run-e2e.yml`.
> - **Manifests**:
>   - `app/manifest/v3/_base.json`: Remove `"sidePanel"` permission.
> - `app/manifest/v3/chrome.json`: Remove `side_panel` block (default
path) while keeping `minimum_chrome_version`.
> - **E2E Tests**:
> - `test/e2e/page-objects/flows/onboarding.flow.ts`: Gate
`handleSidepanelPostOnboarding` to only run when `SELENIUM_BROWSER ===
'chrome'` and `IS_SIDEPANEL === 'true'`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
cab8cee. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: NidhiKJha

.github/workflows/run-e2e.yml

@@ -74,7 +74,7 @@ jobs:
       RUN_ID: ${{ github.run_id }}
       PR_NUMBER: ${{ github.event.pull_request.number || '' }}
       TEST_SUITE_NAME: ${{ inputs.test-suite-name }}
-      IS_SIDEPANEL: true
+      IS_SIDEPANEL: false
     steps:
       - name: Checkout and setup environment
         uses: MetaMask/action-checkout-and-setup@v1

app/manifest/v3/_base.json

@@ -87,8 +87,7 @@
     "unlimitedStorage",
     "webRequest",
     "offscreen",
-    "identity",
-    "sidePanel"
+    "identity"
   ],
   "sandbox": {
     "pages": ["snaps/index.html"]

app/manifest/v3/chrome.json

@@ -10,8 +10,5 @@
     "matches": ["http://*/*", "https://*/*"],
     "ids": ["*"]
   },
-  "minimum_chrome_version": "115",
-  "side_panel": {
-    "default_path": "sidepanel.html"
-  }
+  "minimum_chrome_version": "115"
 }

builds.yml

@@ -34,7 +34,7 @@ buildTypes:
       - REJECT_INVALID_SNAPS_PLATFORM_VERSION: true
       - IFRAME_EXECUTION_ENVIRONMENT_URL: https://execution.metamask.io/iframe/10.2.3/index.html
       - ACCOUNT_SNAPS_DIRECTORY_URL: https://snaps.metamask.io/account-management
-      - IS_SIDEPANEL: true
+      - IS_SIDEPANEL: false
       - EXTENSION_UX_PNA25: true
       # for seedless onboarding (social login)
       - GOOGLE_PROD_CLIENT_ID
@@ -69,7 +69,7 @@ buildTypes:
       - REJECT_INVALID_SNAPS_PLATFORM_VERSION: true
       - IFRAME_EXECUTION_ENVIRONMENT_URL: https://execution.metamask.io/iframe/10.2.3/index.html
       - ACCOUNT_SNAPS_DIRECTORY_URL: https://snaps.metamask.io/account-management
-      - IS_SIDEPANEL: true
+      - IS_SIDEPANEL: false
       - EXTENSION_UX_PNA25: true
       # for seedless onboarding (social login)
       - GOOGLE_BETA_CLIENT_ID
@@ -100,7 +100,7 @@ buildTypes:
       - INFURA_ENV_KEY_REF: INFURA_EXPERIMENTAL_PROJECT_ID
       - SEGMENT_WRITE_KEY_REF: SEGMENT_EXPERIMENTAL_WRITE_KEY
       - ALLOW_LOCAL_SNAPS: false
-      - IS_SIDEPANEL: true
+      - IS_SIDEPANEL: false
       - REQUIRE_SNAPS_ALLOWLIST: true
       - REJECT_INVALID_SNAPS_PLATFORM_VERSION: true
       - IFRAME_EXECUTION_ENVIRONMENT_URL: https://execution.metamask.io/iframe/10.2.3/index.html
@@ -140,7 +140,7 @@ buildTypes:
       - SEGMENT_WRITE_KEY_REF: SEGMENT_FLASK_WRITE_KEY
       - ACCOUNT_SNAPS_DIRECTORY_URL: https://metamask.github.io/snaps-directory-staging/main/account-management
       - EIP_4337_ENTRYPOINT: '0x5FF137D4b0FDCD49DcA30c7CF57E578a026d2789'
-      - IS_SIDEPANEL: true
+      - IS_SIDEPANEL: false
       - EXTENSION_UX_PNA25: true
       # for seedless onboarding (social login)
       - GOOGLE_FLASK_CLIENT_ID
@@ -467,4 +467,4 @@ env:
 
   # PNA25 (Privacy Notice)
   - EXTENSION_UX_PNA25: true
-  - IS_SIDEPANEL: true
+  - IS_SIDEPANEL: false

test/e2e/page-objects/flows/onboarding.flow.ts

@@ -26,8 +26,12 @@ import TermsOfUseUpdateModal from '../pages/dialog/terms-of-use-update-modal';
 export const handleSidepanelPostOnboarding = async (
   driver: Driver,
 ): Promise<void> => {
-  // Only run on Chrome-based browsers (Firefox doesn't support sidepanel)
-  if (process.env.SELENIUM_BROWSER === Browser.FIREFOX) {
+  // Only run when sidepanel is actually enabled on Chrome
+  const isSidepanelEnabled =
+    process.env.SELENIUM_BROWSER === 'chrome' &&
+    process.env.IS_SIDEPANEL === 'true';
+
+  if (!isSidepanelEnabled) {
     return;
   }