fix: avoid unmounted state update in notifications modal

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>

Author: cursoragent

ui/components/app/modals/turn-on-metamask-notifications/turn-on-metamask-notifications.tsx

@@ -1,4 +1,4 @@
-import React, { useContext, useEffect, useState } from 'react';
+import React, { useContext, useEffect, useRef, useState } from 'react';
 import { useSelector } from 'react-redux';
 import { useNavigate } from 'react-router-dom';
 import { I18nContext } from '../../../../contexts/i18n';
@@ -57,9 +57,14 @@ export default function TurnOnMetamaskNotifications() {
   const [isLoading, setIsLoading] = useState<boolean>(
     isUpdatingMetamaskNotifications,
   );
+  const isLoadingRef = useRef(isUpdatingMetamaskNotifications);
 
   const { enableNotifications, error } = useEnableNotifications();
 
+  useEffect(() => {
+    isLoadingRef.current = isLoading;
+  }, [isLoading]);
+
   const handleTurnOnNotifications = async () => {
     setIsLoading(true);
     trackEvent({
@@ -78,24 +83,25 @@ export default function TurnOnMetamaskNotifications() {
   };
 
   const handleHideModal = () => {
+    // Read loading state from a ref to avoid scheduling state updates during close.
+    const isCurrentlyLoading = isLoadingRef.current;
+
+    if (!isCurrentlyLoading) {
+      trackEvent({
+        category: MetaMetricsEventCategory.NotificationsActivationFlow,
+        event: MetaMetricsEventName.NotificationsActivated,
+        properties: {
+          // TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
+          // eslint-disable-next-line @typescript-eslint/naming-convention
+          is_profile_syncing_enabled: isBackupAndSyncEnabled,
+          // TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
+          // eslint-disable-next-line @typescript-eslint/naming-convention
+          action_type: 'dismissed',
+        },
+      });
+    }
+
     hideModal();
-    setIsLoading((prevLoadingState) => {
-      if (!prevLoadingState) {
-        trackEvent({
-          category: MetaMetricsEventCategory.NotificationsActivationFlow,
-          event: MetaMetricsEventName.NotificationsActivated,
-          properties: {
-            // TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
-            // eslint-disable-next-line @typescript-eslint/naming-convention
-            is_profile_syncing_enabled: isBackupAndSyncEnabled,
-            // TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
-            // eslint-disable-next-line @typescript-eslint/naming-convention
-            action_type: 'dismissed',
-          },
-        });
-      }
-      return prevLoadingState;
-    });
   };
 
   useEffect(() => {