Commit 85a6242
authored
fix: layout inconsistencies - account pages (#38533)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
Fixes layout inconsistencies in account pages in fullscreen and
sidepanel
The widths should be controlled at the layout level
[](https://codespaces.new/MetaMask/metamask-extension/pull/38533?quickstart=1)
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: fix: layout inconsistencies - account pages
## **Related issues**
Fixes:
## **Manual testing steps**
1. Account menu > Account Details
2. click Private Kays
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
| Account details | Private keys |
|---|---|
|<img width="841" height="358" alt="image"
src="https://github.com/user-attachments/assets/af560aad-873a-4a67-afa4-98e51c848f6c"
/>|<img width="1538" height="370" alt="image"
src="https://github.com/user-attachments/assets/32c3d317-ee3f-421a-bc62-30a168e2ce32"
/>|
### **After**
<!-- [screenshots/recordings] -->
| Account details | Private keys |
|---|---|
|<img width="830" height="364" alt="image"
src="https://github.com/user-attachments/assets/5f5408e5-4248-4ce2-b814-f5dfd137c205"
/>|<img width="830" height="382" alt="image"
src="https://github.com/user-attachments/assets/ff602c76-4958-42e5-9312-f36c3a11daa3"
/>|
## **Pre-merge author checklist**
- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> Switches account-related routes to `RootLayout`, updates Create
Account to use design system `Box` with full-height, and removes
max-width/responsive width constraints from account pages.
>
> - **Routing/Layout**:
> - Use `RootLayout` for `NEW_ACCOUNT_ROUTE` and
`MULTICHAIN_ACCOUNT_PRIVATE_KEY_LIST_PAGE_ROUTE` in
`ui/pages/routes/routes.component.tsx`.
> - **Create Account Page**:
> - Replace `Box` import with `@metamask/design-system-react` and add
`h-full` class in `ui/pages/create-account/create-account.component.js`.
> - Remove responsive width media queries from
`ui/pages/create-account/create-account.scss`.
> - **Multichain Details Styles**:
> - Remove `max-width` constraint from
`ui/pages/multichain-accounts/multichain-account-details-page/index.scss`
and `ui/pages/multichain-accounts/wallet-details-page/index.scss`.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
e6b0315. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 59389a0 commit 85a6242
File tree
5 files changed
+4
-20
lines changed- ui/pages
- create-account
- multichain-accounts
- multichain-account-details-page
- wallet-details-page
- routes
5 files changed
+4
-20
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | 5 | | |
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
4 | 2 | | |
5 | 3 | | |
6 | 4 | | |
| |||
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
4 | 2 | | |
5 | 3 | | |
6 | 4 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
831 | 831 | | |
832 | 832 | | |
833 | 833 | | |
834 | | - | |
| 834 | + | |
835 | 835 | | |
836 | 836 | | |
837 | 837 | | |
| |||
1022 | 1022 | | |
1023 | 1023 | | |
1024 | 1024 | | |
1025 | | - | |
| 1025 | + | |
1026 | 1026 | | |
1027 | 1027 | | |
1028 | 1028 | | |
| |||
0 commit comments