Skip to content

Commit 88b054c

Browse files
authored
fix: permission page footer bg (#38497)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Remove footer background (alternate) that differs from body (default) reported as a bug in https://consensyssoftware.atlassian.net/browse/CEUX-770 [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/38497?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: fix: permission page footer background ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/CEUX-770 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Removes the alternate background color from the permission page footer container to match the body background. > > - **UI (permissions)**: > - In `ui/components/app/permission-page-container/permission-page-container.component.js`, remove `BackgroundColor.backgroundAlternative` from the footer `Box`, leaving only `display` and `flexDirection`. > - Drop unused `BackgroundColor` import. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit afa62e2. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent e295b78 commit 88b054c

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

ui/components/app/permission-page-container/permission-page-container.component.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import SnapPrivacyWarning from '../snaps/snap-privacy-warning';
1414
import { getDedupedSnaps } from '../../../helpers/utils/util';
1515

1616
import {
17-
BackgroundColor,
1817
Display,
1918
FlexDirection,
2019
} from '../../../helpers/constants/design-system';
@@ -231,11 +230,7 @@ export default class PermissionPageContainer extends Component {
231230
selectedAccounts={selectedAccounts}
232231
allAccountsSelected={allAccountsSelected}
233232
/>
234-
<Box
235-
display={Display.Flex}
236-
backgroundColor={BackgroundColor.backgroundAlternative}
237-
flexDirection={FlexDirection.Column}
238-
>
233+
<Box display={Display.Flex} flexDirection={FlexDirection.Column}>
239234
{targetSubjectMetadata?.subjectType !== SubjectType.Snap && (
240235
<PermissionsConnectFooter />
241236
)}

0 commit comments

Comments
 (0)