test: remove defaultGanacheOptions (#30728)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

In this PR we remove the `defaultGanacheOptions` variable from all
specs. 2 reasons:
- the default options, are already handled in the node class level, so
no need to pass default options in any spec, only custom options
- we are going to use anvil, or other nodes, so this custom variable
makes no sense anymore

Note: skip-e2e-quality-gate is added because we modify several spec
files, which can take long to run, reaching timeout as they'll all be
rerun + 5 times extra, but there should be no functional change, so e2e
should continue to work as before

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30728?quickstart=1)

## **Related issues**

Fixes: MetaMask/MetaMask-planning#4348

## **Manual testing steps**

1. All specs should continue to work normally

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Author: seaona

test/e2e/helpers.js

@@ -531,17 +531,7 @@ const PRIVATE_KEY_TWO =
 const ACCOUNT_1 = '0x5cfe73b6021e818b776b421b1c4db2474086a7e1';
 const ACCOUNT_2 = '0x09781764c08de8ca82e156bbf156a3ca217c7950';
 
-const defaultGanacheOptions = {
-  accounts: [
-    {
-      secretKey: PRIVATE_KEY,
-      balance: convertETHToHexGwei(DEFAULT_GANACHE_ETH_BALANCE_DEC),
-    },
-  ],
-};
-
 const defaultGanacheOptionsForType2Transactions = {
-  ...defaultGanacheOptions,
   // EVM version that supports type 2 transactions (EIP1559)
   hardfork: 'london',
 };
@@ -956,7 +946,6 @@ module.exports = {
   switchToOrOpenDapp,
   connectToDapp,
   multipleGanacheOptions,
-  defaultGanacheOptions,
   defaultGanacheOptionsForType2Transactions,
   multipleGanacheOptionsForType2Transactions,
   sendTransaction,

test/e2e/json-rpc/eth_newBlockFilter.spec.ts

@@ -1,13 +1,12 @@
 import { strict as assert } from 'assert';
-import { defaultGanacheOptions, withFixtures } from '../helpers';
+import { withFixtures } from '../helpers';
 import { loginWithBalanceValidation } from '../page-objects/flows/login.flow';
 import FixtureBuilder from '../fixture-builder';
 import { Driver } from '../webdriver/driver';
 
 describe('eth_newBlockFilter', function () {
-  const ganacheOptions: typeof defaultGanacheOptions & { blockTime: number } = {
+  const ganacheOptions: { blockTime: number } = {
     blockTime: 0.1,
-    ...defaultGanacheOptions,
   };
   it('executes a new block filter call', async function () {
     await withFixtures(

test/e2e/json-rpc/wallet_addEthereumChain.spec.ts

@@ -7,7 +7,6 @@ import FixtureBuilder from '../fixture-builder';
 import { Driver } from '../webdriver/driver';
 import {
   withFixtures,
-  defaultGanacheOptions,
   openDapp,
   unlockWallet,
   WINDOW_TITLES,
@@ -479,7 +478,6 @@ describe('Add Ethereum Chain', function () {
           fixtures: new FixtureBuilder()
             .withPermissionControllerConnectedToTestDappWithChains(['0x539'])
             .build(),
-          localNodeOptions: defaultGanacheOptions,
           title: this.test?.fullTitle(),
         },
         async ({ driver }: { driver: Driver }) => {

test/e2e/tests/confirmations/helpers.ts

@@ -1,7 +1,6 @@
 import { TransactionEnvelopeType } from '@metamask/transaction-controller';
 import FixtureBuilder from '../../fixture-builder';
 import {
-  defaultGanacheOptions,
   defaultGanacheOptionsForType2Transactions,
   withFixtures,
 } from '../../helpers';
@@ -44,7 +43,7 @@ export function withTransactionEnvelopeTypeFixtures(
         .build(),
       localNodeOptions:
         transactionEnvelopeType === TransactionEnvelopeType.legacy
-          ? defaultGanacheOptions
+          ? {}
           : defaultGanacheOptionsForType2Transactions,
       ...(smartContract && { smartContract }),
       ...(mocks && { testSpecificMock: mocks }),

test/e2e/tests/metrics/metametrics-persistence.spec.js

@@ -2,17 +2,12 @@ const { strict: assert } = require('assert');
 const FixtureBuilder = require('../../fixture-builder');
 const {
   withFixtures,
-  generateGanacheOptions,
-  defaultGanacheOptions,
   unlockWallet,
-  genRandInitBal,
   getCleanAppState,
 } = require('../../helpers');
 
 describe('MetaMetrics ID persistence', function () {
   it('MetaMetrics ID should persist when the user opts-out and then opts-in again of MetaMetrics collection', async function () {
-    const { initialBalanceInHex } = genRandInitBal();
-
     const initialMetaMetricsId = 'test-metrics-id';
 
     await withFixtures(
@@ -23,14 +18,6 @@ describe('MetaMetrics ID persistence', function () {
             participateInMetaMetrics: true,
           })
           .build(),
-        localNodeOptions: generateGanacheOptions({
-          accounts: [
-            {
-              secretKey: defaultGanacheOptions.accounts[0].secretKey,
-              balance: initialBalanceInHex,
-            },
-          ],
-        }),
         title: this.test.fullTitle(),
       },
       async ({ driver }) => {

test/e2e/tests/multichain/asset-picker-send.spec.ts

@@ -3,7 +3,6 @@ import { Context } from 'mocha';
 import { CHAIN_IDS } from '../../../../shared/constants/network';
 import FixtureBuilder from '../../fixture-builder';
 import {
-  defaultGanacheOptions,
   openActionMenuAndStartSendFlow,
   unlockWallet,
   withFixtures,
@@ -17,7 +16,6 @@ describe('AssetPickerSendFlow', function () {
   const fixtures = {
     fixtures: new FixtureBuilder({ inputChainId: chainId }).build(),
     localNodeOptions: {
-      ...defaultGanacheOptions,
       chainId: parseInt(chainId, 16),
     },
   };

test/e2e/tests/request-queuing/sendTx-revokePermissions.spec.ts

@@ -4,11 +4,7 @@ import TransactionConfirmation from '../../page-objects/pages/confirmations/rede
 import { Driver } from '../../webdriver/driver';
 import { DEFAULT_FIXTURE_ACCOUNT } from '../../constants';
 import FixtureBuilder from '../../fixture-builder';
-import {
-  withFixtures,
-  defaultGanacheOptions,
-  WINDOW_TITLES,
-} from '../../helpers';
+import { withFixtures, WINDOW_TITLES } from '../../helpers';
 
 describe('Request Queuing', function () {
   // TODO: add a new spec which checks that after revoking and connecting again
@@ -22,9 +18,6 @@ describe('Request Queuing', function () {
           .withPermissionControllerConnectedToTestDapp()
           .withSelectedNetworkControllerPerDomain()
           .build(),
-        localNodeOptions: {
-          ...defaultGanacheOptions,
-        },
         title: this.test?.fullTitle(),
       },
       async ({ driver }: { driver: Driver }) => {

test/e2e/tests/tokens/add-token-using-search.spec.ts

@@ -1,5 +1,5 @@
 import { MockedEndpoint, Mockttp } from 'mockttp';
-import { defaultGanacheOptions, withFixtures } from '../../helpers';
+import { withFixtures } from '../../helpers';
 import FixtureBuilder from '../../fixture-builder';
 import { CHAIN_IDS } from '../../../../shared/constants/network';
 import AssetListPage from '../../page-objects/pages/home/asset-list';
@@ -48,7 +48,6 @@ describe('Add existing token using search', function () {
           })
           .build(),
         localNodeOptions: {
-          ...defaultGanacheOptions,
           chainId: parseInt(CHAIN_IDS.BSC, 16),
         },
         title: this.test?.fullTitle(),

test/e2e/tests/tokens/token-details.spec.ts

@@ -3,11 +3,7 @@ import { Context } from 'mocha';
 import { CHAIN_IDS } from '../../../../shared/constants/network';
 import { formatCurrency } from '../../../../ui/helpers/utils/confirm-tx.util';
 import FixtureBuilder from '../../fixture-builder';
-import {
-  defaultGanacheOptions,
-  unlockWallet,
-  withFixtures,
-} from '../../helpers';
+import { unlockWallet, withFixtures } from '../../helpers';
 import { Driver } from '../../webdriver/driver';
 import HomePage from '../../page-objects/pages/home/homepage';
 import AssetListPage from '../../page-objects/pages/home/asset-list';
@@ -26,7 +22,6 @@ describe('Token Details', function () {
   const fixtures = {
     fixtures: new FixtureBuilder({ inputChainId: chainId }).build(),
     localNodeOptions: {
-      ...defaultGanacheOptions,
       chainId: parseInt(chainId, 16),
     },
   };

test/e2e/tests/tokens/token-list.spec.ts

@@ -4,11 +4,7 @@ import { zeroAddress } from 'ethereumjs-util';
 import { Browser } from 'selenium-webdriver';
 import { CHAIN_IDS } from '../../../../shared/constants/network';
 import FixtureBuilder from '../../fixture-builder';
-import {
-  defaultGanacheOptions,
-  unlockWallet,
-  withFixtures,
-} from '../../helpers';
+import { unlockWallet, withFixtures } from '../../helpers';
 import { Driver } from '../../webdriver/driver';
 import HomePage from '../../page-objects/pages/home/homepage';
 import AssetListPage from '../../page-objects/pages/home/asset-list';
@@ -30,7 +26,6 @@ describe('Token List', function () {
   const fixtures = {
     fixtures: new FixtureBuilder({ inputChainId: chainId }).build(),
     localNodeOptions: {
-      ...defaultGanacheOptions,
       chainId: parseInt(chainId, 16),
     },
   };