Skip to content

Commit b1516e9

Browse files
committed
chore(5956): lint fix
1 parent ec732ff commit b1516e9

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

development/webpack/utils/cli.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -410,8 +410,9 @@ function getOptions(
410410
/**
411411
* Returns a string representation of the given arguments and features.
412412
*
413-
* @param args
414-
* @param features
413+
* @param args - The parsed CLI arguments
414+
* @param features - The active and available features
415+
* @param resolvedEnvironment - The resolved MetaMask environment
415416
*/
416417
export function getDryRunMessage(
417418
args: Args,

development/webpack/utils/config.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -91,20 +91,13 @@ export function getBuildName(
9191
* 1. If `--test` is set, returns 'testing'
9292
* 2. If `--metamaskEnvironment` is explicitly set via CLI, uses that value
9393
* 3. If `--env development`, returns 'development'
94-
* 4. Otherwise (production-like builds), auto-detects from git context:
95-
* - release/* branch → 'release-candidate'
96-
* - main branch → 'staging'
97-
* - pull_request event → 'pull-request'
98-
* - anything else (including local builds) → 'other'
94+
* 4. Otherwise, auto-detects from git context (release branch, main, PR, or other)
9995
*
10096
* NOTE: 'production' environment is NEVER auto-detected. It must be explicitly
10197
* set via --metamaskEnvironment to prevent accidental pollution of production
10298
* Sentry with events from local or CI test builds.
10399
*
104100
* @param args - The parsed CLI arguments
105-
* @param args.test - Whether this is a test build
106-
* @param args.env - The webpack environment ('production' or 'development')
107-
* @param args.metamaskEnvironment - Explicit environment override from CLI
108101
* @returns The resolved environment string
109102
*/
110103
export function resolveEnvironment(
@@ -164,7 +157,7 @@ export function getVariables(
164157
const isDevBuild = env === 'development';
165158

166159
// Resolve the MetaMask environment using proper detection logic
167-
const environment = resolveEnvironment({ test: args.test, env, ...args });
160+
const environment = resolveEnvironment({ ...args, env });
168161

169162
function set(key: string, value: unknown): void;
170163
function set(key: Record<string, unknown>): void;

0 commit comments

Comments
 (0)