Fix TypeScript errors in benchmark files

Add `NumericBenchmarkMetrics` type that excludes object-typed properties
(`memoryUsage`, `longTaskMetrics`) for statistical aggregation. Update
`BenchmarkSummary` to use this type for mean/min/max/p95/p99/stddev fields.

Author: MajorLift

development/page-load-benchmark-pr-comment.ts

@@ -2,8 +2,8 @@ import { promises as fs } from 'fs';
 import path from 'path';
 import { mean as calculateMean } from 'lodash';
 import {
-  BenchmarkMetrics,
   BenchmarkSummary,
+  NumericBenchmarkMetrics,
 } from '../test/e2e/page-objects/benchmark/page-load-benchmark';
 
 /**
@@ -101,12 +101,12 @@ function aggregateHistoricalBenchmarkData(
     const pageData: BenchmarkSummary = {
       page: pageName,
       samples: 0, // Not used downstream
-      mean: {} as BenchmarkMetrics,
-      standardDeviation: {} as BenchmarkMetrics,
-      min: {} as BenchmarkMetrics,
-      max: {} as BenchmarkMetrics,
-      p95: {} as BenchmarkMetrics,
-      p99: {} as BenchmarkMetrics,
+      mean: {},
+      standardDeviation: {},
+      min: {},
+      max: {},
+      p95: {},
+      p99: {},
     };
 
     // Collect mean values for key metrics across all commits
@@ -120,9 +120,7 @@ function aggregateHistoricalBenchmarkData(
         // Only collect key metrics
         Object.values(KeyMetrics).forEach((metricKey) => {
           const metricValue =
-            pageSummary.mean[
-              metricKey as keyof Omit<BenchmarkMetrics, 'memoryUsage'>
-            ];
+            pageSummary.mean[metricKey as keyof NumericBenchmarkMetrics];
           if (typeof metricValue === 'number') {
             if (!metricMeans[metricKey]) {
               metricMeans[metricKey] = [];
@@ -139,7 +137,7 @@ function aggregateHistoricalBenchmarkData(
       if (values.length > 0) {
         const calculatedMean = calculateMean(values);
         pageData.mean[
-          metricKey as keyof Omit<BenchmarkMetrics, 'memoryUsage'>
+          metricKey as keyof NumericBenchmarkMetrics
         ] = calculatedMean;
       }
     });
@@ -337,10 +335,10 @@ function getMetricValues(
   metric: string,
 ): { mean: number; stdDev: number } | null {
   const meanValue =
-    summary.mean[metric as keyof Omit<BenchmarkMetrics, 'memoryUsage'>];
+    summary.mean[metric as keyof NumericBenchmarkMetrics];
   const stdDevValue =
     summary.standardDeviation[
-      metric as keyof Omit<BenchmarkMetrics, 'memoryUsage'>
+      metric as keyof NumericBenchmarkMetrics
     ];
 
   if (typeof meanValue !== 'number') {
@@ -486,13 +484,13 @@ function generateBenchmarkComment(
       }
 
       const minValue =
-        pageSummary.min[metric as keyof Omit<BenchmarkMetrics, 'memoryUsage'>];
+        pageSummary.min[metric as keyof NumericBenchmarkMetrics];
       const maxValue =
-        pageSummary.max[metric as keyof Omit<BenchmarkMetrics, 'memoryUsage'>];
+        pageSummary.max[metric as keyof NumericBenchmarkMetrics];
       const p95Value =
-        pageSummary.p95[metric as keyof Omit<BenchmarkMetrics, 'memoryUsage'>];
+        pageSummary.p95[metric as keyof NumericBenchmarkMetrics];
       const p99Value =
-        pageSummary.p99[metric as keyof Omit<BenchmarkMetrics, 'memoryUsage'>];
+        pageSummary.p99[metric as keyof NumericBenchmarkMetrics];
 
       comment += `| ${metric} | ${formatTime(currentValues.mean)} | ${formatTime(currentValues.stdDev)} | ${formatTime(minValue || 0)} | ${formatTime(maxValue || 0)} | ${formatTime(p95Value || 0)} | ${formatTime(p99Value || 0)} |\n`;
     }

test/e2e/page-objects/benchmark/page-load-benchmark.ts

@@ -93,6 +93,15 @@ export type BenchmarkMetrics = {
   };
 };
 
+/**
+ * Numeric-only benchmark metrics for statistical aggregation.
+ * Excludes object-typed properties (memoryUsage, longTaskMetrics).
+ */
+export type NumericBenchmarkMetrics = Omit<
+  BenchmarkMetrics,
+  'memoryUsage' | 'longTaskMetrics'
+>;
+
 /**
  * Individual benchmark measurement result for a single page load test.
  * Contains the raw performance metrics for one specific test run.
@@ -118,17 +127,17 @@ export type BenchmarkSummary = {
   /** Number of test samples collected for this page */
   samples: number;
   /** Mean (average) values for each performance metric */
-  mean: Partial<BenchmarkMetrics>;
+  mean: Partial<NumericBenchmarkMetrics>;
   /** 95th percentile values for each performance metric */
-  p95: Partial<BenchmarkMetrics>;
+  p95: Partial<NumericBenchmarkMetrics>;
   /** 99th percentile values for each performance metric */
-  p99: Partial<BenchmarkMetrics>;
+  p99: Partial<NumericBenchmarkMetrics>;
   /** Minimum values for each performance metric */
-  min: Partial<BenchmarkMetrics>;
+  min: Partial<NumericBenchmarkMetrics>;
   /** Maximum values for each performance metric */
-  max: Partial<BenchmarkMetrics>;
+  max: Partial<NumericBenchmarkMetrics>;
   /** Standard deviation values for each performance metric */
-  standardDeviation: Partial<BenchmarkMetrics>;
+  standardDeviation: Partial<NumericBenchmarkMetrics>;
 };
 
 /**
@@ -453,10 +462,9 @@ export class PageLoadBenchmark {
 
     for (const [page, pageResults] of Object.entries(resultsByPage)) {
       const metrics = pageResults.map((r) => r.metrics);
-      const metricKeys = Object.keys(metrics[0]) as (keyof Omit<
-        BenchmarkMetrics,
-        'memoryUsage'
-      >)[];
+      const metricKeys = Object.keys(metrics[0]).filter(
+        (k) => k !== 'memoryUsage' && k !== 'longTaskMetrics',
+      ) as (keyof NumericBenchmarkMetrics)[];
 
       const summary: BenchmarkSummary = {
         page,