Skip to content

Commit e66d9a7

Browse files
authored
fix: Cannot convert undefined or null to object (#38471)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** handle empty object gracefully <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/38471?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: fix cannot convert undefined or null to object sentry ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Guard `multichainNetworkConfigurationsByChainId` when computing `MetaMetricsUserTrait.ChainIdList` to prevent undefined/null errors. > > - **MetaMetricsController**: > - Make `ChainIdList` construction null-safe by defaulting `metamaskState.multichainNetworkConfigurationsByChainId` to `{}` before `Object.keys`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 9c11622. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 7604bc8 commit e66d9a7

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

app/scripts/controllers/metametrics-controller.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1393,7 +1393,9 @@ export default class MetaMetricsController extends BaseController<
13931393
...Object.keys(metamaskState.networkConfigurationsByChainId).map(
13941394
(hexChainId) => `eip155:${parseInt(hexChainId, 16)}`,
13951395
),
1396-
...Object.keys(metamaskState.multichainNetworkConfigurationsByChainId), // the state here is already caip-2 formatted
1396+
...Object.keys(
1397+
metamaskState?.multichainNetworkConfigurationsByChainId || {},
1398+
), // the state here is already caip-2 formatted
13971399
],
13981400
[MetaMetricsUserTrait.NftAutodetectionEnabled]:
13991401
metamaskState.useNftDetection,

0 commit comments

Comments
 (0)