Skip to content

Commit ecd9442

Browse files
davidmurdochHowardBraham
authored andcommitted
release(cp): chore: fix newly reported dependency audit vulnerabilities by updating minimatch-related deps (#40315)
1 parent 76eb087 commit ecd9442

File tree

23 files changed

+354
-364
lines changed

23 files changed

+354
-364
lines changed

.eslintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -588,7 +588,7 @@ module.exports = {
588588
files: ['development/**/*.js', 'test/helpers/setup-helper.js'],
589589
rules: {
590590
'n/no-process-exit': 'off',
591-
'n/shebang': 'off',
591+
'n/hashbang': 'off',
592592
},
593593
},
594594
/**

.eslintrc.node.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,16 @@ module.exports = {
22
extends: ['@metamask/eslint-config-nodejs'],
33
rules: {
44
'n/no-process-env': 'off',
5+
// eslint-plugin-n@17 started treating these browser globals as Node builtins
6+
// and `n/hashbang` started flagging existing script headers in this repo.
7+
// Keep prior behavior while we remain on the current shared config stack.
8+
'n/no-unsupported-features/node-builtins': [
9+
'error',
10+
{
11+
ignores: ['navigator', 'Navigator', 'localStorage'],
12+
},
13+
],
14+
'n/hashbang': 'off',
515
// TODO: re-enable these rules
616
'n/no-sync': 'off',
717
'n/no-unpublished-import': 'off',

.yarnrc.yml

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -26,29 +26,6 @@ npmAuditIgnoreAdvisories:
2626
# We are ignoring this on April 24, 2025 to unblock CI, we will follow with a proper fix or confirmation this does not affect our users
2727
- 1104001
2828

29-
# Issue: `glob` vulnerability, already fixed in the version we're using (v10.5.0) but the
30-
# advisory range hasn't been updated yet.
31-
# URL: https://github.com/advisories/GHSA-5j98-mcp5-4vw2
32-
- 1109809
33-
34-
# Issue: `body-parser` denial of service vulnerability
35-
# Seemingly only impacts v2.2.0, but we're on v1. The advisory range is overly wide.
36-
# The attack vector also does not apply to how we use the package.
37-
# URL: https://github.com/advisories/GHSA-wqch-xfxh-vrr4
38-
- 1110857
39-
40-
# Issue: ajv has ReDoS when using `$data` option
41-
# A lot of our linting tooling relies on old versions of ajv, which proves hard to deal with
42-
# For now, we are ignoring this to unblock CI
43-
# URL: https://github.com/advisories/GHSA-2g4f-4pwh-qvx6
44-
- 1113214
45-
46-
# Issue: minimatch has a ReDoS via repeated wildcards with non-matching literal in pattern
47-
# Only affects dev/build-time dependencies (eslint-plugin-n, glob) — not shipped to users.
48-
# URL: https://github.com/advisories/GHSA-3ppc-4f35-3m26
49-
- 1113371
50-
- 1113459
51-
5229
### Package Deprecations:
5330

5431
# React-tippy brings in popper.js and react-tippy has not been updated in
@@ -104,3 +81,5 @@ npmPreapprovedPackages:
10481
- 'lavamoat-node'
10582
- 'lavamoat'
10683
- 'extension-port-stream'
84+
# Temporary bypass for recent minimatch security patch; remove once older than age gate.
85+
- 'minimatch'

0 commit comments

Comments
 (0)