Skip to content

Commit ef4cfca

Browse files
fix: cp-13.10.4 add mon to the currency list (#38261) (#38268)
- fix: cp-13.10.4 add mon to the currency list (#38261) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** add mon as currency to fetch prices <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/38261?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: add mon as currency to fetch prices ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Normalizes token balance storage to lowercase account keys and adds `mon` to supported currencies. > > - **Assets Controllers**: > - Normalize account keys to lowercase when updating balances in `dist/TokenBalancesController.{cjs,mjs}` to avoid mixed-case keys. > - **Token Prices Service**: > - Add `mon` (Monad) to `SUPPORTED_CURRENCIES` in `dist/token-prices-service/codefi-v2.cjs`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 9ad7cda. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> [05880bf](05880bf) Co-authored-by: Gauthier Petetin <[email protected]>
1 parent 88d2dfd commit ef4cfca

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

.yarn/patches/@metamask-assets-controllers-npm-88.0.0-3dfc0ab8f1.patch

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,3 +46,16 @@ index 420934fb16ed6151b5b80fb7be04f81352b4aaf4..d735379adcaf77cbd46b4659f9bfd320
4646
}
4747
}
4848
});
49+
diff --git a/dist/token-prices-service/codefi-v2.cjs b/dist/token-prices-service/codefi-v2.cjs
50+
index f3c24e32ab755ae5c00e7d439600c4bab1587c71..df2932739853ab963f41a1d1270b1a6769c0ce88 100644
51+
--- a/dist/token-prices-service/codefi-v2.cjs
52+
+++ b/dist/token-prices-service/codefi-v2.cjs
53+
@@ -98,6 +98,8 @@ exports.SUPPORTED_CURRENCIES = [
54+
'mxn',
55+
// Malaysian Ringgit
56+
'myr',
57+
+ // Monad
58+
+ 'mon',
59+
// Nigerian Naira
60+
'ngn',
61+
// Norwegian Krone

yarn.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5645,7 +5645,7 @@ __metadata:
56455645

56465646
"@metamask/assets-controllers@patch:@metamask/assets-controllers@npm%3A88.0.0#~/.yarn/patches/@metamask-assets-controllers-npm-88.0.0-3dfc0ab8f1.patch":
56475647
version: 88.0.0
5648-
resolution: "@metamask/assets-controllers@patch:@metamask/assets-controllers@npm%3A88.0.0#~/.yarn/patches/@metamask-assets-controllers-npm-88.0.0-3dfc0ab8f1.patch::version=88.0.0&hash=ab5ccb"
5648+
resolution: "@metamask/assets-controllers@patch:@metamask/assets-controllers@npm%3A88.0.0#~/.yarn/patches/@metamask-assets-controllers-npm-88.0.0-3dfc0ab8f1.patch::version=88.0.0&hash=323fbe"
56495649
dependencies:
56505650
"@ethereumjs/util": "npm:^9.1.0"
56515651
"@ethersproject/abi": "npm:^5.7.0"
@@ -5691,7 +5691,7 @@ __metadata:
56915691
"@metamask/snaps-controllers": ^14.0.0
56925692
"@metamask/transaction-controller": ^61.0.0
56935693
webextension-polyfill: ^0.10.0 || ^0.11.0 || ^0.12.0
5694-
checksum: 10/17587884760c7856d4459c2f60a1acff0d2430b4ae0f9710bff15076e7d21f726d2a1380781d427d32859f1e6e7568eda48e277093d3b85aaffab82021a14c0c
5694+
checksum: 10/d3e7c1d52fef37270c4060a0811cccb905a690cef1546c4713ede6d7a1e75c810c5efb71225092cfd8a3975676f2141a81b59456a6f2f41a160598565d36dfd8
56955695
languageName: node
56965696
linkType: hard
56975697

0 commit comments

Comments
 (0)