chore: confirmation routing improvement and cleanup #38933
Merged
+101
−954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (1 files, +18 -1)
✅ @MetaMask/confirmations (14 files, +40 -890)
👨🔧 @MetaMask/core-extension-ux (1 files, +18 -1)
🔐 @MetaMask/web3auth (1 files, +4 -0)
|
jpuri
force-pushed
the
confirm_cleanup
branch
from
f4651ce to
ed7ba6e
Compare
jpuri
added
the
no-changelog
Collaborator
Builds ready [70e6572]
UI Startup Metrics (1291 ± 106 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [a85aea0]
UI Startup Metrics (1244 ± 101 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
…k-extension into confirm_cleanup
Collaborator
Builds ready [93f25d1]
UI Startup Metrics (1275 ± 97 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Contributor
Author
|
@metamaskbot update-policies |
…k-extension into confirm_cleanup
Collaborator
|
No policy changes |
Collaborator
Builds ready [a0d7058]
UI Startup Metrics (1324 ± 104 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [ce4c94a]
UI Startup Metrics (1302 ± 99 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [e8f3314]
UI Startup Metrics (1273 ± 100 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [c406e66]
UI Startup Metrics (1246 ± 94 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
jpuri
commented
Jan 8, 2026
| if (!currentConfirmation) { | ||
| return null; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I found that reason for e2e breaking is that after removing the skeleton loaders from top level, footer was still rendered ion loading state and in e2e to check that page is loaded we check for footer buttons here. Adding this condition fixed the e2e.
Contributor
Builds ready [9e541bc]
UI Startup Metrics (1343 ± 111 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
matthewwalsh0
approved these changes
Jan 8, 2026
|
|
||
| const handleTabClick = useCallback( | ||
| (tabName: AccountOverviewTabKey) => { | ||
| setActiveTabKey(tabName); |
Member
There was a problem hiding this comment.
This is owned by wallet UX team so will defer to them to verify.
OGPoyraz
approved these changes
Jan 9, 2026
ccharly
approved these changes
Jan 9, 2026
Contributor
ccharly
left a comment
ccharly
left a comment
There was a problem hiding this comment.
LGTM for accounts:
ui/components/multichain/account-overview/account-overview-tabs.tsx
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Builds ready [4a53ceb]
UI Startup Metrics (1265 ± 124 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.15.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove confirm-transaction.** components which are no longer needed after confirmation re-design.
Changelog
CHANGELOG entry:
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6077
Manual testing steps
NA
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Streamlines confirmation flow and cleans up legacy routes/components.
confirm-transaction/*rendering with newConfirmcomponent; add explicit routes fordecrypt-message-requestandencryption-public-key-request; remove legacy confirm-transaction subpaths/constantsconfirm-transactioncomponents, switches, and related tests/snapshotsConfirmContext, navigate toDEFAULT_ROUTEand set Activity tab when a confirmation disappears;FooterandGasFeeTokenIconreturnnullwhen nocurrentConfirmationAccountOverviewTabscontrolled viaactiveTabKey, syncing withdefaultHomeActiveTabNameand clicksWritten by Cursor Bugbot for commit 4a53ceb. This will update automatically on new commits. Configure here.