feat: implement tx history for perps #39445
Open
+2,014
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/perps (15 files, +1903 -5)
|
Contributor
Builds ready [ea32709]
UI Startup Metrics (1301 ± 102 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
geositta
force-pushed
the
perps/tx-history
branch
from
ba8b5de to
911b4e3
Compare
Contributor
Builds ready [911b4e3]
UI Startup Metrics (1326 ± 100 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
geositta
force-pushed
the
perps/tx-history
branch
from
911b4e3 to
f47f8f3
Compare
geositta
force-pushed
the
perps/tx-history
branch
from
179e38e to
11c1595
Compare
Contributor
Builds ready [11c1595]
UI Startup Metrics (1290 ± 119 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [2d7d166]
UI Startup Metrics (1317 ± 117 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
geositta
force-pushed
the
perps/tx-history
branch
from
064e2e3 to
ede6099
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| return { | ||
| text: `${transaction.fill.realizedPnl.startsWith('-') ? '-' : '+'}$${transaction.fill.realizedPnl.replace(/^[+-]/u, '')}`, | ||
| color: getTransactionAmountColor(transaction.fill.realizedPnl), | ||
| }; |
There was a problem hiding this comment.
Color mismatch for positive PnL without prefix
Medium Severity
When realizedPnl lacks a sign prefix, the display text adds a '+' sign but getTransactionAmountColor returns neutral color instead of green. This creates inconsistent UI where a visibly positive amount displays in neutral color rather than success color. The funding transaction logic (lines 70-76) correctly handles this case inline but the PnL path delegates to a utility that expects prefixed values.
| > | ||
| {amountDisplay.text} | ||
| </Text> | ||
| </Box> |
There was a problem hiding this comment.
Missing timestamp display in transaction cards
Medium Severity
The TransactionCard comment states "amount + time on right" and the Box element is labeled "Right side: Amount and time", but only the amount is rendered. The timestamp field from PerpsTransaction is never displayed, leaving users unable to see when transactions occurred. Transaction history UIs require timestamps for users to understand temporal context.
Contributor
Builds ready [ede6099]
UI Startup Metrics (1398 ± 91 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gambinish
approved these changes
Feb 3, 2026
abretonc7s
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements transaction history UI for perpetual futures trading, enabling users to view and filter their trading activity.
Key changes:
Architecture:
Changelog
CHANGELOG entry: Implements transaction history UI for perps
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
perps_history.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Adds new perps activity route and new UI components/utilities for rendering and filtering transaction history; risk is mostly UI/UX regressions and navigation/i18n edge cases rather than core funds handling.
Overview
Adds perps transaction history UI, including a reusable
TransactionCard, aPerpsRecentActivitywidget on the perps tab (with “See All”), and a new fullPerpsActivityPageatPERPS_ACTIVITY_ROUTEwith type filtering and date-grouped sections.Introduces perps transaction types plus mock transaction data, and adds utilities for grouping/filtering transactions and selecting display colors; also expands perps i18n strings for new labels/statuses and updates tests/baselines accordingly.
Written by Cursor Bugbot for commit ede6099. This will update automatically on new commits. Configure here.