-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix: user-storage related E2Es mock setup #39632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (2 files, +35 -52)
🧪 @MetaMask/qa (1 files, +17 -0)
|
test/e2e/helpers/identity/user-storage/userStorageMockttpController.ts
Outdated
Show resolved
Hide resolved
Builds ready [19389d7]
UI Startup Metrics (1339 ± 134 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [6f37e58]
UI Startup Metrics (1389 ± 111 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [1552271]
UI Startup Metrics (1303 ± 96 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [dc6c3c0]
UI Startup Metrics (1322 ± 120 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [c2cde9d]
UI Startup Metrics (1346 ± 119 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [d9f63b0]
UI Startup Metrics (1304 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [d16a196]
UI Startup Metrics (1325 ± 125 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
| ) => { | ||
| // #region agent log | ||
| console.log(`[SYNC_DEBUG:onGet] path=${path}, url=${request.path}`); | ||
| // #endregion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug console.log statements accidentally committed
Low Severity
Multiple console.log statements with [SYNC_DEBUG:...] prefixes wrapped in // #region agent log comments have been added across several files. These appear to be temporary debugging statements used during development that were not removed before committing. The coding guidelines specify to remove console.logs before committing.
Additional Locations (2)
Builds ready [1165662]
UI Startup Metrics (1312 ± 124 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [83ac9d2]
UI Startup Metrics (1303 ± 104 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|


Description
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
No manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Changes are limited to E2E test helpers/mocks and add verbose logging plus more deterministic mock registration; main risk is noisier test output or masking duplicate handler issues.
Overview
Fixes E2E identity/user-storage mock initialization by always calling
UserStorageMockttpController.setupPathfor the key user-storage features (accounts, address book, wallets, groups), and ensuringmockIdentityServicesis awaited where used.Adds targeted
SYNC_DEBUGconsole logging inUserStorageMockttpController(onGet,onPut,setupPath) and in the home page account-sync polling loop to help diagnose flaky account-syncing/user-storage behavior during tests.Written by Cursor Bugbot for commit 83ac9d2. This will update automatically on new commits. Configure here.