-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat: added deeplinking to the NFT tab #39669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Builds ready [b620402]
UI Startup Metrics (1269 ± 116 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Prithpal-Sooriya
previously approved these changes
Jan 30, 2026
Contributor
Builds ready [19194c8]
UI Startup Metrics (1334 ± 120 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [25c560e]
UI Startup Metrics (1327 ± 128 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
sahar-fehri
approved these changes
Jan 30, 2026
Prithpal-Sooriya
approved these changes
Jan 30, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for deeplinking on the NFTs tab.
Changelog
CHANGELOG entry: added deeplinking to the NFT tab
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2570
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2026-01-30.at.11.56.27.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: adds a new deep-link route and i18n strings without changing existing routing logic or sensitive flows. Main risk is mismatched path/query behavior causing the deep link to land on the wrong tab.
Overview
Adds support for deeplinking to the NFTs tab by registering a new
/nftroute that redirects to the default account view withtab=nfts.Also introduces the localized title key
deepLink_theNFTsPagein bothenanden_GBmessage bundles.Written by Cursor Bugbot for commit 25c560e. This will update automatically on new commits. Configure here.