Skip to content

Conversation

@juanmigdr
Copy link
Member

@juanmigdr juanmigdr commented Jan 30, 2026

Description

Added support for deeplinking on the NFTs tab.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: added deeplinking to the NFT tab

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2570

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2026-01-30.at.11.56.27.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: adds a new deep-link route and i18n strings without changing existing routing logic or sensitive flows. Main risk is mismatched path/query behavior causing the deep link to land on the wrong tab.

Overview
Adds support for deeplinking to the NFTs tab by registering a new /nft route that redirects to the default account view with tab=nfts.

Also introduces the localized title key deepLink_theNFTsPage in both en and en_GB message bundles.

Written by Cursor Bugbot for commit 25c560e. This will update automatically on new commits. Configure here.

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 30, 2026

Builds ready [b620402]
UI Startup Metrics (1269 ± 116 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--12691000150511613421451
load--1085849134010911671254
domContentLoaded--1077842133110811551247
domInteractive--251487172273
firstPaint--2085912272381871093
backgroundConnect--21419326712222239
firstReactRender--1793861929
initialActions--105113
loadScripts--87965111131079561049
setupStore--1274151521
numNetworkReqs--221587171569
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--18971462246515019962161
load--1064924168414110781419
domContentLoaded--1047917167113810531410
domInteractive--3419149223394
firstPaint--194701478192229333
backgroundConnect--31928144931330392
firstReactRender--22154052434
initialActions--106112
loadScripts--81469114111268231151
setupStore--1554161828
numNetworkReqs--1195026155146240
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--84068011711038921046
load--69759599384746881
domContentLoaded--69159098783743870
domInteractive--2515101192281
firstPaint--1066035748140195
backgroundConnect--3819139234498
firstReactRender--15104151728
initialActions--104113
loadScripts--68858897882741864
setupStore--1162951225
numNetworkReqs--221585181573
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1287899209425714681809
load--71961911711167061036
domContentLoaded--71061411641166961029
domInteractive--3515177263599
firstPaint--148681040126175319
backgroundConnect--16613547158163343
firstReactRender--23173232530
initialActions--104111
loadScripts--70761211561146931020
setupStore--1251931417
numNetworkReqs--1244926059154251
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13861114186617814781825
load--1116962167212211851313
domContentLoaded--1115962167212211851313
domInteractive--71322644197139
firstPaint--------
backgroundConnect--57232694762182
firstReactRender--1294041214
initialActions--1028312
loadScripts--1090945164411111601275
setupStore--154215271054
numNetworkReqs--231285181977
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--26261869500760326824116
load--12661053249627112171773
domContentLoaded--12651052249527112171772
domInteractive--12837739116115393
firstPaint--------
backgroundConnect--2981151414285255953
firstReactRender--21146152325
initialActions--2035323
loadScripts--12081036246822911751720
setupStore--18112748212289640
numNetworkReqs--71362154490181
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16951387245919318192054
load--14561194188114015391715
domContentLoaded--14551188188114015391715
domInteractive--972922948133184
firstPaint--------
backgroundConnect--782719249133165
firstReactRender--14102421519
initialActions--103122
loadScripts--14071176177111414731604
setupStore--184246351197
numNetworkReqs--231283181879
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29722123447653632674065
load--16421237272836218082433
domContentLoaded--16421237272836218072433
domInteractive--11834686118109428
firstPaint--------
backgroundConnect--33412714072823101006
firstReactRender--22166772430
initialActions--203123
loadScripts--15771217271232617362317
setupStore--1647798231228776
numNetworkReqs--69381984286179
19--------
📊 Page Load Benchmark Results

Current Commit: b620402 | Date: 1/30/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±42ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 736ms (±38ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±10ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 42ms 1.03s 1.34s 1.08s 1.34s
domContentLoaded 736ms 38ms 714ms 993ms 755ms 993ms
firstPaint 79ms 10ms 60ms 160ms 88ms 160ms
firstContentfulPaint 79ms 10ms 60ms 160ms 88ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 675 Bytes (0.01%)

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 30, 2026

Builds ready [19194c8]
UI Startup Metrics (1334 ± 120 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13341087164112013991571
load--1136927143511612051390
domContentLoaded--1128923142911512011385
domInteractive--271786162573
firstPaint--1536436073193309
backgroundConnect--24022132915243270
firstReactRender--18103552028
initialActions--107113
loadScripts--90470712081169821157
setupStore--1252951521
numNetworkReqs--211579161567
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--22491470610190723104569
load--1068901175515711341424
domContentLoaded--1051896173615310901413
domInteractive--37172223334106
firstPaint--2406314602452321041
backgroundConnect--48426437474763971455
firstReactRender--23155872537
initialActions--104112
loadScripts--82666814571408571144
setupStore--1464251623
numNetworkReqs--1314726053156244
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--816676116583872963
load--67459496673725801
domContentLoaded--66959095773719797
domInteractive--251598172277
firstPaint--1065945562135229
backgroundConnect--3717109184673
firstReactRender--15103561729
initialActions--104111
loadScripts--66658894671717787
setupStore--1163751222
numNetworkReqs--221583181578
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1261850244629014261877
load--70961613091236961053
domContentLoaded--69960813011236811045
domInteractive--36182032835101
firstPaint--1446843080180321
backgroundConnect--15613073164156241
firstReactRender--23174042532
initialActions--103111
loadScripts--69660612921216791035
setupStore--1242241418
numNetworkReqs--1394730159166264
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15191198217518916311973
load--1226999182515113011455
domContentLoaded--1226999182515113011455
domInteractive--853423645107179
firstPaint--------
backgroundConnect--69272495093181
firstReactRender--14105371431
initialActions--102022
loadScripts--1191984179814412531380
setupStore--165221271146
numNetworkReqs--231284181979
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--25831747393237926833422
load--12681048203622212571778
domContentLoaded--12671048203622212541777
domInteractive--1263956493123379
firstPaint--------
backgroundConnect--3701141751314487985
firstReactRender--21147072227
initialActions--2031323
loadScripts--12031032180515512081589
setupStore--1318791175121580
numNetworkReqs--883525349110219
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16761391230018018121953
load--14251201172313115481659
domContentLoaded--14241201172313115471659
domInteractive--923323450132213
firstPaint--------
backgroundConnect--69261964391163
firstReactRender--14112631619
initialActions--103122
loadScripts--13851186166511514611616
setupStore--175186261350
numNetworkReqs--241297211886
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--311822059390110631824356
load--16971322773678316712586
domContentLoaded--16971321773678316702586
domInteractive--159341235200126725
firstPaint--------
backgroundConnect--3271141206250389991
firstReactRender--23164252531
initialActions--208123
loadScripts--16511279770777616302468
setupStore--15710769202181666
numNetworkReqs--78292304595197
19--------
📊 Page Load Benchmark Results

Current Commit: 19194c8 | Date: 1/30/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±36ms) 🟡 | historical mean value: 1.03s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 714ms (±35ms) 🟢 | historical mean value: 717ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±10ms) 🟢 | historical mean value: 76ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 36ms 1.00s 1.29s 1.05s 1.29s
domContentLoaded 714ms 35ms 696ms 974ms 740ms 974ms
firstPaint 75ms 10ms 56ms 152ms 84ms 152ms
firstContentfulPaint 75ms 10ms 56ms 152ms 84ms 152ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 675 Bytes (0.01%)

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 30, 2026

Builds ready [25c560e]
UI Startup Metrics (1327 ± 128 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13271044172512813901527
load--1137890150512212001335
domContentLoaded--1130888149812211931328
domInteractive--251686152367
firstPaint--159631182144195277
backgroundConnect--23021227710234250
firstReactRender--16112631824
initialActions--105113
loadScripts--91468012711219781117
setupStore--1263141520
numNetworkReqs--211584161569
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--19551593511938820112275
load--1080947167113610951431
domContentLoaded--1064933164813610691419
domInteractive--36181562633111
firstPaint--220701661229249389
backgroundConnect--3472881753163338465
firstReactRender--22154972440
initialActions--106113
loadScripts--82671213531258401156
setupStore--1577271724
numNetworkReqs--1285225752151244
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--823668113186871985
load--68559389775747818
domContentLoaded--68058989275742810
domInteractive--251692172179
firstPaint--975928345105192
backgroundConnect--38161372442101
firstReactRender--1593651726
initialActions--103111
loadScripts--67758788574740808
setupStore--1264161125
numNetworkReqs--221582181676
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1259897210624814561704
load--71060813241266981043
domContentLoaded--70060013171266861037
domInteractive--37172073037102
firstPaint--1436549083188292
backgroundConnect--16213035151162311
firstReactRender--22173632328
initialActions--102111
loadScripts--69759813101256841028
setupStore--1254141318
numNetworkReqs--1295228059156260
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15041189232019015821944
load--12121025199717112541641
domContentLoaded--12111025199717112531641
domInteractive--783521743102166
firstPaint--------
backgroundConnect--64222294377164
firstReactRender--14105671422
initialActions--103123
loadScripts--11791007195216212011521
setupStore--186249331173
numNetworkReqs--231285181879
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--26551847461554927594066
load--12761025237629012772035
domContentLoaded--12761024237629012762035
domInteractive--12736604116111429
firstPaint--------
backgroundConnect--37611417403584091370
firstReactRender--22147192331
initialActions--2038423
loadScripts--12111005223722512141765
setupStore--1447758194170676
numNetworkReqs--74382054196179
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16371364211118017671985
load--13971195171511914871614
domContentLoaded--13961195171511914861614
domInteractive--892834252130195
firstPaint--------
backgroundConnect--71252224994180
firstReactRender--15115161521
initialActions--108122
loadScripts--13571177161010614311544
setupStore--2142634213154
numNetworkReqs--231287191883
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--29972098829876431954158
load--16201184259736918312501
domContentLoaded--16191184259736918312500
domInteractive--11630672122103463
firstPaint--------
backgroundConnect--36311042874943131093
firstReactRender--22155972430
initialActions--207123
loadScripts--15631166257233917492357
setupStore--1718787227261721
numNetworkReqs--73372874589178
19--------
📊 Page Load Benchmark Results

Current Commit: 25c560e | Date: 1/30/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±130ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 721ms (±127ms) 🟢 | historical mean value: 717ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 85ms (±111ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 130ms 998ms 2.29s 1.05s 2.29s
domContentLoaded 721ms 127ms 691ms 1.96s 738ms 1.96s
firstPaint 85ms 111ms 56ms 1.19s 88ms 1.19s
firstContentfulPaint 85ms 111ms 56ms 1.19s 88ms 1.19s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 675 Bytes (0.01%)

@juanmigdr juanmigdr added this pull request to the merge queue Jan 30, 2026
Merged via the queue into main with commit 912ca9e Jan 30, 2026
336 of 339 checks passed
@juanmigdr juanmigdr deleted the feat/nfts-deeplinking branch January 30, 2026 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2026
@metamaskbot metamaskbot added the release-13.18.0 Issue or pull request that will be included in release 13.18.0 label Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.18.0 Issue or pull request that will be included in release 13.18.0 size-S team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants