Commit 1d9312d
authored
feat(ramps): adopts new controller user region api interface (#24280)
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Description**
This PR adopts the breaking changes from `@metamask/ramps-controller`
v3.1.0, which refactors the controller to use "userRegion" terminology
instead of "geolocation" and introduces proper initialization patterns.
### **Reason for Change**
The ramps-controller package was refactored to:
1. **Improve naming clarity**: "geolocation" implies a read-only,
automatically-detected value, but we plan to allow users to manually
change their region. The new "userRegion" terminology better reflects
that it's a user-selectable region.
2. **Add proper initialization**: Previously, consumers had to manually
call `updateGeolocation()` after creating the controller, which was
error-prone. The new `init()` method encapsulates initialization logic
and automatically fetches the user region at startup.
3. **Enable manual region setting**: The new `setUserRegion()` method
allows users to manually set their region without calling the
geolocation API, preparing for future UI features.
### **Changes in This PR**
#### **Selectors** (`app/selectors/rampsController/index.ts`)
- ✅ Removed deprecated `selectGeolocation` selector
- ✅ Removed deprecated `selectGeolocationRequest` selector
- ✅ Added `selectUserRegion` selector (replaces `selectGeolocation`)
- ✅ Added `selectUserRegionRequest` selector (replaces
`selectGeolocationRequest`)
#### **Hooks** (`app/components/UI/Ramp/hooks/`)
- ✅ Renamed `useRampsGeolocation.ts` → `useRampsUserRegion.ts`
- ✅ Updated hook to use new `updateUserRegion()` and `setUserRegion()`
methods
- ✅ Updated hook to use new `selectUserRegion` and
`selectUserRegionRequest` selectors
- ✅ Updated all references and imports throughout the codebase
#### **Controller Initialization**
(`app/core/Engine/controllers/ramps-controller/ramps-controller-init.ts`)
- ✅ Updated to call `controller.init()` at startup (non-blocking)
- ✅ Initialization automatically fetches user region via geolocation API
- ✅ Errors are handled gracefully and available via selectors
#### **Tests**
- ✅ Updated `ramps-controller-init.test.ts` to test new `init()` method
- ✅ Updated `useRampsUserRegion.test.ts` to use new API and cache keys
- ✅ Updated selector tests to use `userRegion` state property
- ✅ All tests updated to use `'updateUserRegion'` cache key instead of
`'updateGeolocation'`
#### **Yarn Patch**
- ✅ Updated ramps-controller patch to include all local changes
(userRegion state, updateUserRegion, setUserRegion, init methods)
### **Migration Guide**
**Before:**
```ts
import { selectGeolocation, selectGeolocationRequest } from './selectors/rampsController';
import { useRampsGeolocation } from './hooks/useRampsGeolocation';
// Manual initialization required
Engine.context.RampsController.updateGeolocation();
```
**After:**
```ts
import { selectUserRegion, selectUserRegionRequest } from './selectors/rampsController';
import { useRampsUserRegion } from './hooks/useRampsUserRegion';
// Automatic initialization via controller.init() in ramps-controller-init.ts
```
### **Breaking Changes Adopted**
- ❌ `geolocation` state property → ✅ `userRegion`
- ❌ `updateGeolocation()` method → ✅ `updateUserRegion()`
- ❌ `selectGeolocation` selector → ✅ `selectUserRegion`
- ❌ `selectGeolocationRequest` selector → ✅ `selectUserRegionRequest`
- ❌ `useRampsGeolocation()` hook → ✅ `useRampsUserRegion()`
### **Related PRs**
- Core package PR:
[MetaMask/core#7563](MetaMask/core#7563) -
Refactors ramps-controller to use userRegion terminology and adds init()
method
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: Adopted new ramp controller variable names
## **Related issues**
Fixes:
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> Adopts the new `@metamask/ramps-controller` v3 APIs and init model.
>
> - Migrate from `geolocation` to `userRegion`: new `useRampsUserRegion`
hook (with `fetchUserRegion` and `setUserRegion`), selectors
`selectUserRegion`/`selectUserRegionRequest` (retain `selectGeolocation`
aliases); update `useRampsGeolocation` to call `updateUserRegion`
> - Initialize controller via `controller.init()` at startup
(`ramps-controller-init`), replacing `updateGeolocation` side-effect
> - Refactor ramps service init: derive environment via
`getRampsEnvironment` and platform context via `getRampsContext` (uses
`Platform.OS`)
> - Update fixtures, snapshots, and tests accordingly (new request keys
`updateUserRegion:[]`, added `eligibility`/`tokens` fields)
> - Bump dependency to `@metamask/ramps-controller@^3.0.0`
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
c99674b. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 42a758f commit 1d9312d
File tree
15 files changed
+891
-115
lines changed- app
- components/UI/Ramp/hooks
- core/Engine
- controllers/ramps-controller
- selectors/rampsController
- util
- logs/__snapshots__
- test
15 files changed
+891
-115
lines changedLines changed: 299 additions & 23 deletions
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
51 | 54 | | |
52 | 55 | | |
53 | 56 | | |
54 | | - | |
| 57 | + | |
55 | 58 | | |
56 | 59 | | |
57 | 60 | | |
| |||
69 | 72 | | |
70 | 73 | | |
71 | 74 | | |
| 75 | + | |
| 76 | + | |
72 | 77 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
278 | 278 | | |
279 | 279 | | |
280 | 280 | | |
| 281 | + | |
281 | 282 | | |
282 | 283 | | |
283 | 284 | | |
| |||
0 commit comments