Skip to content

Commit 54365c8

Browse files
authored
feat: MUSD-352 replace boost with bonus globally for conversion flows (#26453)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR updates copy for the mUSD conversion flow. All occurrences of `"boost"` have been replaced with `"bonus"`. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: updated mUSD conversion flow copy to replace boost with bonus ## **Related issues** Fixes: [MUSD-352: Replace "Boost" with "Bonus" Globally](https://consensyssoftware.atlassian.net/browse/MUSD-352) ## **Manual testing steps** ```gherkin Feature: mUSD conversion bonus terminology Scenario: user sees mUSD conversion incentive wording Given user is viewing mUSD conversion entry points in the Earn flow When user views the conversion CTA and quick convert balance card Then the incentive is labeled as a "bonus" (not "boost") ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk copy-only change, but it renames i18n keys; any missed references would surface as missing localized strings at runtime. > > **Overview** > Replaces **“boost”** wording with **“bonus”** across the mUSD conversion entry points (asset overview CTA and quick convert balance card), including MetaMetrics `cta_text` generation. > > Renames the associated localization keys (e.g., `boost_title/description`, `percentage_boost` → `bonus_title/description`, `percentage_bonus`) across supported languages and updates affected unit/view tests accordingly. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit ff9faa7. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent a6f7d4f commit 54365c8

File tree

20 files changed

+42
-43
lines changed

20 files changed

+42
-43
lines changed

app/components/UI/Earn/Views/MusdQuickConvertView/components/MusdBalanceCard/MusdBalanceCard.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,15 @@ describe('MusdBalanceCard', () => {
5454
expect(getByText(MUSD_TOKEN.symbol)).toBeOnTheScreen();
5555
});
5656

57-
it('displays percentage boost text from localization', () => {
57+
it('displays percentage bonus text from localization', () => {
5858
const { getByText } = renderWithProvider(
5959
<MusdBalanceCard chainId={CHAIN_IDS.MAINNET} balance="$100.00" />,
6060
{
6161
state: initialRootState,
6262
},
6363
);
6464

65-
expect(getByText('3% boost')).toBeOnTheScreen();
65+
expect(getByText('3% bonus')).toBeOnTheScreen();
6666
});
6767
});
6868
});

app/components/UI/Earn/Views/MusdQuickConvertView/components/MusdBalanceCard/MusdBalanceCard.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ const MusdBalanceCard = ({ chainId, balance }: MusdBalanceCardProps) => {
7171

7272
<View style={styles.right}>
7373
<Text variant={TextVariant.BodyMDMedium} color={TextColor.Success}>
74-
{strings('earn.musd_conversion.percentage_boost', {
74+
{strings('earn.musd_conversion.percentage_bonus', {
7575
percentage: MUSD_CONVERSION_APY,
7676
})}
7777
</Text>

app/components/UI/Earn/components/Musd/MusdConversionAssetOverviewCta/MusdConversionAssetOverviewCta.test.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ describe('MusdConversionAssetOverviewCta', () => {
435435
});
436436

437437
// Assert
438-
const expectedCtaText = strings('earn.musd_conversion.boost_title', {
438+
const expectedCtaText = strings('earn.musd_conversion.bonus_title', {
439439
percentage: MUSD_CONVERSION_APY,
440440
});
441441

@@ -484,7 +484,7 @@ describe('MusdConversionAssetOverviewCta', () => {
484484
});
485485

486486
// Assert
487-
const expectedCtaText = strings('earn.musd_conversion.boost_title', {
487+
const expectedCtaText = strings('earn.musd_conversion.bonus_title', {
488488
percentage: MUSD_CONVERSION_APY,
489489
});
490490

@@ -534,7 +534,7 @@ describe('MusdConversionAssetOverviewCta', () => {
534534
});
535535

536536
// Assert
537-
const expectedCtaText = strings('earn.musd_conversion.boost_title', {
537+
const expectedCtaText = strings('earn.musd_conversion.bonus_title', {
538538
percentage: MUSD_CONVERSION_APY,
539539
});
540540

app/components/UI/Earn/components/Musd/MusdConversionAssetOverviewCta/MusdConversionAssetOverviewCta.view.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,7 @@ describeForPlatforms('MusdConversionAssetOverviewCta', () => {
474474
).toBeOnTheScreen();
475475
});
476476

477-
it('renders CTA with correct boost title text', () => {
477+
it('renders CTA with correct bonus title text', () => {
478478
// Arrange
479479
const state = initialStateWallet()
480480
.withMinimalMultichainAssets()
@@ -507,7 +507,7 @@ describeForPlatforms('MusdConversionAssetOverviewCta', () => {
507507
).toBeOnTheScreen();
508508
});
509509

510-
it('renders CTA with correct boost description text', () => {
510+
it('renders CTA with correct bonus description text', () => {
511511
// Arrange
512512
const state = initialStateWallet()
513513
.withMinimalMultichainAssets()

app/components/UI/Earn/components/Musd/MusdConversionAssetOverviewCta/index.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ const MusdConversionAssetOverviewCta = ({
5353
const submitCtaPressedEvent = () => {
5454
const { EVENT_LOCATIONS, MUSD_CTA_TYPES } = MUSD_EVENTS_CONSTANTS;
5555

56-
const ctaText = strings('earn.musd_conversion.boost_title', {
56+
const ctaText = strings('earn.musd_conversion.bonus_title', {
5757
percentage: MUSD_CONVERSION_APY,
5858
});
5959

@@ -116,12 +116,12 @@ const MusdConversionAssetOverviewCta = ({
116116
{/* Text content in the center */}
117117
<View style={styles.textContainer}>
118118
<Text variant={TextVariant.BodySMMedium} style={styles.title}>
119-
{strings('earn.musd_conversion.boost_title', {
119+
{strings('earn.musd_conversion.bonus_title', {
120120
percentage: MUSD_CONVERSION_APY,
121121
})}
122122
</Text>
123123
<Text variant={TextVariant.BodySMMedium} color={TextColor.Alternative}>
124-
{strings('earn.musd_conversion.boost_description', {
124+
{strings('earn.musd_conversion.bonus_description', {
125125
percentage: MUSD_CONVERSION_APY,
126126
})}
127127
</Text>

locales/languages/de.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5931,8 +5931,8 @@
59315931
},
59325932
"buy_musd": "mUSD kaufen",
59335933
"get_musd": "mUSD erhalten",
5934-
"boost_title": "Erhalten Sie {{percentage}} % auf Ihre Stablecoins",
5935-
"boost_description": "Konvertieren Sie Ihre Stablecoins in mUSD und sichern Sie sich einen Bonus von bis zu {{percentage}} %.",
5934+
"bonus_title": "Erhalten Sie {{percentage}} % auf Ihre Stablecoins",
5935+
"bonus_description": "Konvertieren Sie Ihre Stablecoins in mUSD und sichern Sie sich einen Bonus von bis zu {{percentage}} %.",
59365936
"powered_by_relay": "Unterstützt von Relay"
59375937
},
59385938
"bonus_claim": {

locales/languages/el.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5931,8 +5931,8 @@
59315931
},
59325932
"buy_musd": "Αγοράστε mUSD",
59335933
"get_musd": "Αποκτήστε mUSD",
5934-
"boost_title": "Λάβετε {{percentage}}% σε stablecoins",
5935-
"boost_description": "Μετατρέψτε τα stablecoins σε mUSD και λάβετε μπόνους έως και {{percentage}}%.",
5934+
"bonus_title": "Λάβετε {{percentage}}% σε stablecoins",
5935+
"bonus_description": "Μετατρέψτε τα stablecoins σε mUSD και λάβετε μπόνους έως και {{percentage}}%.",
59365936
"powered_by_relay": "Υποστηρίζεται από το Relay"
59375937
},
59385938
"bonus_claim": {

locales/languages/en.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6006,7 +6006,6 @@
60066006
"ok": "OK",
60076007
"continue": "Continue",
60086008
"convert_and_get_percentage_bonus": "Convert and get {{percentage}}%",
6009-
"no_boost": "No boost",
60106009
"your_musd": "Your mUSD",
60116010
"balance_breakdown_title": "Your mUSD balances by network",
60126011
"balance_amount": "{{amount}} mUSD",
@@ -6036,8 +6035,8 @@
60366035
},
60376036
"buy_musd": "Buy mUSD",
60386037
"get_musd": "Get mUSD",
6039-
"boost_title": "Get {{percentage}}% on your stablecoins",
6040-
"boost_description": "Convert your stablecoins to mUSD and receive up to a {{percentage}}% bonus.",
6038+
"bonus_title": "Get {{percentage}}% on your stablecoins",
6039+
"bonus_description": "Convert your stablecoins to mUSD and receive up to a {{percentage}}% bonus.",
60416040
"powered_by_relay": "Powered by Relay",
60426041
"max": "Max",
60436042
"quick_convert_button": "Convert",
@@ -6053,7 +6052,7 @@
60536052
"title": "Convert max"
60546053
}
60556054
},
6056-
"percentage_boost": "{{percentage}}% boost",
6055+
"percentage_bonus": "{{percentage}}% bonus",
60576056
"rate": "Rate"
60586057
},
60596058
"bonus_claim": {

locales/languages/es.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5931,8 +5931,8 @@
59315931
},
59325932
"buy_musd": "Comprar mUSD",
59335933
"get_musd": "Obtener USDC",
5934-
"boost_title": "Obtén un {{percentage}} % en tus monedas estables",
5935-
"boost_description": "Convierte tus monedas estables a mUSD y recibe un bono de hasta el {{percentage}} %.",
5934+
"bonus_title": "Obtén un {{percentage}} % en tus monedas estables",
5935+
"bonus_description": "Convierte tus monedas estables a mUSD y recibe un bono de hasta el {{percentage}} %.",
59365936
"powered_by_relay": "Desarrollado por Relay"
59375937
},
59385938
"bonus_claim": {

locales/languages/fr.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5931,8 +5931,8 @@
59315931
},
59325932
"buy_musd": "Acheter des mUSD",
59335933
"get_musd": "Obtenir des mUSD",
5934-
"boost_title": "Obtenez {{percentage}} % sur vos stablecoins",
5935-
"boost_description": "Convertissez vos stablecoins en mUSD et recevez jusqu’à {{percentage}} % de bonus.",
5934+
"bonus_title": "Obtenez {{percentage}} % sur vos stablecoins",
5935+
"bonus_description": "Convertissez vos stablecoins en mUSD et recevez jusqu’à {{percentage}} % de bonus.",
59365936
"powered_by_relay": "Propulsé par Relay"
59375937
},
59385938
"bonus_claim": {

0 commit comments

Comments
 (0)