Merge branch 'main' into release/7.58.0

Author: sethkfman

.claude/commands/commit.md

@@ -0,0 +1,111 @@
+# PR Commit Agent
+
+**Goal**: Create conventional commits with automated feedback loop for pre-commit hook failures.
+
+## Core Principles
+
+All commits must: Follow conventional commit format • Pass pre-commit hooks • Be descriptive and specific • Use automated fixes when possible
+
+## Workflow
+
+```bash
+# 1. Analyze staged changes
+git diff --cached --name-only && git diff --cached
+
+# 2. Generate & execute commit
+git commit -m "<type>[optional scope]: <description>"
+
+# 3. If pre-commit fails → Fix issues → Re-stage → Re-commit
+yarn lint-staged && git add <files> && git commit -m "<message>"
+```
+
+## Decision Tree
+
+```mermaid
+flowchart TD
+    A[Start] --> B[Analyze staged files]
+    B --> C[Generate conventional commit message]
+    C --> D[Execute commit]
+    D --> E{Pre-commit Hooks Pass?}
+    E -->|Yes| F[Success]
+    E -->|No| G[Fix ALL issues automatically]
+    G --> H[Re-stage modified files]
+    H --> D
+```
+
+## Conventional Commit Format
+
+**Structure**: `<type>[optional scope]: <description>`
+
+**Types**: feat|fix|docs|style|refactor|test|chore|perf|ci|build|revert
+
+**Examples**:
+
+```bash
+# ✅ Good
+feat: add NFT gallery to collectibles tab
+fix: resolve wallet connection timeout on cold start
+refactor: extract transaction formatter into utility
+test: add e2e spec for onboarding SRP import flow
+docs: update contributing guide with design-system usage
+chore: bump react-native to 0.74.5
+
+# ❌ Bad (too vague, not imperative, or abbreviated)
+Add some stuff
+fixing bug
+refactor code
+tests
+update docs
+upgrade rn
+```
+
+## Quality Standards
+
+**Type Selection**:
+
+- ✅ `feat: add user authentication` ❌ `chore: add user authentication`
+- ✅ `fix: resolve memory leak` ❌ `docs: resolve memory leak`
+
+**Description Quality**:
+
+- ✅ Specific: "add NFT gallery to collectibles tab"
+- ❌ Vague: "add stuff" or "fix bug"
+
+**Scope Usage** (optional but useful):
+
+- ✅ `fix(wallet): resolve connection timeout` - scope clarifies which feature area
+- ✅ `feat: add user onboarding flow` - no scope fine when spanning multiple areas
+- ❌ `feat(app): add NFT gallery` - "app" too generic, use specific area like "collectibles"
+
+## Handling Pre-commit Hook Failures
+
+**Common Issues & Fixes**:
+
+- Lint-staged failures → `yarn lint-staged`
+- TypeScript errors → Fix type issues manually → `yarn lint:tsc`
+- Formatting issues → Auto-fixed by lint-staged
+- Import issues → `yarn eslint --fix <file>`
+
+**Auto-fix Loop**:
+
+```bash
+yarn lint-staged              # Fix all auto-fixable issues
+git add <modified-files>      # Re-stage fixed files
+git commit -m "<message>"     # Re-run commit
+```
+
+## Quick Commands
+
+```bash
+git diff --cached --name-only                            # Check staged files
+git diff --cached                                        # See staged changes
+git commit -m "<type>[scope]: <description>"             # Commit
+yarn lint-staged                                         # Fix lint issues
+git add <files>                                          # Re-stage files
+```
+
+## Success Metrics
+
+Conventional format • Pre-commit hooks pass • No lint/format errors • Descriptive message
+
+**Remember**: Fix all pre-commit hook issues automatically. Never skip hooks.

.claude/commands/generate-claude-rules.md

@@ -0,0 +1,76 @@
+## Overview
+
+Generate CLAUDE.md by dynamically aggregating all rules from `.cursor/rules/` directory. Works regardless of which rules exist or are added/removed.
+
+## Steps
+
+1. **Discover all rule files**
+
+   - Scan `.cursor/rules/` for all `.mdc` files
+   - Extract title/name from each file (frontmatter or first heading)
+   - Identify main sections and guidelines
+
+2. **Analyze content dynamically**
+
+   - Extract core content (skip frontmatter)
+   - Identify overlapping sections and consolidate
+   - Determine logical organization based on content
+   - Group related content semantically
+
+3. **Generate structure**
+
+   - Create table of contents from discovered content
+   - Organize into logical sections based on analysis
+   - Use rule file names/titles as section headers
+
+4. **Consolidate content**
+
+   - Merge all rules into appropriate sections
+   - Remove duplicates automatically
+   - Preserve formatting, examples, code blocks
+   - Keep all enforcement rules
+   - Maintain unique content from each file
+
+5. **Handle CLAUDE.md existence**
+   - If no file: Create new with consolidated content
+   - If exists: Prompt user:
+     ```
+     CLAUDE.md exists. Choose:
+     1. Replace - Overwrite with new consolidated content
+     2. Merge - Combine existing content with new rules
+     ```
+   - Ensure proper markdown formatting
+   - Maintain single source of truth
+
+## Checklist
+
+- [ ] All `.cursor/rules/` files analyzed
+- [ ] Structure planned and overlaps identified
+- [ ] CLAUDE.md existence checked
+- [ ] User preference obtained (if file exists)
+- [ ] CLAUDE.md created/updated with all content
+- [ ] Formatting, examples, enforcement preserved
+- [ ] Table of contents updated
+- [ ] Single source of truth maintained
+
+## Dynamic Organization
+
+1. **Analyze each file**: Extract headings, identify themes, determine logical flow
+2. **Create adaptive sections**: Use file names as headers, group related content, preserve hierarchy
+3. **Handle consolidation**: Merge duplicates, preserve unique content, keep original formatting
+4. **Generate TOC**: Based on discovered structure, ensure proper linking
+
+## File Existence Handling
+
+**No CLAUDE.md**: Create new file (no user interaction)
+
+**CLAUDE.md exists**: Prompt user → "Replace" (overwrite) or "Merge" (combine)
+
+## Success Criteria
+
+- CLAUDE.md contains all rules from `.cursor/rules/`
+- Well-organized and easy to navigate
+- All formatting preserved
+- Duplicates consolidated
+- Works with any number of rule files (0 to N)
+- New rules auto-included, removed rules auto-excluded

.claude/commands/lint-staged.md

@@ -0,0 +1,17 @@
+# PR Lint-Staged Agent
+
+**Goal**: Fix all linting and formatting issues on staged files with automated feedback loop.
+
+## Core Principles
+
+All staged files must: Pass lint-staged • Follow project standards • Use auto-fix when possible • No manual intervention required
+
+## Workflow
+
+```bash
+# 1. Run lint-staged
+yarn lint-staged
+
+# 2. If errors → Fix automatically → Re-run
+# 3. Repeat until all issues resolved
+```

.claude/commands/unit-test-coverage.md

@@ -46,22 +46,24 @@ cat scripts/reports/coverage-report-*.json | jq '.failedTests'
 
 ## Decision Tree
 
-```
-Start → Load & Confirm Guidelines
-  ↓
-Run coverage:analyze
-  ↓
-[Failed Tests?] ──Yes──→ Fix ALL broken tests first
-  ↓ No                          ↓
-  ↓                       Re-run coverage:analyze
-  ↓                              ↓
-[newCodeCoverage < 80%?] ←──────┘
-  ↓ Yes
-[Can improve existing tests?] ──Yes──→ Add assertions to existing tests
-  ↓ No                                            ↓
-Create minimal new tests                    Re-run coverage:analyze
-  ↓                                              ↓
-[Coverage Met] → Success ←──────────────────────┘
+```mermaid
+flowchart TD
+    A[Start] --> B[Load and Confirm Guidelines]
+    B --> C[Run coverage:analyze]
+    C --> D{Failed Tests?}
+    D -->|Yes| E[Fix ALL broken tests first]
+    E --> F[Re-run coverage:analyze]
+    F --> D
+    D -->|No| G{newCodeCoverage less than 80%?}
+    G -->|No| H[Success]
+    G -->|Yes| I{Can improve existing tests?}
+    I -->|Yes| J[Add assertions to existing tests]
+    I -->|No| K[Create minimal new tests]
+    J --> L[Re-run coverage:analyze]
+    K --> L
+    L --> M{Coverage Met?}
+    M -->|No| I
+    M -->|Yes| H
 ```
 
 ## Handling Failed Tests (Priority #1)

.claude/commands/unit-test.md

@@ -0,0 +1,54 @@
+# Unit Test Runner
+
+**Goal**: Run unit tests for all changed files and their related test files.
+
+## Steps
+
+1. **Get changed files**
+
+   - Run `git diff --name-only --diff-filter=ACMR` for all changes (staged + unstaged)
+   - Filter for `.js`, `.jsx`, `.ts`, `.tsx` files
+   - Display list
+
+2. **Find test files**
+
+   - Check if file is already a test file (contains `.test.`)
+   - For source files, find related tests: `{basename}.test.{ext}`
+   - Exclude snapshots (`.snap`)
+   - Collect unique test files
+
+3. **Run tests**
+
+   - Execute `yarn jest` with all found test files
+   - Run without coverage
+   - Capture results
+
+4. **Report & fix**
+   - Show pass/fail summary
+   - If failures: Analyze → Fix issues → Re-run tests
+   - Continue until all pass
+
+## Checklist
+
+- [ ] Changed files identified
+- [ ] Test files found
+- [ ] Tests executed
+- [ ] All tests pass
+- [ ] Issues fixed and re-tested if needed
+
+## Failure Actions
+
+1. Analyze failures → Isolate issues → Fix (implementation/mocks/tests) → Re-run → Repeat until pass
+
+## Quick Commands
+
+```bash
+yarn jest <filename>                         # Run test file
+yarn jest <filename> -t "test name"          # Run specific test by name
+yarn jest <filename> --no-coverage           # Faster execution (skip coverage)
+yarn jest <filename> --verbose               # Detailed output for debugging
+```
+
+## Success Criteria
+
+All tests pass • No errors/timeouts • All changed files tested

.cursor/rules/general-coding-guidelines.mdc

@@ -0,0 +1,47 @@
+---
+globs: "**/*"
+alwaysApply: true
+---
+
+# General Coding Guidelines
+
+## Required Reading Before Development
+
+**ALWAYS** check: `.github/guidelines/CODING_GUIDELINES.md` • `README.md` • Relevant `/docs` before coding
+
+**Docs Structure**: `/docs/readme/` (core) • `/docs/` (features) • `README.md` (overview)
+
+## Development Workflow
+
+**Before Starting**: Read README.md → Check coding guidelines → Review relevant docs → Understand architecture
+
+**Code Quality**:
+- TypeScript guidelines from contributor docs • Functional components + hooks • PascalCase (components) / camelCase (functions)
+- Reusable components/utilities • TSDoc format • Comprehensive tests • Apply `.cursor/rules/unit-testing-guidelines.mdc`
+
+**File Organization**:
+```
+ComponentName/
+├── ComponentName.{constants,stories,styles,test,types}.ts(x)
+├── ComponentName.tsx
+├── README.md
+└── index.ts
+```
+
+## Documentation Quick Reference
+
+**Core**: `/docs/readme/` (architecture, testing, debugging, performance, environment, expo-environment, storybook, troubleshooting, expo-e2e-testing, reassure, release-build-profiler)
+
+**Features**: `/docs/` (deeplinks, animations, tailwind, confirmations, confirmation-refactoring) • `app/component-library/README.md` • `e2e/MOCKING.md` • `CHANGELOG.md` • `app/core/{Analytics,Engine}/README.md` • `ppom/README.md`
+
+**External**: [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) • [TypeScript Guidelines](https://github.com/MetaMask/contributor-docs/blob/main/docs/typescript.md) • [Unit Testing](https://github.com/MetaMask/contributor-docs/blob/main/docs/testing/unit-testing.md)
+
+## Enforcement (MANDATORY)
+
+**Documentation**: Read `.github/guidelines/`, `README.md`, and relevant `/docs` before implementing
+
+**Commands**: ONLY use `.claude/commands/` + yarn command
+
+**Testing**: see .claude/commands/unit-test.md
+
+**Forbidden**: ❌ npm/npx commands