Skip to content

Commit 5d03d06

Browse files
temp+fix: cp-7.60.1 bump bitcoin (#23488)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Updates bitcoin to 1.8.0, which removes onRpcRequest method. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Removed `onRpcRequest` ([#568](MetaMask/snap-bitcoin-wallet#568)) ## **Related issues** Fixes: Remove `onRpcRequest`. ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Upgrade @metamask/bitcoin-wallet-snap from ^1.7.0 to ^1.8.0. > > - **Dependencies**: > - Upgrade `@metamask/bitcoin-wallet-snap` to `^1.8.0` in `package.json`. > - Update `yarn.lock` to reflect the new version. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 6b5cf54. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 59cf97b commit 5d03d06

File tree

1,442 files changed

+49218
-125720
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,442 files changed

+49218
-125720
lines changed

.cursor/BUGBOT.md

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,10 @@ Automated test quality enforcement and bug detection for MetaMask Mobile React N
66

77
## Execution Protocol
88

9-
### 1. Initial Setup - Unit Tests
9+
### 1. Initial Setup
1010

1111
- **ALWAYS** load and reference [unit testing guidelines](rules/unit-testing-guidelines.mdc)
1212
- Verify test file naming pattern: `*.test.{ts,tsx,js,jsx}`
1313
- Check for proper Jest/React Native Testing Library imports
1414

15-
Use the rules in the [unit testing guidelines](rules/unit-testing-guidelines.mdc) to enforce the test quality and bug detection.
16-
17-
### 2. Initial Setup - E2E Tests
18-
19-
- **ALWAYS** load and reference [e2e-testing-guidelines](rules/e2e-testing-guidelines.mdc)
20-
- Verify test file naming pattern: `e2e/specs/**/*.spec.{js,ts}`
21-
- Check for proper imports and framework utilities from `e2e/framework/index.ts`
22-
23-
Use the rules in the [e2e-testing-guidelines](rules/e2e-testing-guidelines.mdc) to enforce the test quality and bug detection.
15+
Use the rules in the[unit testing guidelines](rules/unit-testing-guidelines.mdc) to enforce the test quality and bug detection.

.cursor/rules/component-view-testing.mdc

Lines changed: 0 additions & 43 deletions
This file was deleted.

.cursor/rules/pr-creation-guidelines.mdc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ Use `.github/pull-request-template.md` - fill ALL sections:
8888
- Labels applied
8989
- Target `main` branch
9090
- Keep focused (single feature/fix)
91-
- Include tests (unit/Component-view/e2e)
91+
- Include tests (unit/integration/e2e)
9292
- Update TSDoc when relevant
9393

9494
**⚠️ Force Push Policy**:

.eslintrc.js

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* eslint-disable import/no-commonjs */
1+
// eslint-disable-next-line import/no-commonjs
22
module.exports = {
33
root: true,
44
parser: '@typescript-eslint/parser',
@@ -147,20 +147,6 @@ module.exports = {
147147
},
148148
},
149149
},
150-
{
151-
files: ['**/*.view.test.{js,ts,tsx,jsx}'],
152-
rules: {
153-
'no-restricted-syntax': [
154-
'error',
155-
{
156-
selector:
157-
"CallExpression[callee.object.name='jest'][callee.property.name='mock'][arguments.0.type='Literal'][arguments.0.value!='../../../core/Engine'][arguments.0.value!='../../../core/Engine/Engine'][arguments.0.value!='react-native-device-info']",
158-
message:
159-
'Only Engine and react-native-device-info can be mocked in component-view tests.',
160-
},
161-
],
162-
},
163-
},
164150
],
165151

166152
globals: {

.github/CODEOWNERS

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ app/core/Engine/controllers/remote-feature-flag-controller/ @MetaMask/mobile-pla
4343
app/core/DeeplinkManager @MetaMask/mobile-platform
4444
scripts/build.sh @MetaMask/mobile-platform
4545
scripts/update-expo-channel.js @MetaMask/mobile-admins
46-
certs/certificate.pem @MetaMask/mobile-admins
4746

4847
# Platform & Snaps Code Fencing File
4948
metro.transform.js @MetaMask/mobile-platform @MetaMask/core-platform

.github/ISSUE_TEMPLATE/bug-report.yml

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -66,18 +66,10 @@ body:
6666
id: version
6767
attributes:
6868
label: Version
69-
description: What version of MetaMask are you running? You can find the version in "Settings" > "About MetaMask"
69+
description: What version of MetaMask are you running? You can find the version in "Settings" > "About"
7070
placeholder: "7.50.0"
7171
validations:
7272
required: true
73-
- type: input
74-
id: build-number
75-
attributes:
76-
label: Build number
77-
description: What build number of MetaMask are you running? You can find the build number in "Settings" > "About MetaMask"
78-
placeholder: "3055"
79-
validations:
80-
required: true
8173
- type: dropdown
8274
id: build
8375
attributes:

.github/actions/smart-e2e-selection/action.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,8 @@ runs:
4646
- name: Fetch base branch for comparison
4747
shell: bash
4848
run: |
49-
# Unshallow the repository first (if it's shallow)
50-
git fetch --unshallow 2>/dev/null || true
51-
# Then fetch base branch to ensure merge-base exists
52-
git fetch origin main 2>/dev/null || true
49+
# Fetch base branch with enough depth to compute merge base for git diff
50+
git fetch origin main --depth=100 2>/dev/null || git fetch origin master --depth=100 2>/dev/null || true
5351
5452
- name: Setup Node.js
5553
uses: actions/setup-node@v4

.github/cursorPrompts/issue-analysis.md

Lines changed: 0 additions & 8 deletions
This file was deleted.

.github/guidelines/LABELING_GUIDELINES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ The check can be bypassed when necessary, either by setting the changelog entry
1919

2020
Any label can be manually added on demand depending on the PR's content. For instance, the label **QA passed** will indicate that a thorough manual testing has been performed and the PR is ready to be merged. In addition, following labels have some specific use cases.
2121

22+
### Run Flask Android E2E tests
23+
24+
- **run-android-flask-e2e-smoke**: The Android Flask E2E smoke tests jobs will run in the given PR. They also run on schedule on main branch.
25+
2226
### Bypass Quality Gates
2327

2428
Using any of these labels should be exceptional in case of CI friction and urgencies. Please use them reasonably and verify new changes and regressions manually.
File renamed without changes.

0 commit comments

Comments
 (0)