Skip to content

Commit 5f1b837

Browse files
Battambanggrvgoel81
authored andcommitted
fix: cp-7.60.1 bump bitcoin (#23488)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Updates bitcoin to 1.8.0, which removes onRpcRequest method. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Removed `onRpcRequest` ([#568](MetaMask/snap-bitcoin-wallet#568)) ## **Related issues** Fixes: Remove `onRpcRequest`. ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Upgrade @metamask/bitcoin-wallet-snap from ^1.7.0 to ^1.8.0. > > - **Dependencies**: > - Upgrade `@metamask/bitcoin-wallet-snap` to `^1.8.0` in `package.json`. > - Update `yarn.lock` to reflect the new version. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 6b5cf54. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 1566f98 commit 5f1b837

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@
201201
"@metamask/approval-controller": "^8.0.0",
202202
"@metamask/assets-controllers": "patch:@metamask/assets-controllers@npm%3A91.0.0#~/.yarn/patches/@metamask-assets-controllers-npm-91.0.0-ea998cb0bd.patch",
203203
"@metamask/base-controller": "^9.0.0",
204-
"@metamask/bitcoin-wallet-snap": "^1.7.0",
204+
"@metamask/bitcoin-wallet-snap": "^1.8.0",
205205
"@metamask/bridge-controller": "^61.0.0",
206206
"@metamask/bridge-status-controller": "^61.0.0",
207207
"@metamask/chain-agnostic-permission": "^1.2.2",

yarn.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7624,10 +7624,10 @@ __metadata:
76247624
languageName: node
76257625
linkType: hard
76267626

7627-
"@metamask/bitcoin-wallet-snap@npm:^1.7.0":
7628-
version: 1.7.0
7629-
resolution: "@metamask/bitcoin-wallet-snap@npm:1.7.0"
7630-
checksum: 10/34943af054bdceeaf11ca6ed876f582194257c1bdc06e37cca06aabf650c6f541fe0f9bfaef07c8fe5e4179354f0ae81445194ce6c77a526f53221d3deb6a26c
7627+
"@metamask/bitcoin-wallet-snap@npm:^1.8.0":
7628+
version: 1.8.0
7629+
resolution: "@metamask/bitcoin-wallet-snap@npm:1.8.0"
7630+
checksum: 10/4a437b4efef2669970b60b8b8d579ed34ef677ca207313430924f4424aeb1e58a5601bae75a54744ba466fc1394f0d478e29fcbcf2cb7a5e73124316fb9a260a
76317631
languageName: node
76327632
linkType: hard
76337633

@@ -35946,7 +35946,7 @@ __metadata:
3594635946
"@metamask/assets-controllers": "patch:@metamask/assets-controllers@npm%3A91.0.0#~/.yarn/patches/@metamask-assets-controllers-npm-91.0.0-ea998cb0bd.patch"
3594735947
"@metamask/auto-changelog": "npm:^5.1.0"
3594835948
"@metamask/base-controller": "npm:^9.0.0"
35949-
"@metamask/bitcoin-wallet-snap": "npm:^1.7.0"
35949+
"@metamask/bitcoin-wallet-snap": "npm:^1.8.0"
3595035950
"@metamask/bridge-controller": "npm:^61.0.0"
3595135951
"@metamask/bridge-status-controller": "npm:^61.0.0"
3595235952
"@metamask/browser-passworder": "npm:^5.0.0"

0 commit comments

Comments
 (0)