-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit 62a7229
chore(runway): cherry-pick fix: cp-7.58.0 metamask pay transaction failures (#21349)
- fix: cp-7.58.0 metamask pay transaction failures (#21287)
## **Description**
Explicitly wait for confirmation of all required transactions when
bridging funds for MetaMask Pay.
Fix display of bridge receive line in transaction details summary.
## **Changelog**
CHANGELOG entry: null
## **Related issues**
## **Manual testing steps**
## **Screenshots/Recordings**
### **Before**
### **After**
## **Pre-merge author checklist**
- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> Waits for required bridge-related transactions to confirm before
proceeding and fixes bridge receive/send summary titles and chain
resolution.
>
> - **MetaMask Pay (hook)**:
> - Explicitly tracks and waits for required transactions to reach
`confirmed` via `TransactionController:getState` and `:stateChange`;
rejects on `dropped/failed` with error context.
> - Uses `BridgeStatusController:getState` for immediate bridge status
check; updates failure message to "Bridge failed".
> - Collects required tx IDs during submission and appends to
`requiredTransactionIds`.
> - **Messaging**:
> - Grants `TransactionController:getState` action and
`TransactionController:stateChange` event to init messenger.
> - **Activity summary (UI)**:
> - Resolves receive chain from `quote.destChainId` (not
`status.destChain.chainId`).
> - Splits loading titles into `bridge_send_loading` and
`bridge_receive_loading` and applies in summary rendering.
> - **Tests/Locales**:
> - Adds tests for required tx confirm/fail flows and updated loading
titles; adjusts mocks accordingly.
> - Updates `en.json` keys for send/receive loading titles.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
c5dfa17. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
[cf4df14](cf4df14)
Co-authored-by: Matthew Walsh <[email protected]>1 parent 6cad602 commit 62a7229Copy full SHA for 62a7229
File tree
Expand file treeCollapse file tree
0 file changed
+0
-0
lines changedOpen diff view settings
Filter options
Expand file treeCollapse file tree
0 file changed
+0
-0
lines changedOpen diff view settings
0 commit comments