Skip to content

Commit a9ef001

Browse files
chore(runway): cherry-pick fix: solana ws lifecycle (#18776)
- fix: cp-7.54.0 solana ws lifecycle (#18759) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR bumps the Solana snap. The latest version includes a fix on the WebSockets lifecycle. Before, we were opening connections all the time `onStart`/`onInstall`/`onUpdate`. Now we open them only if client is active. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [093c3ab](093c3ab) Co-authored-by: Xavier Brochard <[email protected]>
1 parent 147fedb commit a9ef001

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@
278278
"@metamask/snaps-rpc-methods": "^13.5.0",
279279
"@metamask/snaps-sdk": "^9.3.0",
280280
"@metamask/snaps-utils": "^11.4.0",
281-
"@metamask/solana-wallet-snap": "^2.1.4",
281+
"@metamask/solana-wallet-snap": "^2.3.2",
282282
"@metamask/solana-wallet-standard": "^0.5.1",
283283
"@metamask/stake-sdk": "^3.2.0",
284284
"@metamask/swappable-obj-proxy": "^2.1.0",

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6235,10 +6235,10 @@
62356235
ses "^1.12.0"
62366236
validate-npm-package-name "^5.0.0"
62376237

6238-
"@metamask/solana-wallet-snap@^2.1.4":
6239-
version "2.1.4"
6240-
resolved "https://registry.yarnpkg.com/@metamask/solana-wallet-snap/-/solana-wallet-snap-2.1.4.tgz#e935691c5cd9e13ec8c0600ad156ea6666f6c4ea"
6241-
integrity sha512-sbu+u5VQeUB0fwKZrz5zKd5lVJ4wiU1CyecDz5ykjlwuj1xcYzARyK4TBEdXMpvxScM0AlwvV+CIG3IY0Vztnw==
6238+
"@metamask/solana-wallet-snap@^2.3.2":
6239+
version "2.3.2"
6240+
resolved "https://registry.yarnpkg.com/@metamask/solana-wallet-snap/-/solana-wallet-snap-2.3.2.tgz#80fb0b198133837c8b5077b588bbee61ace411b7"
6241+
integrity sha512-RC+oSsr23Tes4TKNlEcHd1ZmsUbj1beOyhdz67W54D1yfXcByrzIaIYt6BdlenhBGDrZwYsht7a5LgKhxkcgXw==
62426242

62436243
"@metamask/solana-wallet-standard@^0.5.1":
62446244
version "0.5.1"

0 commit comments

Comments
 (0)