chore(runway): cherry-pick fix: cp-7.58.0 rewards settings change icon open modal (#21522)

- fix: cp-7.58.0 rewards settings change icon open modal (#21473)

## **Description**

Change icon to spawn account group modal in reward settings page to
details icon instead of QR.

## **Changelog**

CHANGELOG entry: null

## **Screenshots/Recordings**

### **After**

<img width="495" height="944" alt="image"

src="https://github.com/user-attachments/assets/12f7db40-34c5-4c14-a5de-177b05ccbb1a"
/>

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Replaces the QR code icon with the details icon to open the account
addresses modal and updates related tests/mocks, with a small try/catch
cleanup.
> 
> - **Rewards Settings UI**:
> - Change addresses action button icon from `IconNameDS.QrCode` to
`IconNameDS.Details` in `RewardSettingsAccountGroup.tsx`.
>   - Minor cleanup: simplify `catch {}` when selecting EVM address.
> - **Tests & Mocks**:
> - Update tests in `RewardSettingsAccountGroup.test.tsx` to reference
the addresses button (formerly QR) and expect navigation/disabled
states.
> - Adjust mocked `IconName` to include `Details` and remove `QrCode`
where used.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
4583764. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->


[38ccc8e](38ccc8e)

Co-authored-by: VGR <[email protected]>

Author: runway-github[bot]

app/components/UI/Rewards/components/Settings/RewardSettingsAccountGroup.test.tsx

@@ -169,7 +169,7 @@ jest.mock('@metamask/design-system-react-native', () => {
       Lg: 'lg',
     },
     IconName: {
-      QrCode: 'qr-code',
+      Details: 'details',
       Check: 'check',
       Add: 'add',
     },
@@ -254,7 +254,7 @@ jest.mock('../../../../../component-library/components/Icons/Icon', () => {
     __esModule: true,
     default: MockIcon,
     IconName: {
-      QrCode: 'qr-code',
+      Details: 'details',
       Check: 'check',
       Add: 'add',
     },
@@ -611,18 +611,18 @@ describe('RewardSettingsAccountGroup', () => {
       expect(mockLinkAccountGroup).toHaveBeenCalledWith(mockAccountGroup.id);
     });
 
-    it('should navigate to modal when QR button is pressed', () => {
+    it('navigates to modal when addresses button is pressed', () => {
       const { getByTestId } = render(
         <RewardSettingsAccountGroup
           item={mockItem}
           avatarAccountType={AvatarAccountType.Maskicon}
         />,
       );
 
-      const qrButton = getByTestId(
+      const addressesButton = getByTestId(
         `rewards-account-addresses-${mockAccountGroup.id}`,
       );
-      fireEvent.press(qrButton);
+      fireEvent.press(addressesButton);
 
       expect(mockNavigate).toHaveBeenCalledWith(
         'RewardOptInAccountGroupModal',
@@ -646,7 +646,7 @@ describe('RewardSettingsAccountGroup', () => {
       );
     });
 
-    it('should navigate to modal with unsupported accounts included in addressData', () => {
+    it('navigates to modal with unsupported accounts included in addressData', () => {
       const itemWithUnsupported: RewardSettingsAccountGroupListFlatListItem = {
         type: 'accountGroup',
         accountGroup: {
@@ -681,10 +681,10 @@ describe('RewardSettingsAccountGroup', () => {
         />,
       );
 
-      const qrButton = getByTestId(
+      const addressesButton = getByTestId(
         `rewards-account-addresses-${mockAccountGroup.id}`,
       );
-      fireEvent.press(qrButton);
+      fireEvent.press(addressesButton);
 
       expect(mockNavigate).toHaveBeenCalledWith(
         'RewardOptInAccountGroupModal',
@@ -1008,7 +1008,7 @@ describe('RewardSettingsAccountGroup', () => {
       ).toBeNull();
     });
 
-    it('should disable QR button when loading', () => {
+    it('disables addresses button when loading', () => {
       // Arrange
       mockUseLinkAccountGroup.mockReturnValue({
         linkAccountGroup: mockLinkAccountGroup,
@@ -1025,10 +1025,10 @@ describe('RewardSettingsAccountGroup', () => {
       );
 
       // Assert
-      const qrButton = getByTestId(
+      const addressesButton = getByTestId(
         `rewards-account-addresses-${mockAccountGroup.id}`,
       );
-      expect(qrButton).toHaveProp('disabled', true);
+      expect(addressesButton).toHaveProp('disabled', true);
     });
   });
 });

app/components/UI/Rewards/components/Settings/RewardSettingsAccountGroup.tsx

@@ -62,7 +62,7 @@ const RewardSettingsAccountGroup: React.FC<RewardSettingsAccountGroupProps> = ({
     try {
       const selector = selectIconSeedAddressByAccountGroupId(accountGroup.id);
       return selector(state);
-    } catch (error) {
+    } catch {
       return undefined;
     }
   });
@@ -204,9 +204,9 @@ const RewardSettingsAccountGroup: React.FC<RewardSettingsAccountGroupProps> = ({
           twClassName="gap-4"
           testID={`rewards-account-group-actions-${accountGroup.id}`}
         >
-          {/* QR Code button to show account addresses */}
+          {/* Menu button to show account addresses */}
           <ButtonIcon
-            iconName={IconNameDS.QrCode}
+            iconName={IconNameDS.Details}
             size={ButtonIconSize.Lg}
             onPress={handleShowAddresses}
             isDisabled={isLoading}