Skip to content

chore(runway): cherry-pick fix(ramps): cp-7.58.0 do not throw when user details fetch is 401 #21648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
+5 −6
Merged

chore(runway): cherry-pick fix(ramps): cp-7.58.0 do not throw when user details fetch is 401 #21648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions app/components/UI/Ramp/Deposit/hooks/useDepositUser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ describe('useDepositUser', () => {
expect(mockFetchUserDetails).toHaveBeenCalled();
});

it('logs out and throws on 401 error', async () => {
it('logs out but does not throw on 401 error', async () => {
const error401 = Object.assign(new Error('Unauthorized'), {
status: 401,
}) as AxiosError;
Expand All @@ -284,13 +284,11 @@ describe('useDepositUser', () => {
);

mockFetchUserDetails.mockRejectedValue(error401);
setupMockSdkMethod({ data: mockUserDetails });
setupMockSdkMethod();

const { result } = renderHook(() => useDepositUser());

await expect(result.current.fetchUserDetails()).rejects.toThrow(
'Unauthorized',
);
await result.current.fetchUserDetails();

expect(mockLogoutFromProvider).toHaveBeenCalledWith(false);
});
Expand Down
3 changes: 2 additions & 1 deletion app/components/UI/Ramp/Deposit/hooks/useDepositUser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ export function useDepositUser() {
if ((error as AxiosError).status === 401) {
Logger.log('useDepositUser: 401 error, clearing authentication');
await logoutFromProvider(false);
} else {
throw error;
}
throw error;
}
}, [fetchUserDetails, logoutFromProvider]);

Expand Down
Loading