pr comments

Author: chakra-guy

package.json

@@ -84,7 +84,6 @@
     "patch-package": "^6.4.7",
     "prettier": "^2.3.2",
     "rimraf": "^3.0.2",
-    "rollup-plugin-node-polyfills": "^0.2.1",
     "serve": "^14.2.1",
     "ts-jest": "^29.0.3",
     "typescript": "^4.3.5"

packages/sdk-communication-layer/src/types/TrackingEvent.ts

@@ -14,7 +14,4 @@ export enum TrackingEvents {
   SDK_RPC_REQUEST_DONE = 'sdk_rpc_request_done',
   SDK_EXTENSION_UTILIZED = 'sdk_extension_utilized',
   SDK_USE_INAPP_BROWSER = 'sdk_use_inapp_browser',
-  SDK_MODAL_VIEWED = 'sdk_modal_viewed',
-  SDK_MODAL_BUTTON_CLICKED = 'sdk_modal_button_clicked',
-  SDK_MODAL_TOGGLE_CHANGED = 'sdk_modal_toggle_changed',
 }

packages/sdk-install-modal-web/package.json

@@ -86,7 +86,6 @@
     }
   },
   "dependencies": {
-    "@metamask/sdk-communication-layer": "workspace:*",
     "@paulmillr/qr": "^0.2.1"
   }
 }

packages/sdk-install-modal-web/src/components.d.ts

@@ -5,8 +5,8 @@
  * It contains typing information for all components that exist in this project.
  */
 import { HTMLStencilElement, JSXBase } from "@stencil/core/internal";
-import { TrackingEvents } from "@metamask/sdk-communication-layer";
-export { TrackingEvents } from "@metamask/sdk-communication-layer";
+import { TrackingEvents } from "./components/misc/tracking-events";
+export { TrackingEvents } from "./components/misc/tracking-events";
 export namespace Components {
     interface MmInstallModal {
         /**

packages/sdk-install-modal-web/src/components/misc/tracking-events.ts

@@ -0,0 +1,5 @@
+export enum TrackingEvents {
+  SDK_MODAL_VIEWED = 'sdk_modal_viewed',
+  SDK_MODAL_BUTTON_CLICKED = 'sdk_modal_button_clicked',
+  SDK_MODAL_TOGGLE_CHANGED = 'sdk_modal_toggle_changed',
+}

packages/sdk-install-modal-web/src/components/mm-install-modal/mm-install-modal.tsx

@@ -10,7 +10,7 @@ import CloseButton from '../misc/CloseButton';
 import Logo from '../misc/Logo';
 import encodeQR from '@paulmillr/qr';
 import { SimpleI18n } from '../misc/simple-i18n';
-import { TrackingEvents } from '@metamask/sdk-communication-layer';
+import { TrackingEvents } from '../misc/tracking-events';
 
 @Component({
   tag: 'mm-install-modal',

packages/sdk-install-modal-web/stencil.config.ts

@@ -1,6 +1,5 @@
 import { Config } from '@stencil/core';
 import { visualizer } from 'rollup-plugin-visualizer';
-import nodePolyfills from 'rollup-plugin-node-polyfills';
 
 export const config: Config = {
   namespace: 'sdk-install-modal-web',
@@ -19,9 +18,6 @@ export const config: Config = {
   testing: {
     browserHeadless: "new",
   },
-  plugins: [
-    nodePolyfills(),
-  ],
   rollupPlugins: {
     after: [
       process.env.NODE_ENV === 'development' ? visualizer() : null

packages/sdk/package.json

@@ -134,9 +134,7 @@
       "socket.io-client>engine.io-client>ws>utf-8-validate": false,
       "@metamask/sdk-communication-layer>bufferutil": false,
       "@metamask/sdk-communication-layer>eciesjs>secp256k1": false,
-      "@metamask/sdk-communication-layer>utf-8-validate": false,
-      "@metamask/sdk-install-modal-web>@metamask/sdk-communication-layer>bufferutil": false,
-      "@metamask/sdk-install-modal-web>@metamask/sdk-communication-layer>utf-8-validate": false
+      "@metamask/sdk-communication-layer>utf-8-validate": false
     }
   }
 }

yarn.lock

@@ -11023,7 +11023,6 @@ __metadata:
   dependencies:
     "@lavamoat/allow-scripts": ^2.3.1
     "@metamask/auto-changelog": 3.1.0
-    "@metamask/sdk-communication-layer": "workspace:*"
     "@paulmillr/qr": ^0.2.1
     "@size-limit/preset-big-lib": ^11.0.2
     "@stencil/core": ^4.22.2
@@ -37703,7 +37702,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"magic-string@npm:^0.25.0, magic-string@npm:^0.25.1, magic-string@npm:^0.25.3, magic-string@npm:^0.25.7, magic-string@npm:^0.25.9":
+"magic-string@npm:^0.25.0, magic-string@npm:^0.25.1, magic-string@npm:^0.25.7, magic-string@npm:^0.25.9":
   version: 0.25.9
   resolution: "magic-string@npm:0.25.9"
   dependencies:
@@ -38091,7 +38090,6 @@ __metadata:
     patch-package: ^6.4.7
     prettier: ^2.3.2
     rimraf: ^3.0.2
-    rollup-plugin-node-polyfills: ^0.2.1
     serve: ^14.2.1
     ts-jest: ^29.0.3
     ts-node: ^10.9.1
@@ -45547,17 +45545,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"rollup-plugin-inject@npm:^3.0.0":
-  version: 3.0.2
-  resolution: "rollup-plugin-inject@npm:3.0.2"
-  dependencies:
-    estree-walker: ^0.6.1
-    magic-string: ^0.25.3
-    rollup-pluginutils: ^2.8.1
-  checksum: a014972c80fe34b8c8154056fa2533a8440066a31de831e3793fc21b15d108d92c22d8f7f472397bd5783d7c5e04d8cbf112fb72c5a26e997726e4eb090edad1
-  languageName: node
-  linkType: hard
-
 "rollup-plugin-jscc@npm:^2.0.0":
   version: 2.0.0
   resolution: "rollup-plugin-jscc@npm:2.0.0"
@@ -45609,15 +45596,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"rollup-plugin-node-polyfills@npm:^0.2.1":
-  version: 0.2.1
-  resolution: "rollup-plugin-node-polyfills@npm:0.2.1"
-  dependencies:
-    rollup-plugin-inject: ^3.0.0
-  checksum: e84645212c443aca3cfae2ba69f01c6d8c5c250f0bf651416b69a4572b60aae9da7cdd687de3ab9b903f7a1ab96b06b71f0c4927d1b02a37485360d2b563937b
-  languageName: node
-  linkType: hard
-
 "rollup-plugin-peer-deps-external@npm:^2.2.4":
   version: 2.2.4
   resolution: "rollup-plugin-peer-deps-external@npm:2.2.4"
@@ -45794,7 +45772,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"rollup-pluginutils@npm:^2.0.1, rollup-pluginutils@npm:^2.3.1, rollup-pluginutils@npm:^2.8.1, rollup-pluginutils@npm:^2.8.2":
+"rollup-pluginutils@npm:^2.0.1, rollup-pluginutils@npm:^2.3.1, rollup-pluginutils@npm:^2.8.2":
   version: 2.8.2
   resolution: "rollup-pluginutils@npm:2.8.2"
   dependencies: