Skip to content

Commit 07c9b14

Browse files
committed
feat(extension): use logger
1 parent 2447f4e commit 07c9b14

File tree

5 files changed

+22
-13
lines changed

5 files changed

+22
-13
lines changed

packages/extension/src/background.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,13 @@ import type { Json } from '@metamask/utils';
22
import { KernelCommandMethod, isKernelCommandReply } from '@ocap/kernel';
33
import type { KernelCommand } from '@ocap/kernel';
44
import { ChromeRuntimeDuplexStream } from '@ocap/streams/browser';
5-
import { delay } from '@ocap/utils';
5+
import { delay, makeLogger } from '@ocap/utils';
66

77
const OFFSCREEN_DOCUMENT_PATH = '/offscreen.html';
88

9-
main().catch(console.error);
9+
const logger = makeLogger('[background]');
10+
11+
main().catch(logger.error);
1012

1113
/**
1214
* The main function for the background script.
@@ -36,7 +38,7 @@ async function main(): Promise<void> {
3638
await offscreenStream.write(command);
3739
};
3840

39-
// globalThis.kernel will exist due to dev-console.js in background-trusted-prelude.js
41+
// globalThis.kernel will exist due to dev-logger.js in background-trusted-prelude.js
4042
Object.defineProperties(globalThis.kernel, {
4143
ping: {
4244
value: async () =>
@@ -56,22 +58,22 @@ async function main(): Promise<void> {
5658
sendClusterCommand({
5759
method: KernelCommandMethod.ping,
5860
params: [],
59-
}).catch(console.error);
61+
}).catch(logger.error);
6062
});
6163

6264
// Handle replies from the offscreen document
6365
for await (const message of offscreenStream) {
6466
if (!isKernelCommandReply(message)) {
65-
console.error('Background received unexpected message', message);
67+
logger.error('Background received unexpected message', message);
6668
continue;
6769
}
6870

6971
switch (message.method) {
7072
case KernelCommandMethod.ping:
71-
console.log(message.params);
73+
logger.log(message.params);
7274
break;
7375
default:
74-
console.error(
76+
logger.error(
7577
// @ts-expect-error Compile-time exhaustiveness check
7678
`Background received unexpected command method: "${message.method.valueOf()}"`,
7779
);

packages/extension/src/iframe.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,11 @@ import {
44
MessagePortDuplexStream,
55
receiveMessagePort,
66
} from '@ocap/streams/browser';
7+
import { makeLogger } from '@ocap/utils';
78

8-
main().catch(console.error);
9+
const logger = makeLogger('[iframe]');
10+
11+
main().catch(logger.error);
912

1013
/**
1114
* The main function for the iframe.
@@ -30,5 +33,5 @@ async function main(): Promise<void> {
3033
commandStream,
3134
});
3235

33-
console.log('VatSupervisor initialized with vatId:', vatId);
36+
logger.log('VatSupervisor initialized with vatId:', vatId);
3437
}

packages/extension/src/kernel-integration/iframe-vat-worker.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import { createWindow } from '@metamask/snaps-utils';
22
import type { VatId, VatConfig } from '@ocap/kernel';
33
import type { initializeMessageChannel } from '@ocap/streams/browser';
4+
import { makeLogger } from '@ocap/utils';
5+
import type { Logger } from '@ocap/utils';
46

57
import type { VatWorker } from './VatWorkerServer.ts';
68

@@ -9,8 +11,10 @@ const IFRAME_URI = 'iframe.html';
911
export const makeIframeVatWorker = (
1012
id: VatId,
1113
getPort: typeof initializeMessageChannel,
14+
parentLogger?: Logger,
1215
): VatWorker => {
1316
const vatHtmlId = `ocap-iframe-${id}`;
17+
const logger = makeLogger(`[${vatHtmlId}]`, parentLogger);
1418
return {
1519
launch: async (_vatConfig: VatConfig) => {
1620
const newWindow = await createWindow({
@@ -27,7 +31,7 @@ export const makeIframeVatWorker = (
2731
terminate: async (): Promise<void> => {
2832
const iframe = document.getElementById(vatHtmlId);
2933
if (iframe === null) {
30-
console.error(
34+
logger.error(
3135
`iframe of vat with id "${id}" already removed from DOM (#${vatHtmlId})`,
3236
);
3337
return undefined;

packages/extension/src/kernel-integration/kernel-worker.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,9 @@ async function main(): Promise<void> {
8888
(async () => {
8989
if (launchDefaultSubcluster) {
9090
const result = await kernel.launchSubcluster(defaultSubcluster);
91-
console.log(`Subcluster launched: ${JSON.stringify(result)}`);
91+
logger.log(`Subcluster launched: ${JSON.stringify(result)}`);
9292
} else {
93-
console.log(`Resuming kernel execution`);
93+
logger.log(`Resuming kernel execution`);
9494
}
9595
})(),
9696
]);

packages/extension/src/offscreen.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ async function makeKernelWorker(): Promise<{
6161

6262
const vatWorkerServer = ExtensionVatWorkerServer.make(
6363
worker as PostMessageTarget,
64-
(vatId) => makeIframeVatWorker(vatId, initializeMessageChannel),
64+
(vatId) => makeIframeVatWorker(vatId, initializeMessageChannel, logger),
6565
);
6666

6767
return {

0 commit comments

Comments
 (0)