fix Messages stuck in queue when write fails on replaced channel

Author: sirtimid

packages/ocap-kernel/src/remotes/network.ts

@@ -805,6 +805,16 @@ export async function initNetwork(
       // Re-fetch queue in case cleanupStalePeers deleted it during the await
       const currentQueue = getMessageQueue(targetPeerId);
       currentQueue.enqueue(message);
+
+      // If a new channel is active (stale channel was replaced by inbound connection),
+      // flush the queue on it to prevent messages from being stuck indefinitely
+      const newChannel = channels.get(targetPeerId);
+      if (newChannel && newChannel !== channel) {
+        logger.log(
+          `${targetPeerId}:: stale channel replaced, flushing queue on new channel`,
+        );
+        await flushQueuedMessages(targetPeerId, newChannel, currentQueue);
+      }
     }
   }
 

vitest.config.ts

@@ -130,7 +130,7 @@ export default defineConfig({
         'packages/kernel-ui/**': {
           statements: 97.57,
           functions: 97.29,
-          branches: 93.26,
+          branches: 93.25,
           lines: 97.57,
         },
         'packages/kernel-utils/**': {
@@ -158,10 +158,10 @@ export default defineConfig({
           lines: 22.22,
         },
         'packages/ocap-kernel/**': {
-          statements: 95.66,
+          statements: 95.58,
           functions: 98.56,
-          branches: 96.64,
-          lines: 95.66,
+          branches: 96.5,
+          lines: 95.58,
         },
         'packages/omnium-gatherum/**': {
           statements: 5.67,