refactor(omnium): Simplify CapletId validation to allow any ASCII string

Remove strict reverse DNS format requirement for CapletId to allow more flexibility during early development. Now accepts any non-empty ASCII string without whitespace, removing restrictions on hyphens, underscores, uppercase, and segment count.

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>

Author: rekmarks

packages/omnium-gatherum/src/controllers/caplet/types.test.ts

@@ -10,25 +10,23 @@ import {
 describe('isCapletId', () => {
   it.each([
     ['com.example.test', true],
-    ['org.metamask.keyring', true],
-    ['io.github.user.package', true],
-    ['a.b', true],
-    ['a1.b2', true],
-    ['test.caplet123', true],
+    ['simple', true],
+    ['bitcoin-signer', true],
+    ['test_caplet', true],
+    ['My-Caplet', true],
+    ['123', true],
+    ['a.b.c.d', true],
   ])('validates "%s" as %s', (value, expected) => {
     expect(isCapletId(value)).toBe(expected);
   });
 
   it.each([
-    ['', false],
-    ['single', false], // Must have at least 2 segments
-    ['com.Example.test', false], // No uppercase
-    ['com.123.test', false], // Segments cannot start with number
-    ['com..test', false], // Empty segment
-    ['com.test-name', false], // No hyphens
-    ['com.test_name', false], // No underscores
-    ['.com.test', false], // Cannot start with dot
-    ['com.test.', false], // Cannot end with dot
+    ['', false], // Empty
+    ['has space', false], // Whitespace
+    ['has\ttab', false], // Tab
+    ['has\nnewline', false], // Newline
+    ['café', false], // Non-ASCII
+    ['🎉', false], // Emoji
     [123, false], // Not a string
     [null, false],
     [undefined, false],
@@ -93,7 +91,7 @@ describe('isCapletManifest', () => {
   });
 
   it('rejects manifest with invalid id', () => {
-    expect(isCapletManifest({ ...validManifest, id: 'invalid' })).toBe(false);
+    expect(isCapletManifest({ ...validManifest, id: 'has space' })).toBe(false);
   });
 
   it('rejects manifest with invalid version', () => {
@@ -129,7 +127,7 @@ describe('assertCapletManifest', () => {
   });
 
   it('throws for invalid manifest', () => {
-    expect(() => assertCapletManifest({ id: 'bad' })).toThrow(
+    expect(() => assertCapletManifest({ id: '' })).toThrow(
       'Invalid CapletManifest',
     );
   });

packages/omnium-gatherum/src/controllers/caplet/types.ts

@@ -3,22 +3,23 @@ import type { Infer } from '@metamask/superstruct';
 import semverValid from 'semver/functions/valid';
 
 /**
- * Unique identifier for a Caplet.
- * Uses reverse domain notation (e.g., "com.example.bitcoin-signer").
+ * Unique identifier for a Caplet (any non-empty ASCII string without whitespace).
  */
 export type CapletId = string;
 
 /**
  * Validate CapletId format.
- * Requires lowercase alphanumeric segments separated by dots, minimum 2 segments.
+ * Requires non-empty ASCII string with no whitespace.
  *
  * @param value - The value to validate.
  * @returns True if valid CapletId format.
  */
 export const isCapletId = (value: unknown): value is CapletId =>
   typeof value === 'string' &&
   value.length > 0 &&
-  /^[a-z][a-z0-9]*(\.[a-z][a-z0-9]*)+$/u.test(value);
+  // eslint-disable-next-line no-control-regex
+  /^[\x00-\x7F]+$/u.test(value) && // ASCII only
+  !/\s/u.test(value); // No whitespace
 
 export const CapletIdStruct = define<CapletId>('CapletId', isCapletId);