Skip to content

Commit 0e3b3f5

Browse files
authored
Merge pull request #7 from MetaMask/ellul/rule-updates
Update rule repository
2 parents 3e845e3 + c91dcd3 commit 0e3b3f5

File tree

3 files changed

+6
-25
lines changed

3 files changed

+6
-25
lines changed

rules/src/github-actions/publish-actions-cache-used.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,19 @@ rules:
66
metadata:
77
tags: [security]
88
shortDescription: Potential cache poisoning risk by using `actions/cache` in a publishing workflow.
9+
confidence: MEDIUM
910
help: |
1011
## Remediation
11-
We recommend avoiding using `actions/cache` if this workflow publishes a release, or has access to sensitive secrets.
12+
We recommend avoiding using `actions/cache` if this workflow publishes a release or has access to sensitive secrets.
1213
If caching is required, please see https://github.com/MetaMask/MetaMask-planning/issues/3925 for a workaround.
1314
message: >-
1415
Using GitHub's Action Cache in publishing workflows, especially in open source repositories, can be dangerous. See
1516
https://github.com/MetaMask/MetaMask-planning/issues/3925 for more details and alternative recommendations.
1617
patterns:
17-
- patterns:
18-
- pattern: "uses: $ACTION_NAME"
19-
- metavariable-regex:
20-
metavariable: $ACTION_NAME
21-
regex: actions/cache@v[0-9]+
18+
- pattern: "uses: $ACTION_NAME"
19+
- metavariable-regex:
20+
metavariable: $ACTION_NAME
21+
regex: actions/cache@.+
2222
paths:
2323
include:
2424
- ".github/**/*publish*.yml"

rules/src/js/hello-world.yml

Lines changed: 0 additions & 14 deletions
This file was deleted.

rules/test/js/hello-world.js

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)