Minor fixes from review:

- Use current timestamp for revocationMetadata recordedAt fields for permissions marked with legacy isRevoked
- removed an errant isRevoked: false that was included on a new permission object

Author: jeffsmale90

packages/gator-permissions-snap/src/profileSync/profileSync.ts

@@ -62,7 +62,13 @@ function safeDeserializeStoredGrantedPermission(
     // handle legacy storage where `isRevoked` is set instead of `revocationMetadata`
     if (parsed.isRevoked && validated.revocationMetadata === undefined) {
       validated.revocationMetadata = {
-        recordedAt: 0,
+        // We haven't persisted the `recordedAt` timestamp, so we just use the
+        // current timestamp to indicate that it was "noticed" just now. This
+        // should never really happen in production, as only permissions revoked
+        // with pre-production versions would have been marked with `isRevoked`
+        // instead of `revocationMetadata`. The value is inconsequential, as
+        // it's only included for debugging purposes.
+        recordedAt: Math.floor(Date.now() / 1000),
       };
     }
 

packages/gator-permissions-snap/src/rpc/rpcHandler.ts

@@ -115,7 +115,6 @@ export function createRpcHandler({
       const storedPermission: StoredGrantedPermission = {
         permissionResponse: permissionResponse.response,
         siteOrigin,
-        isRevoked: false,
       };
       permissionsToStore.push(storedPermission);
     }

packages/gator-permissions-snap/test/profileSync/profileSync.test.ts

@@ -155,7 +155,8 @@ describe('profileSync', () => {
           {
             ...mockStoredGrantedPermission,
             revocationMetadata: {
-              recordedAt: 0,
+              // this will be set to the current timestamp when the permission is retrieved
+              recordedAt: expect.any(Number)
             },
           },
         ]);