fix: get delegation by hash

Author: hanzel98

packages/gator-permissions-snap/src/profileSync/profileSync.ts

@@ -96,6 +96,9 @@ export type ProfileSyncManager = {
   getGrantedPermission: (
     permissionContext: Hex,
   ) => Promise<StoredGrantedPermission | null>;
+  getGrantedPermissionByDelegationHash: (
+    delegationHash: Hex,
+  ) => Promise<StoredGrantedPermission | null>;
   storeGrantedPermission: (
     storedGrantedPermission: StoredGrantedPermission,
   ) => Promise<void>;
@@ -150,6 +153,12 @@ export function createProfileSyncManager(
         'unConfiguredProfileSyncManager.getPermissionByHash not implemented',
       );
     },
+    getGrantedPermissionByDelegationHash: async (_: Hex) => {
+      logger.debug(
+        'unConfiguredProfileSyncManager.getGrantedPermissionByDelegationHash()',
+      );
+      return null;
+    },
     storeGrantedPermission: async (_: StoredGrantedPermission) => {
       logger.debug(
         'unConfiguredProfileSyncManager.storeGrantedPermissionBatch()',
@@ -268,6 +277,34 @@ export function createProfileSyncManager(
     }
   }
 
+  /**
+   * Retrieve a granted permission by delegation hash using direct storage lookup.
+   * Since delegation hashes are unique, we can use them directly as storage keys.
+   * @param delegationHash - The delegation hash to search for.
+   * @returns The granted permission or null if not found.
+   */
+  async function getGrantedPermissionByDelegationHash(
+    delegationHash: Hex,
+  ): Promise<StoredGrantedPermission | null> {
+    try {
+      await authenticate();
+
+      // Use the delegation hash directly as the storage key
+      const path: UserStorageGenericPathWithFeatureAndKey = `${FEATURE}.${delegationHash}`;
+
+      const permission = await userStorage.getItem(path);
+
+      if (!permission) {
+        return null;
+      }
+
+      return safeDeserializeStoredGrantedPermission(permission);
+    } catch (error) {
+      logger.error('Error fetching permission by delegation hash');
+      throw error;
+    }
+  }
+
   /**
    * Store the granted permission in profile sync.
    *
@@ -466,6 +503,7 @@ export function createProfileSyncManager(
     ? {
         getAllGrantedPermissions,
         getGrantedPermission,
+        getGrantedPermissionByDelegationHash,
         storeGrantedPermission,
         storeGrantedPermissionBatch,
         updatePermissionRevocationStatus,

packages/gator-permissions-snap/src/rpc/rpcHandler.ts

@@ -145,7 +145,9 @@ export function createRpcHandler(config: {
 
     // First, get the existing permission to validate it exists
     const existingPermission =
-      await profileSyncManager.getGrantedPermission(delegationHash);
+      await profileSyncManager.getGrantedPermissionByDelegationHash(
+        delegationHash,
+      );
 
     if (!existingPermission) {
       throw new InvalidInputError(

packages/gator-permissions-snap/src/utils/validate.ts

@@ -37,7 +37,10 @@ export const validateStartTimeZod = (value: number): boolean => {
 const zRevocationParams = z.object({
   delegationHash: z
     .string()
-    .regex(/^0x[a-fA-F0-9]{64}$/u, 'Invalid delegation hash'),
+    .regex(
+      /^0x[a-fA-F0-9]{64}$/u,
+      'Invalid delegation hash format - must be a 32-byte hex string',
+    ),
 });
 
 /**

packages/gator-permissions-snap/test/rpc/rpcHandler.test.ts

@@ -96,6 +96,7 @@ describe('RpcHandler', () => {
       storeGrantedPermission: jest.fn(),
       storeGrantedPermissionBatch: jest.fn(),
       getGrantedPermission: jest.fn(),
+      getGrantedPermissionByDelegationHash: jest.fn(),
       getAllGrantedPermissions: jest.fn(),
       getUserProfile: jest.fn(),
       updatePermissionRevocationStatus: jest.fn(),
@@ -629,7 +630,7 @@ describe('RpcHandler', () => {
         isRevoked: false,
       };
 
-      mockProfileSyncManager.getGrantedPermission.mockResolvedValueOnce(
+      mockProfileSyncManager.getGrantedPermissionByDelegationHash.mockResolvedValueOnce(
         mockPermission,
       );
       mockProfileSyncManager.checkDelegationDisabledOnChain.mockResolvedValueOnce(
@@ -642,9 +643,9 @@ describe('RpcHandler', () => {
       const result = await handler.submitRevocation(validRevocationParams);
 
       expect(result).toStrictEqual({ success: true });
-      expect(mockProfileSyncManager.getGrantedPermission).toHaveBeenCalledWith(
-        validRevocationParams.delegationHash,
-      );
+      expect(
+        mockProfileSyncManager.getGrantedPermissionByDelegationHash,
+      ).toHaveBeenCalledWith(validRevocationParams.delegationHash);
       expect(
         mockProfileSyncManager.checkDelegationDisabledOnChain,
       ).toHaveBeenCalledWith(
@@ -730,7 +731,7 @@ describe('RpcHandler', () => {
       };
 
       const profileSyncError = new Error('Update failed');
-      mockProfileSyncManager.getGrantedPermission.mockResolvedValueOnce(
+      mockProfileSyncManager.getGrantedPermissionByDelegationHash.mockResolvedValueOnce(
         mockPermission,
       );
       mockProfileSyncManager.checkDelegationDisabledOnChain.mockResolvedValueOnce(
@@ -778,7 +779,7 @@ describe('RpcHandler', () => {
         isRevoked: false,
       };
 
-      mockProfileSyncManager.getGrantedPermission.mockResolvedValueOnce(
+      mockProfileSyncManager.getGrantedPermissionByDelegationHash.mockResolvedValueOnce(
         mockPermission,
       );
       mockProfileSyncManager.checkDelegationDisabledOnChain.mockResolvedValueOnce(
@@ -791,9 +792,9 @@ describe('RpcHandler', () => {
       const result = await handler.submitRevocation(upperCaseParams);
 
       expect(result).toStrictEqual({ success: true });
-      expect(mockProfileSyncManager.getGrantedPermission).toHaveBeenCalledWith(
-        upperCaseParams.delegationHash,
-      );
+      expect(
+        mockProfileSyncManager.getGrantedPermissionByDelegationHash,
+      ).toHaveBeenCalledWith(upperCaseParams.delegationHash);
     });
 
     it('should handle different chain configurations', async () => {
@@ -824,7 +825,7 @@ describe('RpcHandler', () => {
         isRevoked: false,
       };
 
-      mockProfileSyncManager.getGrantedPermission.mockResolvedValueOnce(
+      mockProfileSyncManager.getGrantedPermissionByDelegationHash.mockResolvedValueOnce(
         mockPermission,
       );
       mockProfileSyncManager.checkDelegationDisabledOnChain.mockResolvedValueOnce(
@@ -837,9 +838,9 @@ describe('RpcHandler', () => {
       const result = await handler.submitRevocation(testParams);
 
       expect(result).toStrictEqual({ success: true });
-      expect(mockProfileSyncManager.getGrantedPermission).toHaveBeenCalledWith(
-        testParams.delegationHash,
-      );
+      expect(
+        mockProfileSyncManager.getGrantedPermissionByDelegationHash,
+      ).toHaveBeenCalledWith(testParams.delegationHash);
     });
   });
 });