feat: add lifecycle hooks permission for local development and refactor onInstall handler

Author: mj-kiwi

packages/gator-permissions-snap/snap.manifest.ts

@@ -4,6 +4,7 @@
 import type { SnapManifest } from '@metamask/7715-permissions-shared/types';
 
 const kernelSnapId = process.env.KERNEL_SNAP_ID;
+const snapEnv = process.env.SNAP_ENV;
 
 const manifest: SnapManifest = {
   version: '0.2.1',
@@ -33,13 +34,17 @@ const manifest: SnapManifest = {
     'endowment:ethereum-provider': {},
     'endowment:network-access': {},
     snap_dialog: {},
-    'endowment:lifecycle-hooks': {},
     snap_getPreferences: {},
   },
   platformVersion: '8.1.0',
   manifestVersion: '0.1',
 };
 
+// Only include lifecycle hooks permission in local development
+if (snapEnv === 'local') {
+  manifest.initialPermissions['endowment:lifecycle-hooks'] = {};
+}
+
 if (kernelSnapId) {
   manifest.initialConnections = {
     [kernelSnapId]: {},

packages/gator-permissions-snap/src/index.ts

@@ -220,29 +220,35 @@ export const onRpcRequest: OnRpcRequestHandler = async ({
 export const onUserInput: OnUserInputHandler =
   userEventDispatcher.createUserInputEventHandler();
 
-export const onInstall: OnInstallHandler = async () => {
-  /**
-   * Local Development Only
-   *
-   * The message signing snap must be installed and the gator permissions snap must
-   * have permission to communicate with the message signing snap, or the request is rejected.
-   *
-   * Since the message signing snap is preinstalled in production, and has
-   * initialConnections configured to automatically connect to the gator snap, this is not needed in production.
-   */
-  // eslint-disable-next-line no-restricted-globals
-  if (snapEnv === 'local' && isStorePermissionsFeatureEnabled) {
-    const installedSnaps = (await snap.request({
-      method: 'wallet_getSnaps',
-    })) as unknown as GetSnapsResponse;
-    if (!installedSnaps[messageSigningSnapId]) {
-      logger.debug('Installing local message signing snap');
-      await snap.request({
-        method: 'wallet_requestSnaps',
-        params: {
-          [messageSigningSnapId]: {},
-        },
-      });
+/**
+ * Local Development Only
+ *
+ * The message signing snap must be installed and the gator permissions snap must
+ * have permission to communicate with the message signing snap, or the request is rejected.
+ *
+ * Since the message signing snap is preinstalled in production, and has
+ * initialConnections configured to automatically connect to the gator snap, this is not needed in production.
+ */
+// eslint-disable-next-line no-restricted-globals
+if (snapEnv === 'local') {
+  const installHandler: OnInstallHandler = async () => {
+    if (isStorePermissionsFeatureEnabled) {
+      const installedSnaps = (await snap.request({
+        method: 'wallet_getSnaps',
+      })) as unknown as GetSnapsResponse;
+      if (!installedSnaps[messageSigningSnapId]) {
+        logger.debug('Installing local message signing snap');
+        await snap.request({
+          method: 'wallet_requestSnaps',
+          params: {
+            [messageSigningSnapId]: {},
+          },
+        });
+      }
     }
-  }
-};
+  };
+
+  // Export onInstall for local development only
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  (globalThis as any).onInstall = installHandler;
+}