test: increase test coverage (#51)

## Description

PR adds more unit tests for specific flows and error messages with the
`keyring.ts` file. There is a minor refactor in the createAccount method
to check for duplicate accounts.

* Fixes
[#254](https://app.zenhub.com/workspaces/metamask-accounts-team-v2-64c91cbeaa9d1c00126621fd/issues/gh/metamask/accounts-planning/254)
* See:
[#244](https://app.zenhub.com/workspaces/metamask-accounts-team-v2-64c91cbeaa9d1c00126621fd/issues/gh/metamask/accounts-planning/244)

## Pre-requisites

- [ ] https://github.com/MetaMask/accounts-planning/issues/308
  * [x] MetaMask/eth-snap-keyring#231
  * [ ] https://github.com/MetaMask/accounts-planning/issues/307

## Test Coverage Report

### Summary

The test coverage has been updated as part of the efforts to increase
the code coverage for the `snap-account-abstraction-keyring` module. The
tests were executed with `yarn test:coverage --no-cache`, ensuring that
cached results did not influence the outcomes. The coverage for the
`keyring.ts` file is now above 95%.

- **Test Suites**: 1 passed, 1 total
- **Tests**: 35 passed, 35 total

### Coverage Overview

```plaintext
---------------------|---------|----------|---------|---------|-------------------------
File                 | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s       
---------------------|---------|----------|---------|---------|-------------------------
All files            |   87.58 |    60.63 |   82.45 |   87.75 |                         
 snap                |     100 |      100 |     100 |     100 |                         
  hardhat.config.ts  |     100 |      100 |     100 |     100 |                         
 snap/src            |   92.34 |    67.74 |    87.5 |   92.26 |                         
  keyring.ts         |   95.67 |    67.92 |     100 |   95.62 | 195,443-445,547-549,562 
  logger.ts          |      75 |    57.14 |   55.55 |      75 | 64,81-92,112-122        
  permissions.ts     |     100 |      100 |     100 |     100 |                         
  stateManagement.ts |    62.5 |      100 |      50 |    62.5 | 18-25                   
 snap/src/constants  |   93.75 |        0 |     100 |   93.75 |                         
  aa-factories.ts    |     100 |      100 |     100 |     100 |                         
  chain-ids.ts       |     100 |      100 |     100 |     100 |                         
  chainConfig.ts     |     100 |      100 |     100 |     100 |                         
  dummy-values.ts    |   88.88 |        0 |     100 |   88.88 | 15                      
  entrypoints.ts     |     100 |      100 |     100 |     100 |                         
 snap/src/utils      |      72 |    42.85 |   68.75 |    72.6 |                         
  ecdsa.ts           |     100 |      100 |     100 |     100 |                         
  util.ts            |   43.33 |        0 |      50 |   42.85 | 15-27,37-49,105         
  validation.ts      |   89.47 |       80 |     100 |   89.47 | 49,81-84,88             
---------------------|---------|----------|---------|---------|-------------------------

---------

Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>

Author: k-g-j

packages/site/package.json

@@ -33,6 +33,7 @@
     "@emotion/styled": "^11.11.0",
     "@metamask/keyring-api": "^3.0.0",
     "@metamask/providers": "^14.0.2",
+    "@metamask/snap-account-abstraction-keyring": "workspace:^",
     "@mui/icons-material": "^5.14.0",
     "@mui/material": "^5.14.0",
     "@types/react-helmet": "^6.1.6",

packages/site/src/pages/index.tsx

@@ -1,5 +1,9 @@
 import type { KeyringAccount, KeyringRequest } from '@metamask/keyring-api';
 import { KeyringSnapRpcClient } from '@metamask/keyring-api';
+import {
+  CaipNamespaces,
+  toCaipChainId,
+} from '@metamask/snap-account-abstraction-keyring/src/utils/caip';
 import Grid from '@mui/material/Grid';
 import React, { useContext, useEffect, useState } from 'react';
 import * as uuid from 'uuid';
@@ -99,9 +103,13 @@ const Index = () => {
     if (!chainConfig) {
       return;
     }
+    const reference = window.ethereum.chainId;
+    if (!reference) {
+      throw new Error('No chain ID found');
+    }
     const request: KeyringRequest = {
       id: uuid.v4(),
-      scope: '',
+      scope: `${toCaipChainId(CaipNamespaces.Eip155, reference)}`,
       account: uuid.v4(),
       request: {
         method: 'snap.internal.setConfig',

packages/snap/jest.config.js

@@ -10,4 +10,11 @@ module.exports = {
     'contracts',
     'artifacts',
   ],
+  coverageThreshold: {
+    './src/keyring.ts': {
+      statements: 95,
+      functions: 95,
+      lines: 95,
+    },
+  },
 };

packages/snap/package.json

@@ -40,7 +40,8 @@
     "lint:types": "tsc --noEmit",
     "serve": "mm-snap serve",
     "start": "NODE_ENV='development' mm-snap watch",
-    "test": "jest --detectOpenHandles"
+    "test": "jest --detectOpenHandles",
+    "test:coverage": "jest --detectOpenHandles --coverage"
   },
   "dependencies": {
     "@ethereumjs/tx": "^5.1.0",
@@ -86,6 +87,7 @@
     "hardhat": "^2.19.4",
     "hardhat-gas-reporter": "^1.0.8",
     "jest": "^29.7.0",
+    "jest-extended": "^4.0.2",
     "prettier": "^2.2.1",
     "rimraf": "^3.0.2",
     "solidity-coverage": "^0.8.1",

packages/snap/snap.manifest.json

@@ -7,7 +7,7 @@
     "url": "git+https://github.com/MetaMask/snap-account-abstraction-keyring.git"
   },
   "source": {
-    "shasum": "WfB+J7Rzl/po7NKMCmFe9KLNUfps/dncIaWtCm/WvWQ=",
+    "shasum": "yGUjODv2K9nZZ0a2us4NLGJPmV61Rtz0tXoIKOB00cU=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",